Non-core contributed modules

Please update contact form in contrib

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9, 1.9.1, 1.9.2, 1.9.3, 1.9.4
  • Fix Version/s: None
  • Component/s: Block: Contact form
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

Please move the contact_form currently in the 1.9 and head branches of contrib to the 1.8 branch, then use the attached zip for the 1.9 and head branches of contrib?

Thanks,
Matt

Attachments

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

Matt - Would you like to have CVS write access to contrib/plugins/blocks/contact_form or are you happy just using the tracker? Back in CONTRIB-190 we created the 18STABLE branch so I wanted to make sure that you want me change that code. Similarly, there already is a 1.9 stable branch. If you had CVS access you could handle this on your own. Let me know how you would like to proceed. I would obviously have a slight preference for you to have CVS write access but I'll wait to hear back from you. Peace - Anthony

Show
Anthony Borrow added a comment - Matt - Would you like to have CVS write access to contrib/plugins/blocks/contact_form or are you happy just using the tracker? Back in CONTRIB-190 we created the 18STABLE branch so I wanted to make sure that you want me change that code. Similarly, there already is a 1.9 stable branch. If you had CVS access you could handle this on your own. Let me know how you would like to proceed. I would obviously have a slight preference for you to have CVS write access but I'll wait to hear back from you. Peace - Anthony
Hide
Permalink
Matt Campbell added a comment -

I wouldn't mind having write access to contrib/plugins/blocks/contact_form and could handle simple updates, but I'm really not sure how to go about moving an item from one branch to another. The version that's in 18STABLE branch should really be in 17STABLE, and the version in 19STABLE and HEAD should really be in 18STABLE. I don't think I'm up to fixing all of that and would most likely make a mistake - if you'd do this, I'd appreciate it. I haven't looked at 17STABLE to see what's there, most likely it's the same as 18STABLE or isn't there at all.

Thanks,
Matt

Show
Matt Campbell added a comment - I wouldn't mind having write access to contrib/plugins/blocks/contact_form and could handle simple updates, but I'm really not sure how to go about moving an item from one branch to another. The version that's in 18STABLE branch should really be in 17STABLE, and the version in 19STABLE and HEAD should really be in 18STABLE. I don't think I'm up to fixing all of that and would most likely make a mistake - if you'd do this, I'd appreciate it. I haven't looked at 17STABLE to see what's there, most likely it's the same as 18STABLE or isn't there at all. Thanks, Matt
Hide
Permalink
Daniele Cordella added a comment -

Ciao Antony and Matt
as developer of this last release of contact_form
am I allowed to ask (and to get) for the CVS write access to contrib/plugins/blocks/contact_form folder?

Show
Daniele Cordella added a comment - Ciao Antony and Matt as developer of this last release of contact_form am I allowed to ask (and to get) for the CVS write access to contrib/plugins/blocks/contact_form folder?
Hide
Permalink
Anthony Borrow added a comment -

Daniele - Absolutely! What I try to do with add all new code to CVS so that I can test it, figure out where it works best, help get it so that it is functional without too many PHP warnings and notices, with the files in right places and names, etc. It is a chance to do a little QA and help folks learn how to better write code the works well with Moodle. After it is uploaded to the server certainly the developer(s) should have write access. I believe this project was a contribution of three persons (Matt Campbell, yourself, and Daryl Hayes). So all three of you are encouraged to apply for CVS write access. Usually I like to designate a single person to serve as the official "maintainer" of the code. And I allow them to make decisions about who should have CVS access especially if it is someone new getting involved. Currently that person is Matt just because he was the one who filed the entry in the Modules and Plugins database. We also ought to create a component in the tracker and I'll assign Matt as the lead there which means that the bugs reports, feature requests, etc. will be assigned first to him and then he can manage them from there; however, I could add all three of you to the CONTRIB developers group which would bump your privileges in the tracker so that all three of you could manage those issues. With newer contributions, I have been trying to ensure that all the steps in http://docs.moodle.org/en/Development:Guidelines_for_contributed_code are followed so that the code has everything it needs to be shared and supported. Let me know if there is anything else I can do to support your generous efforts in sharing and maintaining this code with the Moodle community. Peace - Anthony

Show
Anthony Borrow added a comment - Daniele - Absolutely! What I try to do with add all new code to CVS so that I can test it, figure out where it works best, help get it so that it is functional without too many PHP warnings and notices, with the files in right places and names, etc. It is a chance to do a little QA and help folks learn how to better write code the works well with Moodle. After it is uploaded to the server certainly the developer(s) should have write access. I believe this project was a contribution of three persons (Matt Campbell, yourself, and Daryl Hayes). So all three of you are encouraged to apply for CVS write access. Usually I like to designate a single person to serve as the official "maintainer" of the code. And I allow them to make decisions about who should have CVS access especially if it is someone new getting involved. Currently that person is Matt just because he was the one who filed the entry in the Modules and Plugins database. We also ought to create a component in the tracker and I'll assign Matt as the lead there which means that the bugs reports, feature requests, etc. will be assigned first to him and then he can manage them from there; however, I could add all three of you to the CONTRIB developers group which would bump your privileges in the tracker so that all three of you could manage those issues. With newer contributions, I have been trying to ensure that all the steps in http://docs.moodle.org/en/Development:Guidelines_for_contributed_code are followed so that the code has everything it needs to be shared and supported. Let me know if there is anything else I can do to support your generous efforts in sharing and maintaining this code with the Moodle community. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

moving issue to newly created Block: Contact form component

Show
Anthony Borrow added a comment - moving issue to newly created Block: Contact form component
Hide
Permalink
Anthony Borrow added a comment -

Attached are two zip files - contact_form_17.zip was previously the 18STABLE branch and contact_form_18.zip was previously the 19STABLE branch.

Show
Anthony Borrow added a comment - Attached are two zip files - contact_form_17.zip was previously the 18STABLE branch and contact_form_18.zip was previously the 19STABLE branch.
Hide
Permalink
Daniele Cordella added a comment -

Thanks Antony.
I also have an ace among friends. Abix. So if I need help, I will ask him to support me.
I'll try with deep care to start using this new privilege!!!
Thanks again.

Show
Daniele Cordella added a comment - Thanks Antony. I also have an ace among friends. Abix. So if I need help, I will ask him to support me. I'll try with deep care to start using this new privilege!!! Thanks again.
Hide
Permalink
Anthony Borrow added a comment -

Matt - I believe that I have everything moved as requested. I did make sure to rename any language directories from /lang/en to /lang/en_utf8. I'm going ahead and resolving this but feel free to comment if you need anything else. Peace - Anthony

Show
Anthony Borrow added a comment - Matt - I believe that I have everything moved as requested. I did make sure to rename any language directories from /lang/en to /lang/en_utf8. I'm going ahead and resolving this but feel free to comment if you need anything else. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I've verified that both Matt and Daniele have privileges on the tracker to manage issues related to the content form block. Is Daryl still involved with the development? If so, Matt could you contact him and ask him to apply for CVS write access. Also, should Daryl have the ability to manage issues in the tracker? I'm open to setting things up for you all so that it works best for you all in managing things so just let me know what I can do. Thanks Daniele for being careful but don't worry too much as there are few things that you can do that cannot be undone. If you have questions, don't be shy. After all, that is how we all learn. I often learn something from the questions folks ask whether I have an answer or not. Peace - Anthony

Show
Anthony Borrow added a comment - I've verified that both Matt and Daniele have privileges on the tracker to manage issues related to the content form block. Is Daryl still involved with the development? If so, Matt could you contact him and ask him to apply for CVS write access. Also, should Daryl have the ability to manage issues in the tracker? I'm open to setting things up for you all so that it works best for you all in managing things so just let me know what I can do. Thanks Daniele for being careful but don't worry too much as there are few things that you can do that cannot be undone. If you have questions, don't be shy. After all, that is how we all learn. I often learn something from the questions folks ask whether I have an answer or not. Peace - Anthony
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Perhaps, Daniele, are you asking about how to get write access? It simple:

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Perhaps, Daniele, are you asking about how to get write access? It simple: Ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

FYI (anthony), I've approved Daniele request in http://moodle.org/cvs granting him access to that block in contrib. He was really lucky because exactly today was my yearly review of those requests. :-D

Ciao

Show
Eloy Lafuente (stronk7) added a comment - FYI (anthony), I've approved Daniele request in http://moodle.org/cvs granting him access to that block in contrib. He was really lucky because exactly today was my yearly review of those requests. :-D Ciao
Hide
Permalink
Daniele Cordella added a comment -

Thnaks Eloy. Four years already left. How fast is the time!!!!

Show
Daniele Cordella added a comment - Thnaks Eloy. Four years already left. How fast is the time!!!!
Hide
Permalink
Anthony Borrow added a comment -

Thanks Eloy - I try to check the requests regularly but got behind when during my travels abroad. I am focusing on staying up with incoming projects and working through the backlog as I have time. Peace - Anthony

Show
Anthony Borrow added a comment - Thanks Eloy - I try to check the requests regularly but got behind when during my travels abroad. I am focusing on staying up with incoming projects and working through the backlog as I have time. Peace - Anthony
Hide
Permalink
Matt Campbell added a comment -

Daryl hasn't been active on the development on this block since 1.5 or so, but I feel that he deserves credit for the work he did in getting all of this going. Daniele did a considerable amount of rewrite on this version so the code is consiederably different from what it once was. My main focus has always been to keep it working across the versions and debug - Daryl, then Daniele and Valery and then Daniele again have done all the major rewrites. I will see if I can contact Daryl and ask him if he can give us some input on what level of access he wants, if any.

Thanks,
Matt

Show
Matt Campbell added a comment - Daryl hasn't been active on the development on this block since 1.5 or so, but I feel that he deserves credit for the work he did in getting all of this going. Daniele did a considerable amount of rewrite on this version so the code is consiederably different from what it once was. My main focus has always been to keep it working across the versions and debug - Daryl, then Daniele and Valery and then Daniele again have done all the major rewrites. I will see if I can contact Daryl and ask him if he can give us some input on what level of access he wants, if any. Thanks, Matt
Hide
Permalink
Anthony Borrow added a comment -

Matt - Thanks for a bit of the history behind the development. This kind of information I think is good to have in the README.txt file and is a good way to make sure that folks get credit/recognition for the work they have done. I'll consider you as the primary lead on this unless you tell me otherwise. I got your message about requesting CVS access. There is no rush. Safe travels! Peace - Anthony

Show
Anthony Borrow added a comment - Matt - Thanks for a bit of the history behind the development. This kind of information I think is good to have in the README.txt file and is a good way to make sure that folks get credit/recognition for the work they have done. I'll consider you as the primary lead on this unless you tell me otherwise. I got your message about requesting CVS access. There is no rush. Safe travels! Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Closing all of my resolved issues. Peace - Anthony

Show
Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.