Non-core contributed modules

Incorrect language handling in some modules with the dependent language packs

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Duplicate
  • Affects Version/s: 1.9.4
  • Fix Version/s: None
  • Component/s: Block: Mrbs, Module: Gallery
  • Labels:
    None
  • Environment:
    Moodle 1.9.4+ (Build: 20090217)
  • Affected Branches:
    MOODLE_19_STABLE

Description

I found out that some moduls do not use the german language pack correctly that comes together with the modul.

If a user sets a dependent language packs then Moodle should show the strings from the parent language when Moodle could not find the child language. The modul LightBoxGallery and the block MRBS are shown with english strings when the user sets his own language to "Deutsch (de_du)".

This should be wrong!! Please also look into http://tracker.moodle.org/browse/CONTRIB-957

I met Martin at the MoodleMoot 2009 in Bamberg/Germany and told him about this. Sorry, but I can't add Martin into a list of addressees for this bug report. Please help ....

Best regards, Ralf

Issue Links

This issue duplicates:
CONTRIB-957 Incorrect language handling in MRBS Major Resolved
MDL-17763 get_string: parent language not getting checked for blocks and similar additional locations in particular cases Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

Ralf - This is the same issue you have already reported. I have provided a patch but it has not been incorporated. Further, I have detailed what it is that you need to do to work around this issue. If you create a /blocks/mrbs/lang/de_du_utf8/langconfig.php file and define the parent language the problem should go away. We could add this to the MRBS block if you would like. If so, please comment on CONTRIB-957 and I'll go ahead and do that. Peace - Anthony

Show
Anthony Borrow added a comment - Ralf - This is the same issue you have already reported. I have provided a patch but it has not been incorporated. Further, I have detailed what it is that you need to do to work around this issue. If you create a /blocks/mrbs/lang/de_du_utf8/langconfig.php file and define the parent language the problem should go away. We could add this to the MRBS block if you would like. If so, please comment on CONTRIB-957 and I'll go ahead and do that. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

resolving as duplicate

Show
Anthony Borrow added a comment - resolving as duplicate
Hide
Permalink
Ralf Krause added a comment -

Hi Anthony

no, the message is not duplicate! I told Martin about it and I found more moduls than only MRBS with the same mistake. It should be better to close the other track CONTRIB-957 because it seems to be a bug in Moodle and not only in MRBS.

Ralf

Show
Ralf Krause added a comment - Hi Anthony no, the message is not duplicate! I told Martin about it and I found more moduls than only MRBS with the same mistake. It should be better to close the other track CONTRIB-957 because it seems to be a bug in Moodle and not only in MRBS. Ralf
Hide
Permalink
Anthony Borrow added a comment -

Ralf - I still consider this a duplicate primarily of MDL-17763 which will improve for all plugins how it finds the parent language. It is a duplicate of CONTRIB-957 as that one is specifically for the MRBS block. I do not see the advantage to having a separate issue open; however, if you want I can re-open this issue and assign it to Mark Nielsen (maintainer of the Gallery module); however, from what I can tell there is no German language pack as part of the module so I am not sure how you would want him to handle that. Do you have a translation for Mark? I still think the easiest thing for you to do is to create /blocks/mrbs/lang/de_du_utf8/langconfig.php with the line:

$string['parentlanguage']='de_utf8';

Peace - Anthony

Show
Anthony Borrow added a comment - Ralf - I still consider this a duplicate primarily of MDL-17763 which will improve for all plugins how it finds the parent language. It is a duplicate of CONTRIB-957 as that one is specifically for the MRBS block. I do not see the advantage to having a separate issue open; however, if you want I can re-open this issue and assign it to Mark Nielsen (maintainer of the Gallery module); however, from what I can tell there is no German language pack as part of the module so I am not sure how you would want him to handle that. Do you have a translation for Mark? I still think the easiest thing for you to do is to create /blocks/mrbs/lang/de_du_utf8/langconfig.php with the line: $string['parentlanguage']='de_utf8'; Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Closing all of my resolved issues. Peace - Anthony

Show
Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.