Issue Details (XML | Word | Printable)

Key: CONTRIB-1191
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Mike Worth
Reporter: Mike Worth
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Non-core contributed modules

Change to allow the display of simultanious bookings in the same room

Created: 21/Apr/09 07:32 PM   Updated: 19/Jun/09 05:57 PM
Return to search
Component/s: Block: Mrbs
Affects Version/s: 1.9.4
Fix Version/s: None

File Attachments: 1. Text File mrbsdoublebookdiff.txt (4 kB)
2. Text File mrbsdoublebookdiff.txt (24 kB)
3. Text File mrbsdoublebookdiff.txt (3 kB)

Issue Links:
Relates
 

Participants: Anthony Borrow and Mike Worth
Security Level: None
Resolved date: 02/Jun/09
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
In my college it is not unusual for some rooms to have multiple simultaneous bookings.

The most common example is when a subject like french has an AS class and an IB class, they are both taught by the same teacher, in the same room, at the same time. They are 2 distinct groups as far as the MIS is concerned so that exam entry etc. doesn't become a nightmare. The bookings themselves get into the database via my timetable import script (CONTRIB-1189)

This patch only works on the display side of things (using this patch will not allow you any new ways to bypass the validation). It displays simultaneous bookings in a different colour (configurable in the css as TD.DoubleBooked) and prints the details of both rather than overriding with the last booking (the default behaviour)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Mike Worth added a comment - 21/Apr/09 11:37 PM
Last one was missing a few bits

Mike Worth added a comment - 21/Apr/09 11:39 PM
Oops again, last one had all sorts of rubbish where I had .orig files from un-doing the last patch; this one should be the working one

Anthony Borrow added a comment - 21/Apr/09 11:55 PM
Mike - I've not looked at the diff, but if you have not already could you add an option so that this is a configurable option. In other words, a site admin could determine to allow or disallow simultaneous bookings. Thanks - Anthony

Mike Worth added a comment - 22/Apr/09 03:48 PM
I don't think that is needed for this particular patch; all this patch does is allow them to display properly if they are in the database. To the standard user this patch will not make a noticeable difference.The only way they can get into the database is via other patches, I think it is on those patches that it should be able to be turned off.

Anthony Borrow added a comment - 23/Apr/09 01:13 AM
OK, it would help if I read more carefully the description. Since we are opening up a way for simultaneous bookings, should we look at making that a configurable and functional option? If you are fine with how things are that is fine with me but if you want to open things up that would be good too. Peace - Anthony

Mike Worth added a comment - 23/Apr/09 03:41 PM
This is on my tothinkabout list, I need to work out how I'm going to stucture permissions etc and how it will interact with the AJAX room list in edit_entry(coming soon)

Anthony Borrow added a comment - 09/May/09 12:42 AM
Mike - When you re-assign and issue to yourself would you mind adding me as a watcher so that I get copies of what is happening. Peace - Anthony

Mike Worth added a comment - 12/May/09 05:49 PM
Will do, prepare for a barrage of emails...

Mike Worth added a comment - 02/Jun/09 09:54 PM
This was uploaded to CVS in the same commit as CONTRIB-1189 (without this patch, CONTRIB-1189 could create invisible double bookings)