Non-core contributed modules

Add mrbs bookings to moodle logs

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: 1.9.4
  • Component/s: Block: Mrbs
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

When a booking is made or edited, an entry is made in the moodle logs

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

No objections from me to have better logging of activity, you certainly have my +1 for this patch - Peace-Anthony

Show
Anthony Borrow added a comment - No objections from me to have better logging of activity, you certainly have my +1 for this patch - Peace-Anthony
Hide
Permalink
Mike Worth added a comment -

Committed to CVS

Show
Mike Worth added a comment - Committed to CVS
Hide
Permalink
Anthony Borrow added a comment -

Mike - Thanks for the commit, I would recommend using SITEID for the course id since technically any access to the MRBS block is a site level event. I would also encourage using single quotes rather than double whenever possible (see http://docs.moodle.org/en/Development:Coding_draft#Strings. Moodle tends to encourage (although not necessarily consistently) the use of single quotes with echo statements unless the use of the double quote is justified. Peace - Anthony

Show
Anthony Borrow added a comment - Mike - Thanks for the commit, I would recommend using SITEID for the course id since technically any access to the MRBS block is a site level event. I would also encourage using single quotes rather than double whenever possible (see http://docs.moodle.org/en/Development:Coding_draft#Strings. Moodle tends to encourage (although not necessarily consistently) the use of single quotes with echo statements unless the use of the double quote is justified. Peace - Anthony
Hide
Permalink
Mike Worth added a comment -

Right you are, I have no idea why I did that (I already knew about " & ')- all fixed now

Show
Mike Worth added a comment - Right you are, I have no idea why I did that (I already knew about " & ')- all fixed now

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.