Non-core contributed modules

Add room descriptions to day.php

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: None
  • Component/s: Block: Mrbs
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

Ronseal

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

Mike - Could you attach a screenshot as to how this will look? I see no problem to it, I am just curious what it will look like.

Remember that the <br> tag needs to be <br/> for xhtml compliance (http://www.w3schools.com/TAGS/tag_br.asp).

+ . htmlspecialchars($row[0]) . ($row[1] > 0 ? "($row[1])" : "") . "
+ <br>$row[3]</a></th>";//print the room description as well

Looking at this reminds me of how ugly from a readability perspective this code is (i.e. $row[3]). At some point it would be nice to use the Moodle dmllib functions like get_record and such so that we could do something like $entry->description. Again, a project for another day (or another person or another life time).

Peace - Anthony

Show
Anthony Borrow added a comment - Mike - Could you attach a screenshot as to how this will look? I see no problem to it, I am just curious what it will look like. Remember that the <br> tag needs to be <br/> for xhtml compliance (http://www.w3schools.com/TAGS/tag_br.asp). + . htmlspecialchars($row[0]) . ($row[1] > 0 ? "($row[1])" : "") . " + <br>$row[3]</a></th>";//print the room description as well Looking at this reminds me of how ugly from a readability perspective this code is (i.e. $row[3]). At some point it would be nice to use the Moodle dmllib functions like get_record and such so that we could do something like $entry->description. Again, a project for another day (or another person or another life time). Peace - Anthony
Hide
Permalink
Mike Worth added a comment -

Here's a screenshot.

I wasn't aware of that xhtml compliance thing- now I know why 'weird' <br> tags keep showing up everywhere. I suppose I'll have to use some form of mass replace at some point as all my work will be using <br>.

Agreed on the dmlib thing, also agreed on the project for another day part.

Show
Mike Worth added a comment - Here's a screenshot. I wasn't aware of that xhtml compliance thing- now I know why 'weird' <br> tags keep showing up everywhere. I suppose I'll have to use some form of mass replace at some point as all my work will be using <br>. Agreed on the dmlib thing, also agreed on the project for another day part.
Hide
Permalink
Mike Worth added a comment -

Committed

Show
Mike Worth added a comment - Committed

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.