Issue Details (XML | Word | Printable)

Key: CONTRIB-1256
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Mike Worth
Reporter: Mike Worth
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Non-core contributed modules

Add room descriptions to day.php

Created: 08/May/09 08:57 PM   Updated: 03/Jun/09 04:49 PM
Return to search
Component/s: Block: Mrbs
Affects Version/s: 1.9.4
Fix Version/s: None

File Attachments: 1. Text File mrbsdaydescriptionpatch.txt (0.8 kB)

Image Attachments:

1. room descriptions in day.php .png
(149 kB)

Participants: Anthony Borrow and Mike Worth
Security Level: None
Resolved date: 03/Jun/09
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
Ronseal

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Anthony Borrow added a comment - 08/May/09 10:48 PM
Mike - Could you attach a screenshot as to how this will look? I see no problem to it, I am just curious what it will look like.

Remember that the <br> tag needs to be <br/> for xhtml compliance (http://www.w3schools.com/TAGS/tag_br.asp).

+ . htmlspecialchars($row[0]) . ($row[1] > 0 ? "($row[1])" : "") . "
+ <br>$row[3]</a></th>";//print the room description as well

Looking at this reminds me of how ugly from a readability perspective this code is (i.e. $row[3]). At some point it would be nice to use the Moodle dmllib functions like get_record and such so that we could do something like $entry->description. Again, a project for another day (or another person or another life time).

Peace - Anthony


Mike Worth added a comment - 12/May/09 05:43 PM
Here's a screenshot.

I wasn't aware of that xhtml compliance thing- now I know why 'weird' <br> tags keep showing up everywhere. I suppose I'll have to use some form of mass replace at some point as all my work will be using <br>.

Agreed on the dmlib thing, also agreed on the project for another day part.


Mike Worth added a comment - 03/Jun/09 04:49 PM
Committed