Issue Details (XML | Word | Printable)

Key: CONTRIB-1264
Type: Bug Bug
Status: Open Open
Priority: Critical Critical
Assignee: Anthony Borrow
Reporter: Jeffrey Silverman
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Non-core contributed modules

Wimba Liveclassroom module has bug in language files

Created: 08/May/09 10:37 PM   Updated: 27/Jul/09 10:58 AM
Return to search
Component/s: Add a project here
Affects Version/s: 1.9, 1.9.1, 1.9.2, 1.9.3, 1.9.4
Fix Version/s: None

Participants: Anthony Borrow and Jeffrey Silverman
Security Level: None
Difficulty: Moderate
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
Wimba Liveclassroom lang file for en_utf8 has some serious coding flaws. It includes non-alphanumeric chars in the $srting array indexes which result in Moodle site failure if edited.

For example:

> grep mic lang/en_utf8/liveclassroom.php
$string['Enable Student\'s microphones at presentation start'] = "Enable Student's microphones at presentation start";


Editing ANY string in that file through Moodle's local language editing capacity results in that line changing to:

$string['Enable Student's microphones at presentation start'] = "Enable Student's microphones at presentation start";

Which breaks the entire Moodle site with:

Parse error: syntax error, unexpected T_STRING, expecting ']' in /clients/hcls/lang/en_utf8_local/liveclassroom.php on line 13


NOTE: I don't know if Wimba even peeks in Moodle Tracker for this sort of thing but I figured it can't hurt.

Thanks! Seeya...

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Jeffrey Silverman added a comment - 09/May/09 12:42 AM
Actually, this can be fixed within Moodle core by changing the code that saves local lang strings to escape out single quotes. When I have a patch for that I'll post it.

Anthony Borrow added a comment - 27/Jul/09 10:58 AM
Jefferey - Sorry for the delayed response on this as I have been rather busy. In any case, I am not sure which code this goes with. I did not see anything in the Module and Plugins database for Wimba. I did see something for WizIQ live class but am not convinced that is what you are referring. Since the code is not in Moodle CVS there is not much that I can do. I am not even sure who contributed the code. If you could do some of the detective work for me and track things down I would be happy to follow up and get things fixed. Usually the lang strings escape out the single quotes so that they appear correctly. Let me know what you find out and then we can do a little tag teaming and get this resolved. Peace - Anthony