Non-core contributed modules

Upgrade dragmath to version 0.7.8.1

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9, 1.9.1, 1.9.2, 1.9.3, 1.9.4
  • Fix Version/s: None
  • Component/s: Patch: Dragmath
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

Thanks to work by Mauno K and Alex B we have a new version of dragmath that resolves some lingering logging and other issues. The new version involves some change in location of the files withint dragmath, and as long as we are addressing structural changes dragmath may as well be relocated to /lib/dragmath in anticipation of Moodle 2.

A test zip will be posted and then final versions of: a) an integrated dragmath.zip that can be simply placed in moodle root and unzipped (without shifting files); b) a zip of the the preceeding together with asciimathml in /lib/asciimath; c) a zip of just the .7.8.1 dragmath directory, as available from sourceforge; and d) a doc from alex describing the changes that went into the building of 0.7.8.1

Attachments

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Marc Grober added a comment -

Attached today (July 7 still in Alaska) is a zip of the new dragmath archive for testing for use with Moodle 1.9.x and htmlarea

Please download to your server, upload to moodle root, unzip, play, and post any issues.

After I have some confirmation that there are no issues I will post a "final" version.

There will be a MOODLE_README.html in /lib/DragMath after installation

Thanks

Show
Marc Grober added a comment - Attached today (July 7 still in Alaska) is a zip of the new dragmath archive for testing for use with Moodle 1.9.x and htmlarea Please download to your server, upload to moodle root, unzip, play, and post any issues. After I have some confirmation that there are no issues I will post a "final" version. There will be a MOODLE_README.html in /lib/DragMath after installation Thanks
Hide
Permalink
Mauno Korpelainen added a comment -

Seemed to work ok, I made some tiny changes to my local install that are included to attached lib.zip:

  • Removed lib/editor/htmlarea/popups/dragmath.php (Petr's file from moodle 2 - not a part of htmlarea integration)
  • Removed icon em.newicon.dragmath.gif from lib/editor/htmlarea/images. Left em.currenticon.dragmath.gif if some people want to use old icon.
  • Removed folder lib/DragMath/HotEqn and demo files from the same folder
  • edited lib/editor/htmlarea/popups/dlg_ins_dragmath.php to use in this file $drlang instead of $lang ... otherwise missing language file of dragmath would change current lang of main moodle to en_utf8 when you come back from dialog to main editor
  • it is simpler to use $drlang = str_replace('_utf8', '', current_language()); in htmlarea ... see the code in lib/editor/htmlarea/popups/dlg_ins_dragmath.php - tinymce plugin code written by Petr is using different method to give language for plugins
  • I used the height and width from previous version of dragmath in lib/editor/htmlarea/popups/dlg_ins_dragmath.php ( width="540" height="300" ) and lib/editor/htmlarea/dialog.js ( case "dlg_ins_dragmath": x = 540; y = 340; break; )

I made the height change originally because in my first test plugin did not get correct width and height in FF and I thought that applet was too large to fit inside dialog popup but I wonder if it was some temporary cache issue...

Show
Mauno Korpelainen added a comment - Seemed to work ok, I made some tiny changes to my local install that are included to attached lib.zip:
  • Removed lib/editor/htmlarea/popups/dragmath.php (Petr's file from moodle 2 - not a part of htmlarea integration)
  • Removed icon em.newicon.dragmath.gif from lib/editor/htmlarea/images. Left em.currenticon.dragmath.gif if some people want to use old icon.
  • Removed folder lib/DragMath/HotEqn and demo files from the same folder
  • edited lib/editor/htmlarea/popups/dlg_ins_dragmath.php to use in this file $drlang instead of $lang ... otherwise missing language file of dragmath would change current lang of main moodle to en_utf8 when you come back from dialog to main editor
  • it is simpler to use $drlang = str_replace('_utf8', '', current_language()); in htmlarea ... see the code in lib/editor/htmlarea/popups/dlg_ins_dragmath.php - tinymce plugin code written by Petr is using different method to give language for plugins
  • I used the height and width from previous version of dragmath in lib/editor/htmlarea/popups/dlg_ins_dragmath.php ( width="540" height="300" ) and lib/editor/htmlarea/dialog.js ( case "dlg_ins_dragmath": x = 540; y = 340; break; )
I made the height change originally because in my first test plugin did not get correct width and height in FF and I thought that applet was too large to fit inside dialog popup but I wonder if it was some temporary cache issue...
Hide
Permalink
Mauno Korpelainen added a comment -

Ah sorry, Marc - we need more height if we want to show tooltips...

In dlg_ins_dragmath.php applet height should be

height="333"

and in dialog.js height for dialog should be similarly 33px heigher - that means

case "dlg_ins_dragmath": x = 540; y = 373; break;

I will send you a new lang file for finnish (fi.xml) later today - and a copy to Alex and Petr - nobody has translated Dragmath to finnish before and I only need to add a couple of words and it's done too.

Show
Mauno Korpelainen added a comment - Ah sorry, Marc - we need more height if we want to show tooltips... In dlg_ins_dragmath.php applet height should be height="333" and in dialog.js height for dialog should be similarly 33px heigher - that means case "dlg_ins_dragmath": x = 540; y = 373; break; I will send you a new lang file for finnish (fi.xml) later today - and a copy to Alex and Petr - nobody has translated Dragmath to finnish before and I only need to add a couple of words and it's done too.
Hide
Permalink
Mauno Korpelainen added a comment -

OK - here attached a new file Mauno.zip that has the previous plugin heigt changes to show tooltips + new language fi.xml and I added finnish also to lib/Dragmath/applet/Config.xml ( displayName="Suomi" )

I will post the new language file next to Alex and Petr

Show
Mauno Korpelainen added a comment - OK - here attached a new file Mauno.zip that has the previous plugin heigt changes to show tooltips + new language fi.xml and I added finnish also to lib/Dragmath/applet/Config.xml ( displayName="Suomi" ) I will post the new language file next to Alex and Petr
Hide
Permalink
Marc Grober added a comment -

Mauno,

I thought I had geometry OK with what I uploaded but I may not have returned dimensions to proper values in distro after doing some experimenting.... will double check.... (I had them at 333 and 365) but I will use 333 and 373 in final if we need the extra 8 pixels.

I have always liked keeping demos in distribution, in part because it means local demonstrations need not target the STACK site..... Is there any reason other than bytage that you suggest dropping demos and HotEqn?

Yes, dragmath.php was included just for reference and I anticipated deleting in final version... just thought it would be handy to have it there for comparison. I thought about editing htmlarea.php to reference dragmath.php instead of dlg_ins_dragmath.php but figured it was best to keep the two separate.

Not sure who did what on language stuff, or anything else in HEAD for that matter ;=}
I thought you wrote the lang code in dragmath.php in the tinyMCE popup in HEAD - in any event, I included that code and the applet ref specifically so you could resolve whatever issues it might have so am glad that it is done and working.

Do you think I should package all language files in the zip, or expect users to download and add? I think it certainly makes sense to add all language files (especially in as much as I want to keep demos and HotEqn - lol)

At this point then I am waiting for Alex to send me new version with everything signed and with JEP reference resolved. Will then repackage and republish as final rc.

Show
Marc Grober added a comment - Mauno, I thought I had geometry OK with what I uploaded but I may not have returned dimensions to proper values in distro after doing some experimenting.... will double check.... (I had them at 333 and 365) but I will use 333 and 373 in final if we need the extra 8 pixels. I have always liked keeping demos in distribution, in part because it means local demonstrations need not target the STACK site..... Is there any reason other than bytage that you suggest dropping demos and HotEqn? Yes, dragmath.php was included just for reference and I anticipated deleting in final version... just thought it would be handy to have it there for comparison. I thought about editing htmlarea.php to reference dragmath.php instead of dlg_ins_dragmath.php but figured it was best to keep the two separate. Not sure who did what on language stuff, or anything else in HEAD for that matter ;=} I thought you wrote the lang code in dragmath.php in the tinyMCE popup in HEAD - in any event, I included that code and the applet ref specifically so you could resolve whatever issues it might have so am glad that it is done and working. Do you think I should package all language files in the zip, or expect users to download and add? I think it certainly makes sense to add all language files (especially in as much as I want to keep demos and HotEqn - lol) At this point then I am waiting for Alex to send me new version with everything signed and with JEP reference resolved. Will then repackage and republish as final rc.
Hide
Permalink
Marc Grober added a comment -

This is release candidate 2 with recent fixes from Alex and finnish language files from Mauno -

Show
Marc Grober added a comment - This is release candidate 2 with recent fixes from Alex and finnish language files from Mauno -
Hide
Permalink
Marc Grober added a comment -

Dragmath Integration for 0.7.8.1 is "released" in this file. See documentation for installation and usage.

Show
Marc Grober added a comment - Dragmath Integration for 0.7.8.1 is "released" in this file. See documentation for installation and usage.
Hide
Permalink
Marc Grober added a comment -

Mauno discovered a bug in the code to manage languages. the file dragmathintegration_v0.7.8.1_final.zip addresses this

Show
Marc Grober added a comment - Mauno discovered a bug in the code to manage languages. the file dragmathintegration_v0.7.8.1_final.zip addresses this

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.