Non-core contributed modules

email notification includes html break tag in text/plain version

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.2
  • Fix Version/s: 1.9.4, 2.0
  • Component/s: Module: Questionnaire
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

The email notification uses the same html-based body content for both text/plain as well as text/html. This results in break tags appearing before each line in the plain text version.

I will attach a possible patch tomorrow.

Attachments

  1. File
    CONTRIB-1465.diff
    05/Aug/09 11:45 PM
    3 kB
    Brian Jorgensen
  2. File
    CONTRIB-1465.v2.diff
    05/Aug/09 11:58 PM
    3 kB
    Brian Jorgensen
  3. File
    CONTRIB-1465.v3.diff
    06/Aug/09 12:19 AM
    3 kB
    Brian Jorgensen

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brian Jorgensen added a comment -

Here is a possible patch. I have created two separate email bodies: one for html emails, one for plain text emails.

Show
Brian Jorgensen added a comment - Here is a possible patch. I have created two separate email bodies: one for html emails, one for plain text emails.
Hide
Permalink
Brian Jorgensen added a comment -

Sorry, Mike, here's a patch with the missing carriage return.

Show
Brian Jorgensen added a comment - Sorry, Mike, here's a patch with the missing carriage return.
Hide
Permalink
Brian Jorgensen added a comment -

Fix escape sequence interpretation inside quotes; fix link to view response within moodle.

Sorry, Mike, I should have tested properly before attaching.

Show
Brian Jorgensen added a comment - Fix escape sequence interpretation inside quotes; fix link to view response within moodle. Sorry, Mike, I should have tested properly before attaching.
Hide
Permalink
Mike Churchward added a comment -

Thanks Brian. Applied and committed.

Show
Mike Churchward added a comment - Thanks Brian. Applied and committed.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.