Issue Details (XML | Word | Printable)

Key: CONTRIB-1484
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Mike Churchward
Reporter: Mike Churchward
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Non-core contributed modules

New print_header and $PAGE API breaking questionnaire in 2.0

Created: 18/Aug/09 10:44 PM   Updated: 19/Aug/09 12:29 AM
Return to search
Component/s: Module: Questionnaire
Affects Version/s: 2.0
Fix Version/s: 2.0

Issue Links:
Relates
 

Participants: Joseph Rézeau and Mike Churchward
Security Level: None
Resolved date: 18/Aug/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Changes to the print_header API and use of $PAGE are breaking the questionnaire module. Viewing a questionnaire gives the error:

This page did no call $PAGE->set_url(...). Relaying on a guess.

    * line 338 of /lib/pagelib.php: call to debugging()
    * line 450 of /lib/pagelib.php: call to moodle_page->get_url()
    * line 1364 of /lib/blocklib.php: call to moodle_page->__get()
    * line 857 of /lib/blocklib.php: call to block_add_block_ui()
    * line 312 of /lib/blocklib.php: call to block_manager->ensure_content_created()
    * line 833 of /lib/outputrenderers.php: call to block_manager->region_has_content()
    * line 707 of /lib/outputrenderers.php: call to moodle_core_renderer->handle_legacy_theme()
    * line 1879 of /lib/outputrenderers.php: call to moodle_core_renderer->header()
    * line 185 of /lib/setuplib.php: call to moodle_core_renderer->fatal_error()
    * line ? of unknownfile: call to default_exception_handler()

...and...

Coding error detected, it must be fixed by a programmer: The $meta parameter to print_header is no longer supported. You should be able to do everything you want with $PAGE->requires and other such mechanisms.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Mike Churchward added a comment - 18/Aug/09 11:35 PM
Updated the two occurrences of print_header that were using the $meta argument to use the new $PAGE structure.

Joseph Rézeau added a comment - 19/Aug/09 12:29 AM
Thanks Mike!
Joseph