Non-core contributed modules

Please create a tag or branch for pre-1.9.5 code of preg question type

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: 1.9.5
  • Component/s: Question type: Preg
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

I have a major update of preg question type that will be working in the Moodle starting from 1.9.5 (actually sooner, but not quite right from 1.9.4). I want commit it to CVS but have an easy way to address old version too in case someone really didn't want to upgrade to 1.9.5

Activity

Hide
Anthony Borrow added a comment -

Oleg - As we chatted about, there are a few options. We could use the 19STABLE branch for the early 1.9 code and HEAD for the later 1.9.5+ code. Personally, from the sounds of it, I think the best thing to do is to take the existing 1.9 (pre 1.9.5) code and zip it up and throw it on the Moodle.org forums. In general, I am in favor of saying that especially with 3rd party code the latest version of Moodle is being supported. So if folks want to use it, then they should be using 1.9.5+. I realize that some of the changes to the gradebook may have left some opting to not upgrade; however, if they want to use your code then that is what they have to do. I do not think it is reasonable to expect someone to maintain multiple versions because someone opts not to upgrade. Major version releases makes sense (1.8, 1.9, 2.0, etc.) but not mini-releases. It sounded like you would like to tag the current version as pre-195 so that you can continue your development. As I understand it, the advantage to using the tag would be that you could checkout that tagged version and then create a zip file. This would make sense if you were actively maintaining both versions but it sounds like you just want to continue maintaining for 1.9.5 and beyond. I am going to ask Eloy what he thinks the best way to proceed is but wanted to document some of what we had discussed. Please feel free to correct, add to, or otherwise comment as you feel appropriate. Peace - Anthony

Show
Anthony Borrow added a comment - Oleg - As we chatted about, there are a few options. We could use the 19STABLE branch for the early 1.9 code and HEAD for the later 1.9.5+ code. Personally, from the sounds of it, I think the best thing to do is to take the existing 1.9 (pre 1.9.5) code and zip it up and throw it on the Moodle.org forums. In general, I am in favor of saying that especially with 3rd party code the latest version of Moodle is being supported. So if folks want to use it, then they should be using 1.9.5+. I realize that some of the changes to the gradebook may have left some opting to not upgrade; however, if they want to use your code then that is what they have to do. I do not think it is reasonable to expect someone to maintain multiple versions because someone opts not to upgrade. Major version releases makes sense (1.8, 1.9, 2.0, etc.) but not mini-releases. It sounded like you would like to tag the current version as pre-195 so that you can continue your development. As I understand it, the advantage to using the tag would be that you could checkout that tagged version and then create a zip file. This would make sense if you were actively maintaining both versions but it sounds like you just want to continue maintaining for 1.9.5 and beyond. I am going to ask Eloy what he thinks the best way to proceed is but wanted to document some of what we had discussed. Please feel free to correct, add to, or otherwise comment as you feel appropriate. Peace - Anthony
Hide
Anthony Borrow added a comment -

Eloy - I have added you as a watcher hoping you might comment on this just to make sure I am not overlooking something. AFAIK, a special zip file is not created for tags so there would be no real advantage to using a CVS tag in this case and I am not in favor of adding a branch. My advise is to simply create a zip of the pre-195 code and make it available somewhere and then continue development. If you any ideas, thoughts, comments, suggestions, etc. they would be most welcome. Peace - Anthony

Show
Anthony Borrow added a comment - Eloy - I have added you as a watcher hoping you might comment on this just to make sure I am not overlooking something. AFAIK, a special zip file is not created for tags so there would be no real advantage to using a CVS tag in this case and I am not in favor of adding a branch. My advise is to simply create a zip of the pre-195 code and make it available somewhere and then continue development. If you any ideas, thoughts, comments, suggestions, etc. they would be most welcome. Peace - Anthony
Hide
Eloy Lafuente (stronk7) added a comment -

Uhm, I think Anthony is correct. I would:

1) Put current http://download.moodle.org/download.php/plugins19/question/type/regexp.zip somewhere else (forums, another server)
2) Use the MOODLE_19_STABLE branch to continue developing the (>= 1.9.5) regexp qtype.
3) Use HEAD for the HEAD
4) Annotate in the M&P database that the regexp qtype is only working for >= 1.9.5 with one link to 1)

But I wouldn't try to create any sort of "multiple versions in the same branch" nor tag it at all. All the infrastructure simply doesn't support it. So +1 to store the "old" (current) one somewhere and continue with >= 1.9.5 in place.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Uhm, I think Anthony is correct. I would: 1) Put current http://download.moodle.org/download.php/plugins19/question/type/regexp.zip somewhere else (forums, another server) 2) Use the MOODLE_19_STABLE branch to continue developing the (>= 1.9.5) regexp qtype. 3) Use HEAD for the HEAD 4) Annotate in the M&P database that the regexp qtype is only working for >= 1.9.5 with one link to 1) But I wouldn't try to create any sort of "multiple versions in the same branch" nor tag it at all. All the infrastructure simply doesn't support it. So +1 to store the "old" (current) one somewhere and continue with >= 1.9.5 in place. Ciao
Hide
Anthony Borrow added a comment -

Thanks Eloy for confirming my intuition of what would work best. I have created a 19STABLE branch so that Oleg can continue to develop the 1.9 version and also be able to work on 2.0 as needed. I will let Oleg take care of posting the pre-1.9.5 zip file in Moodle.org forums and then update Modules and Plugins database entry to reflect what we have discussed here. Oleg I have assigned you for QA, feel free to close this issue once you get things tidied up in Modules and Plugins. Do not hesitate to let me know if you have any questions. Peace - Anthony

Show
Anthony Borrow added a comment - Thanks Eloy for confirming my intuition of what would work best. I have created a 19STABLE branch so that Oleg can continue to develop the 1.9 version and also be able to work on 2.0 as needed. I will let Oleg take care of posting the pre-1.9.5 zip file in Moodle.org forums and then update Modules and Plugins database entry to reflect what we have discussed here. Oleg I have assigned you for QA, feel free to close this issue once you get things tidied up in Modules and Plugins. Do not hesitate to let me know if you have any questions. Peace - Anthony
Hide
Oleg Sychev added a comment -

Hmmm, Anthony .... I hoped to commit 1.9.5+ version of preg before branching for 2.0 ... Is it stilll possible or now I should do 2 commits?

Show
Oleg Sychev added a comment - Hmmm, Anthony .... I hoped to commit 1.9.5+ version of preg before branching for 2.0 ... Is it stilll possible or now I should do 2 commits?
Hide
Anthony Borrow added a comment -

Oleg - Sorry for branching too quickly. I am trying to get through as many tracker items as I can. Two commits will be fine but let me know if you want me to do anything or need any help. Peace - Anthony

Show
Anthony Borrow added a comment - Oleg - Sorry for branching too quickly. I am trying to get through as many tracker items as I can. Two commits will be fine but let me know if you want me to do anything or need any help. Peace - Anthony
Hide
Anthony Borrow added a comment -

Closing all of my resolved issues. Peace - Anthony

Show
Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: