|
|
|
In Edit Questionnaire mode, the following sequence results in faulty navigation:
---
Go to Re-order question screen
Click Preview... button
Close or do not close the popup Preview window (does not matter).
Come back to the Questionnaire Edit window.
Click either on the Add Section Break, the Edit (one question), the Remove (one question) buttons
-> instead of the desired action, the program takes you to Edit Questions screen !!!
---
Diagnostic.- The preview action changes some of the form parameters and does not reset them correctly
---
Proposed solution.-
In file /questionnaire/manage_survey.php about line 175, add the following test
/// 'q' comes from the question editor as a submit, and can be from the reorder form.
} else if (isset($formdata->q)) {
+ if ($formdata->dst == -1 || is_numeric($formdata->q) || $formdata->src || $formdata->addbreak ) {
+ $formdata->tab = 'order';
+ $formdata->sid = $formdata->instance + 1;
+ }
if ($formdata->tab == 'order' && empty($formdata->q)) {
Please test and commit to CVS if proved reliable.
Thanks
Joseph
|
|
Description
|
In Edit Questionnaire mode, the following sequence results in faulty navigation:
---
Go to Re-order question screen
Click Preview... button
Close or do not close the popup Preview window (does not matter).
Come back to the Questionnaire Edit window.
Click either on the Add Section Break, the Edit (one question), the Remove (one question) buttons
-> instead of the desired action, the program takes you to Edit Questions screen !!!
---
Diagnostic.- The preview action changes some of the form parameters and does not reset them correctly
---
Proposed solution.-
In file /questionnaire/manage_survey.php about line 175, add the following test
/// 'q' comes from the question editor as a submit, and can be from the reorder form.
} else if (isset($formdata->q)) {
+ if ($formdata->dst == -1 || is_numeric($formdata->q) || $formdata->src || $formdata->addbreak ) {
+ $formdata->tab = 'order';
+ $formdata->sid = $formdata->instance + 1;
+ }
if ($formdata->tab == 'order' && empty($formdata->q)) {
Please test and commit to CVS if proved reliable.
Thanks
Joseph |
Show » |
made changes - 12/Jun/07 05:31 AM
| Field |
Original Value |
New Value |
|
Fix Version/s
|
|
1.6.6
[ 10211
]
|
|
Resolution
|
|
Fixed
[ 1
]
|
|
Fix Version/s
|
|
1.7.3
[ 10212
]
|
|
Fix Version/s
|
|
1.8.2
[ 10220
]
|
|
Status
|
Open
[ 1
]
|
Closed
[ 6
]
|
made changes - 06/Nov/07 02:00 PM
|
Fix Version/s
|
1.7.3
[ 10212
]
|
|
|
Fix Version/s
|
1.6.6
[ 10211
]
|
|
|
Fix Version/s
|
1.8.2
[ 10220
]
|
|
|
Key
|
MDL-9270
|
CONTRIB-157
|
|
Affects Version/s
|
1.6
[ 10110
]
|
|
|
Affects Version/s
|
|
1.8.2
[ 10221
]
|
|
Project
|
Moodle
[ 10011
]
|
Non-core contributed modules
[ 10033
]
|
|
Affects Version/s
|
1.7
[ 10120
]
|
|
made changes - 06/Nov/07 02:02 PM
|
Component/s
|
Questionnaire
[ 10086
]
|
|
|