Non-core contributed modules

Time not substituted in scheduler emails, cont'd

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.5
  • Fix Version/s: 1.9.7, 2.0
  • Component/s: Module: Scheduler
  • Labels:
    None
  • Environment:
    Ubuntu Server 8.04 LTS
  • Database:
    Any
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

The bug CONTRIB-937 (Time not subsitituted in scheduler emails) has reoccurred in the latest version of the MOODLE_19_STABLE branch, since the following commit reverted the bugfix:

http://cvs.moodle.org/contrib/plugins/mod/scheduler/studentview.controller.php?r1=1.3.2.5&r2=1.3.2.6

Also, to fix the bug completely , the change described in CONTRIB-937 needs to be made in several places - three times in studentview.controller.php and once in locallib.php.

I attach a diff that shows the details.

  1. CONTRIB-1601-time-substitution.diff
    07/Nov/09 12:37 AM
    5 kB
    Henning Bostelmann
  2. time-substitution.diff
    05/Nov/09 3:04 AM
    4 kB
    Henning Bostelmann

Issue Links

Activity

Hide
Henning Bostelmann added a comment -

A very similar issue occurs in teacherview.controller.php. I will attach a combined diff.

Show
Henning Bostelmann added a comment - A very similar issue occurs in teacherview.controller.php. I will attach a combined diff.
Hide
Henning Bostelmann added a comment -

Patch for teacherview.controller.php, studentview.controller.php, and locallib.php

Show
Henning Bostelmann added a comment - Patch for teacherview.controller.php, studentview.controller.php, and locallib.php

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: