Non-core contributed modules

MRBS: Cleanup php files with sloppy HTML

Details

  • Type: Task Task
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 2.0
  • Fix Version/s: None
  • Component/s: Block: Mrbs
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_20_STABLE

Description

I noticed Eclipse was showing PHP errors in /blocks/mrbs/web/report.php and /blocks/mrbs/web/session_php.php. As PHP files I would like for these to use echo to generate the HTML so I want to clean them up. Peace - Anthony

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

Mike - I have begun to attempt to clean some things up in the MRBS block. I am going piecemeal so that we can easily revert any regressions I am making. At this point, I am mostly trying to clean up spacing and code readability issues to make things consistent with typical Moodle code. I am a bit of a purist in terms of file types. I do not like PHP files to contain HTML code so I am replacing some of those with echo statements. I have added you as a watcher so that you can monitor my progress. Next I want to go back through and change much of the database manipulation to use Moodle's dmllib.php functions (get_records, insert_record, update_record, etc.). Peace - Anthony

Show
Anthony Borrow added a comment - Mike - I have begun to attempt to clean some things up in the MRBS block. I am going piecemeal so that we can easily revert any regressions I am making. At this point, I am mostly trying to clean up spacing and code readability issues to make things consistent with typical Moodle code. I am a bit of a purist in terms of file types. I do not like PHP files to contain HTML code so I am replacing some of those with echo statements. I have added you as a watcher so that you can monitor my progress. Next I want to go back through and change much of the database manipulation to use Moodle's dmllib.php functions (get_records, insert_record, update_record, etc.). Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

changing affect and fix version as I will only change the code in HEAD. I will leave the 1.9 stable version alone. Peace - Anthony

Show
Anthony Borrow added a comment - changing affect and fix version as I will only change the code in HEAD. I will leave the 1.9 stable version alone. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

this is the least of our worries with this block closing as I don't really have much time to work on this. Peace - Anthony

Show
Anthony Borrow added a comment - this is the least of our worries with this block closing as I don't really have much time to work on this. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Here is what the local/codecheckers evaluation thinks about this the code (basically it is a mess because it is not Moodle code). We should write something that is specifically written for Moodle within Moodle using the Moodle APIs. Peace - Anthony

Show
Anthony Borrow added a comment - Here is what the local/codecheckers evaluation thinks about this the code (basically it is a mess because it is not Moodle code). We should write something that is specifically written for Moodle within Moodle using the Moodle APIs. Peace - Anthony

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.