Non-core contributed modules

Forum post approval causing odd behavior to forums after update to latest Moodle stable release

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.9.7
  • Fix Version/s: None
  • Component/s: Patch: Forum post approval
  • Labels:
    None
  • Environment:
    Moodle 1.9.7+ build 20091223
  • Difficulty:
    Moderate
  • Affected Branches:
    MOODLE_19_STABLE

Description

After Moodle update to 1.9.7+ build 20091223, there now seems to be an issue with the moderated forums. Even for forums that have Require Approval set to No, the state for all previous postings seemed to default to unapproved and anyone in a student role can no longer see those postings. New postings however seem to be visible to students. One of our system developers has identified some coding that may have been affected by the update.

Issue Links

This issue has been marked as being related by:
CONTRIB-1085 Forums: Add field for Teacher to approve post Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Erin Mayabb added a comment -

If it helps, I have attached the output files generated by the system for the pieces of the patch that failed for us. I deleted the files for mod/forum/rate_ajax.js and although it failed to patch too, it failed because the fixes for that file were made already in the Moodle build that I installed.

Show
Erin Mayabb added a comment - If it helps, I have attached the output files generated by the system for the pieces of the patch that failed for us. I deleted the files for mod/forum/rate_ajax.js and although it failed to patch too, it failed because the fixes for that file were made already in the Moodle build that I installed.
Hide
Permalink
Anthony Borrow added a comment -

Bob - Could you try updating to the latest 1.9 STABLE version. I am not sure if you are using CVS to update your server (well hopefully your test server first) or if you are just grabbing the latest zip file for download.moodle.org. Regardless, try using the attached patch file and do a little testing. If it proves to be OK, then I will update the file in CVS with the patch attached here. I do not have user data on my current test installation so I cannot really test it without creating some so if you can test it and it works then I will update it. Thanks for your help. It looks like it was pretty minor stuff that was preventing it from working (things moving around a bit). I did not notice off the top of my head any conflicts but would need to look a bit closer to make sure. Mostly at the differences in /mod/forum/lib.php between versions 1.609.2.93 and the current one 1.609.2.100. Let me know how it goes. Peace - Anthony

Show
Anthony Borrow added a comment - Bob - Could you try updating to the latest 1.9 STABLE version. I am not sure if you are using CVS to update your server (well hopefully your test server first) or if you are just grabbing the latest zip file for download.moodle.org. Regardless, try using the attached patch file and do a little testing. If it proves to be OK, then I will update the file in CVS with the patch attached here. I do not have user data on my current test installation so I cannot really test it without creating some so if you can test it and it works then I will update it. Thanks for your help. It looks like it was pretty minor stuff that was preventing it from working (things moving around a bit). I did not notice off the top of my head any conflicts but would need to look a bit closer to make sure. Mostly at the differences in /mod/forum/lib.php between versions 1.609.2.93 and the current one 1.609.2.100. Let me know how it goes. Peace - Anthony

People

Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.