|
[
Permalink
| « Hide
]
Anthony Borrow added a comment - 19/Nov/07 06:09 AM
Thanks for creating this Larry. I hope to get some time over one of the holiday breaks to play with this. Peace - Anthony
Larry - I'm getting a chance to play with MRBS code now. I'll be working on
Thanks for the update Anthony. I see you are making progress on other MRBS issues in HEAD. Look forward to all of your improvements and the backporting to 1.9.x
larry Larry - I just said I was making changes, no one said anything about improvements or backporting
 Actually I'm working on the HEAD branch but testing primarily against 1.9. Peace - Anthony Surely your changes are improvements .... or else why do them ... lol!
The fact that you are testing against 1.9 is good news in any event L Larry - Here is a first stab at improving things. I believe this prevents the framing issue you were referring to. Take a look at the screenshot and let me know what you think. Peace - Anthony
As for linking from other courses - I think a simple resource with the URL to http://mysite.com/blocks/mrbs/web/index.php
 should work. We may have to work on passing the course string. I'll test this now. Peace - Anthony OK - we have a functional version IMO, let me know how it can be improved. Peace - Anthony
Will do in the am, Anthony
I'm GMT-4 larry Did not get too far Anthony
When I click the admin link, I get "Table 'm19sql.mdl_mrbs_area' doesn't exist" so it appears not to install the mdl_mrbs_area table when i hit notifications after repacing the old mrbs. larry Should have attached this to my last comment
L Larry - I had not considered upgrading that would be worthy of a tracker issue to help folks migrate from the old to the new. There currently is no upgrade script. I've been assuming a fresh installation which means you would have to go to Site Administration, Modules -> Blocks -> Manage Blocks and delete the Resource Scheduling block. Then click on notifications and it should trigger the install.xml and create the tables. for you. Peace - Anthony
Worked after I did a clean install Anthony
2 issues noticed so far. I did not test adding any dates yet larry Larry - Thanks for the help with testing. Both 1 and 2 sounds easy enough to fix. Could you let me know on what page (URL) you are seeing each of those errors as it will help me to track them down. Peace - Anthony
p.s. Screen shots are always helpful to me as I am very visual. Once I see it, I get it. Larry - OK, I have fixed the space after the name in the admin.php file and committed that to CVS. I also noticed the missing colon after description below that. I was unable to reproduce #2. The current date seems to be fine but I'll need the URL to ensure we are looking at the same page. Peace - Anthony
http://ccvs.ednet.ns.ca/m19/blocks/mrbs/web/day.php?day=07&month=08&year=2008
It is in the goto line Anthony thanks larry OK - I see it but I cannot reproduce it. It is strange because the logic is pretty straight forward. I'm looking at line 342 of the /blocks/mrbs/web/functions.php file which reads:
<OPTION VALUE=\"$i\"" . ($i == $month ? " SELECTED" : "") . ">$m"; which is essentially looping through the twelve months of the year where $i is the loop integer. <OPTION VALUE="1" >Jan the $m is the month name format and uses the first day of the month at midnight. It could be that there is some type of offset that you are not using the server's time - so a difference between the user's time and the server's time might be causing it to display off by a month. I'll play with it and see if I can reproduce it. Peace - Anthony Larry - I confirmed that it was an issue with the system time zone. I think I have applied a fix that should neutralize the problem. Let me know how it goes. Peace - Anthony
You resolved this date display issue, Anthony
I'll look at adding/testing entries in a bit. thanks |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
New Feature
Resolved
Minor
Embed MRBS window within Moodle and eliminate possibility of a cascading of the header and breadcrumbs
 |
|
