Non-core contributed modules

Embed MRBS window within Moodle and eliminate possibility of a cascading of the header and breadcrumbs

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8.2, 1.9
  • Fix Version/s: None
  • Component/s: Block: Mrbs
  • Labels:
    None
  • Environment:
    All
  • Database:
    Any
  • Affected Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

Currently the MRBS integration is in the form of a block and is designed to run from the main site page. When the link to the MRBS is clicked, a new window opens, temporarily leaving the moodle installation in the background.

A desirable new feature would be to allow the MRBS to remain in the main Moodle window, with the header and site navigation (breadcrumbs) still visible.

This would require rewriting the code to allow for this to happen and to fix the link back to server to avoid having the entire site open within the framed area below the existing breadcrumb trail. Another option would be to remove it altogether, as this link would no longer be required, since the MRBS is within the Moodle browser page.

The ability to hide the block and link to it via Link to Resource pages, could allow staff and students that need to book common resources, do so within the courses for which this feature is desireable.

Attachments

  1. File
    CONTRIB-180.diff
    07/Aug/08 8:41 AM
    15 kB
    Anthony Borrow
  1. CONTRIB-180.png
    142 kB
    07/Aug/08 8:41 AM
  2. Picture 16.png
    35 kB
    07/Aug/08 7:40 PM
  3. Picture 17.png
    152 kB
    08/Aug/08 7:04 AM

Issue Links

This issue will help resolve:
CONTRIB-230 MRBS: Update MRBS block from MRBS 1.2.3 to 1.2.5 Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

Thanks for creating this Larry. I hope to get some time over one of the holiday breaks to play with this. Peace - Anthony

Show
Anthony Borrow added a comment - Thanks for creating this Larry. I hope to get some time over one of the holiday breaks to play with this. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Larry - I'm getting a chance to play with MRBS code now. I'll be working on CONTRIB-422 and CONTRIB-230 before coming back and polishing off with this issue. Peace - Anthony

Show
Anthony Borrow added a comment - Larry - I'm getting a chance to play with MRBS code now. I'll be working on CONTRIB-422 and CONTRIB-230 before coming back and polishing off with this issue. Peace - Anthony
Hide
Permalink
Larry M Elchuck, Ph.D. added a comment -

Thanks for the update Anthony. I see you are making progress on other MRBS issues in HEAD. Look forward to all of your improvements and the backporting to 1.9.x

larry

Show
Larry M Elchuck, Ph.D. added a comment - Thanks for the update Anthony. I see you are making progress on other MRBS issues in HEAD. Look forward to all of your improvements and the backporting to 1.9.x larry
Hide
Permalink
Anthony Borrow added a comment -

Larry - I just said I was making changes, no one said anything about improvements or backporting Actually I'm working on the HEAD branch but testing primarily against 1.9. Peace - Anthony

Show
Anthony Borrow added a comment - Larry - I just said I was making changes, no one said anything about improvements or backporting Actually I'm working on the HEAD branch but testing primarily against 1.9. Peace - Anthony
Hide
Permalink
Larry M Elchuck, Ph.D. added a comment -

Surely your changes are improvements .... or else why do them ... lol!

The fact that you are testing against 1.9 is good news in any event

L

Show
Larry M Elchuck, Ph.D. added a comment - Surely your changes are improvements .... or else why do them ... lol! The fact that you are testing against 1.9 is good news in any event L
Hide
Permalink
Anthony Borrow added a comment -

CONTRIB-180 is a subtask of CONTRIB-230

Show
Anthony Borrow added a comment - CONTRIB-180 is a subtask of CONTRIB-230
Hide
Permalink
Anthony Borrow added a comment -

Larry - Here is a first stab at improving things. I believe this prevents the framing issue you were referring to. Take a look at the screenshot and let me know what you think. Peace - Anthony

Show
Anthony Borrow added a comment - Larry - Here is a first stab at improving things. I believe this prevents the framing issue you were referring to. Take a look at the screenshot and let me know what you think. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

As for linking from other courses - I think a simple resource with the URL to http://mysite.com/blocks/mrbs/web/index.php should work. We may have to work on passing the course string. I'll test this now. Peace - Anthony

Show
Anthony Borrow added a comment - As for linking from other courses - I think a simple resource with the URL to http://mysite.com/blocks/mrbs/web/index.php should work. We may have to work on passing the course string. I'll test this now. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

OK - we have a functional version IMO, let me know how it can be improved. Peace - Anthony

Show
Anthony Borrow added a comment - OK - we have a functional version IMO, let me know how it can be improved. Peace - Anthony
Hide
Permalink
Larry M Elchuck, Ph.D. added a comment -

Will do in the am, Anthony

I'm GMT-4

larry

Show
Larry M Elchuck, Ph.D. added a comment - Will do in the am, Anthony I'm GMT-4 larry
Hide
Permalink
Larry M Elchuck, Ph.D. added a comment -

Did not get too far Anthony

When I click the admin link, I get "Table 'm19sql.mdl_mrbs_area' doesn't exist" so it appears not to install the mdl_mrbs_area table when i hit notifications after repacing the old mrbs.

larry

Show
Larry M Elchuck, Ph.D. added a comment - Did not get too far Anthony When I click the admin link, I get "Table 'm19sql.mdl_mrbs_area' doesn't exist" so it appears not to install the mdl_mrbs_area table when i hit notifications after repacing the old mrbs. larry
Hide
Permalink
Larry M Elchuck, Ph.D. added a comment -

Should have attached this to my last comment

L

Show
Larry M Elchuck, Ph.D. added a comment - Should have attached this to my last comment L
Hide
Permalink
Anthony Borrow added a comment -

Larry - I had not considered upgrading that would be worthy of a tracker issue to help folks migrate from the old to the new. There currently is no upgrade script. I've been assuming a fresh installation which means you would have to go to Site Administration, Modules -> Blocks -> Manage Blocks and delete the Resource Scheduling block. Then click on notifications and it should trigger the install.xml and create the tables. for you. Peace - Anthony

Show
Anthony Borrow added a comment - Larry - I had not considered upgrading that would be worthy of a tracker issue to help folks migrate from the old to the new. There currently is no upgrade script. I've been assuming a fresh installation which means you would have to go to Site Administration, Modules -> Blocks -> Manage Blocks and delete the Resource Scheduling block. Then click on notifications and it should trigger the install.xml and create the tables. for you. Peace - Anthony
Hide
Permalink
Larry M Elchuck, Ph.D. added a comment -

Worked after I did a clean install Anthony

2 issues noticed so far.
1. Unless I put a blank space after the name of the room, the "(" for the description appears next to it with no space.
2. The default date is a month earlier the current date. (eg. July 7 when today is Aug 7)

I did not test adding any dates yet

larry

Show
Larry M Elchuck, Ph.D. added a comment - Worked after I did a clean install Anthony 2 issues noticed so far. 1. Unless I put a blank space after the name of the room, the "(" for the description appears next to it with no space. 2. The default date is a month earlier the current date. (eg. July 7 when today is Aug 7) I did not test adding any dates yet larry
Hide
Permalink
Anthony Borrow added a comment - - edited

Larry - Thanks for the help with testing. Both 1 and 2 sounds easy enough to fix. Could you let me know on what page (URL) you are seeing each of those errors as it will help me to track them down. Peace - Anthony

p.s. Screen shots are always helpful to me as I am very visual. Once I see it, I get it.

Show
Anthony Borrow added a comment - - edited Larry - Thanks for the help with testing. Both 1 and 2 sounds easy enough to fix. Could you let me know on what page (URL) you are seeing each of those errors as it will help me to track them down. Peace - Anthony p.s. Screen shots are always helpful to me as I am very visual. Once I see it, I get it.
Hide
Permalink
Anthony Borrow added a comment -

Larry - OK, I have fixed the space after the name in the admin.php file and committed that to CVS. I also noticed the missing colon after description below that. I was unable to reproduce #2. The current date seems to be fine but I'll need the URL to ensure we are looking at the same page. Peace - Anthony

Show
Anthony Borrow added a comment - Larry - OK, I have fixed the space after the name in the admin.php file and committed that to CVS. I also noticed the missing colon after description below that. I was unable to reproduce #2. The current date seems to be fine but I'll need the URL to ensure we are looking at the same page. Peace - Anthony
Hide
Permalink
Larry M Elchuck, Ph.D. added a comment -

http://ccvs.ednet.ns.ca/m19/blocks/mrbs/web/day.php?day=07&month=08&year=2008

It is in the goto line Anthony

thanks

larry

Show
Larry M Elchuck, Ph.D. added a comment - http://ccvs.ednet.ns.ca/m19/blocks/mrbs/web/day.php?day=07&month=08&year=2008 It is in the goto line Anthony thanks larry
Hide
Permalink
Anthony Borrow added a comment -

OK - I see it but I cannot reproduce it. It is strange because the logic is pretty straight forward. I'm looking at line 342 of the /blocks/mrbs/web/functions.php file which reads:

<OPTION VALUE=\"$i\"" . ($i == $month ? " SELECTED" : "") . ">$m";

which is essentially looping through the twelve months of the year where $i is the loop integer.

<OPTION VALUE="1" >Jan
<OPTION VALUE="2" >Feb
<OPTION VALUE="3" >Mar
<OPTION VALUE="4" >Apr
<OPTION VALUE="5" >May
<OPTION VALUE="6" >Jun
<OPTION VALUE="7" >Jul
<OPTION VALUE="8" SELECTED>Aug

the $m is the month name format and uses the first day of the month at midnight. It could be that there is some type of offset that you are not using the server's time - so a difference between the user's time and the server's time might be causing it to display off by a month. I'll play with it and see if I can reproduce it.

Peace - Anthony

Show
Anthony Borrow added a comment - OK - I see it but I cannot reproduce it. It is strange because the logic is pretty straight forward. I'm looking at line 342 of the /blocks/mrbs/web/functions.php file which reads: <OPTION VALUE=\"$i\"" . ($i == $month ? " SELECTED" : "") . ">$m"; which is essentially looping through the twelve months of the year where $i is the loop integer. <OPTION VALUE="1" >Jan <OPTION VALUE="2" >Feb <OPTION VALUE="3" >Mar <OPTION VALUE="4" >Apr <OPTION VALUE="5" >May <OPTION VALUE="6" >Jun <OPTION VALUE="7" >Jul <OPTION VALUE="8" SELECTED>Aug the $m is the month name format and uses the first day of the month at midnight. It could be that there is some type of offset that you are not using the server's time - so a difference between the user's time and the server's time might be causing it to display off by a month. I'll play with it and see if I can reproduce it. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Larry - I confirmed that it was an issue with the system time zone. I think I have applied a fix that should neutralize the problem. Let me know how it goes. Peace - Anthony

Show
Anthony Borrow added a comment - Larry - I confirmed that it was an issue with the system time zone. I think I have applied a fix that should neutralize the problem. Let me know how it goes. Peace - Anthony
Hide
Permalink
Larry M Elchuck, Ph.D. added a comment -

You resolved this date display issue, Anthony
I'll look at adding/testing entries in a bit.

thanks
larry

Show
Larry M Elchuck, Ph.D. added a comment - You resolved this date display issue, Anthony I'll look at adding/testing entries in a bit. thanks larry
Hide
Permalink
Anthony Borrow added a comment -

Closing all of my resolved issues. Peace - Anthony

Show
Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.