Non-core contributed modules

Gradebook Plus Version 2 (GBPv2) Moodle 1.8 does not permit editing of grades after sorting students by Lastname

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8, 1.8.1, 1.8.2
  • Fix Version/s: None
  • Component/s: Patch: Gradebook Plus
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE

Description

I first reported this problem <a href="http://moodle.org/mod/forum/discuss.php?d=84721#p374406">here</a>. I have Gradebook Plus Version 2 (GBPv2) installed in Moodle 1.8. When I [[editgrades]], names of the students are sorted by Firstname. When I sort it by Lastname, I cannot [[editgrades]]. Is it possible to [[editgrades]] after sorting the names by Lastname?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

The attached patch will detect if the user is in edit mode and instead of using the action=vcats (which only displays the table), it uses the PHP str_replace function to replace action=vcats with action=edit so that edit mode is preserved in the sort by lastname and sort by firstname links ($student_heading_link).

Show
Anthony Borrow added a comment - The attached patch will detect if the user is in edit mode and instead of using the action=vcats (which only displays the table), it uses the PHP str_replace function to replace action=vcats with action=edit so that edit mode is preserved in the sort by lastname and sort by firstname links ($student_heading_link).
Hide
Permalink
Anthony Borrow added a comment -

Sanjay - Thanks for submitting this bug. The latest lib.php in CVS is now patched. Please test and let me know if it works for you. If not, we can re-open this issue. Also, if you are seeing [[edit grades]] that means you have not copied the language files to the /lang folder. Once you do that then you should see regular strings. The brackets indicate a missing language string. Peace - Anthony

Show
Anthony Borrow added a comment - Sanjay - Thanks for submitting this bug. The latest lib.php in CVS is now patched. Please test and let me know if it works for you. If not, we can re-open this issue. Also, if you are seeing [[edit grades]] that means you have not copied the language files to the /lang folder. Once you do that then you should see regular strings. The brackets indicate a missing language string. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Closing all of my resolved issues. Peace - Anthony

Show
Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.