Non-core contributed modules

unable to revert to old page version

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: None
  • Component/s: Module: OU wiki
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_19_STABLE

Description

After choosing a version to revert to (in the History page)
I get a page asking me to confirm the revert operation.
Clicking the confirm button does not revert to the selected version
and display the page again.

Changing revert.php line 36 from:

if($confirmed) {

To:

if($confirmed or $_POST['confirm']) {

Solved this issue.

I am using version 2010042201

Activity

Hide
Sam Marshall added a comment -

Hi, thanks. This bug affects only foreign language versions where the language does not use any ASCII characters, such as Hebrew. It is because the optional_param calls used PARAM_ALPHA. Changed to PARAM_RAW.

Fixed in stable R2.5

OU bug 11305

Show
Sam Marshall added a comment - Hi, thanks. This bug affects only foreign language versions where the language does not use any ASCII characters, such as Hebrew. It is because the optional_param calls used PARAM_ALPHA. Changed to PARAM_RAW. Fixed in stable R2.5 OU bug 11305

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: