Non-core contributed modules

[PATCH] Design options revert back to defaults when activity settings are edited on Oracle

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.8
  • Fix Version/s: None
  • Component/s: Module: Certificate
  • Labels:
    None
  • Environment:
    Moodle 1.8
  • Database:
    Oracle
  • Affected Branches:
    MOODLE_18_STABLE

Description

This bug is also related to the way that empty strings and NULLs are broken on Oracle, and how PHP treats the '0' string as empty.

If you change the design options in the activity settings to all "No", it works fine. However, the next time you edit those settings, they revert back to the defaults, ignoring what is actually stored in the DB. So if you don't notice and save the settings without fixing the design options, you get a design you don't want.

The way we worked-around this for our client is to simply store the default "No" parameter as 'none' in the database instead of '0'.

The attached patch (against the 1.8 version of the certificate module) also includes the DB upgrade script which migrates existing data.

Activity

There are no comments yet on this issue.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: