Non-core contributed modules

HotPot module not compatible with Custom Corners

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.9.11
  • Fix Version/s: None
  • Component/s: Module: HotPot
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

The Hotpot module appears not to function properly with Custom Corners turned on.

Image uploaded: "Existing Hot Potatoes Matching with any Custom Corners Theme (Hot Potatoes not compatible with Custom Corners)"

Reference discussion: http://moodle.org/mod/forum/discuss.php?d=97503

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Gordon Bateson added a comment -

Yes, as the reference discussion explains, currently the HotPot module up to and including Moodle 1.9 is not compatible with the custom corners theme.

In particular the display of the HotPot quizzes goes loopy, as the screen shot demonstrates.
To fix this properly requires modifiying mod/hopot/view.php to do the following:

1. separate the Hot Potatoes styles and Moodle theme styles

2. adding the special hacks to start and finish the custom corners
if ($THEME->customcorners) { print_custom_corners_start(); }
if ($THEME->customcorners) { print_custom_corners_end(); }

3. it may also be necessary to make sure that a standard Moodle footer is printed for some HotPot output formats

Show
Gordon Bateson added a comment - Yes, as the reference discussion explains, currently the HotPot module up to and including Moodle 1.9 is not compatible with the custom corners theme. In particular the display of the HotPot quizzes goes loopy, as the screen shot demonstrates. To fix this properly requires modifiying mod/hopot/view.php to do the following: 1. separate the Hot Potatoes styles and Moodle theme styles 2. adding the special hacks to start and finish the custom corners if ($THEME->customcorners) { print_custom_corners_start(); } if ($THEME->customcorners) { print_custom_corners_end(); } 3. it may also be necessary to make sure that a standard Moodle footer is printed for some HotPot output formats
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Permalink
Gordon Bateson added a comment -

This issue is not relevant to Moodle 2.x, because the HotPot module has been completely rewritten and does output in the standard Moodle 2.x way.

I will mark it as closed.

Show
Gordon Bateson added a comment - This issue is not relevant to Moodle 2.x, because the HotPot module has been completely rewritten and does output in the standard Moodle 2.x way. I will mark it as closed.
Hide
Permalink
Gordon Bateson added a comment -

Not a problem in Moodle 2.x

Show
Gordon Bateson added a comment - Not a problem in Moodle 2.x

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.