Non-core contributed modules

HotPot activities with quotes in their names have the name truncated when updated. Patch attached.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.11
  • Fix Version/s: None
  • Component/s: Module: HotPot
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

HotPot activities with quotes in their names have the name truncated when you go to update them. These quotes are passed intact when populating the text box, truncating the value.

The attached patch applies the htmlspecialchars to $form->name in moodle/mod/hotpot/mod.html , converting the double quotes into html entities, correcting the problem.

Activity

Hide
Gordon Bateson added a comment -

Thanks very much for reporting this and supplying the patch.

I have added the patch to Moodle 1.6, 1.7 and 1.8.

Moodle 1.9 and later do not use mod.html, so this is not an issue for those versions.

I confirmed I was able to add a HotPot activity with a quote in the name in all versions of Moodle 1.6 -> 2.0

If you have time, please confirm that the patched files in Moodle 1.6 -> 1.8 work for you.

many thanks
Gordon

Show
Gordon Bateson added a comment - Thanks very much for reporting this and supplying the patch. I have added the patch to Moodle 1.6, 1.7 and 1.8. Moodle 1.9 and later do not use mod.html, so this is not an issue for those versions. I confirmed I was able to add a HotPot activity with a quote in the name in all versions of Moodle 1.6 -> 2.0 If you have time, please confirm that the patched files in Moodle 1.6 -> 1.8 work for you. many thanks Gordon
Hide
Dan Poltawski added a comment -

Resolving this bug

Show
Dan Poltawski added a comment - Resolving this bug

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: