Issue Details (XML | Word | Printable)

Key: CONTRIB-343
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Mike Churchward
Reporter: Anthony Borrow
Votes: 2
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Non-core contributed modules

Module: Questionnaire - Installation error with changed field default value during creation of questionnaire_survey table

Created: 20/Mar/08 12:10 PM   Updated: 11/Apr/08 04:13 AM
Return to search
Component/s: Module: Questionnaire
Affects Version/s: 1.9
Fix Version/s: 1.8, 1.9, 2.0

Issue Links:
Dependency
 

Database: PostgreSQL
Participants: Anthony Borrow and Mike Churchward
Security Level: None
Resolved date: 11/Apr/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Mike,

I confirmed the error mentioned by Jonathan at: http://moodle.org/mod/forum/discuss.php?d=93024

To reproduce I downloaded the 19STABLE branch of questionnaire and popped it into a fresh 1.9 install. When I went to the notification page it started to set things up properly and then errored on the questionnaire_survey table creation.

I'm not sure exactly what is intended to happen on creating a new table. Looking at the upgrade, it appears as though this was initially a timestamp field that you are in the process of converting to an integer field to be more "Moodle-like". In any case, the current definition in install.xml causes an error. One quick work around is to simply remove the default value parameter so that line 45 reads:

<FIELD NAME="changed" TYPE="datetime" NOTNULL="false" SEQUENCE="false" ENUM="false" PREVIOUS="thank_body"/>

Since this prevents a successful install, I'm marking this as a blocker. Let me know if you have any questions.

Peace - Anthony

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Anthony Borrow added a comment - 21/Mar/08 03:33 AM
While they may be duplicates, the issues are closely related. One focuses on a fresh install the other on an upgrade. Peace - Anthony

Mike Churchward added a comment - 11/Apr/08 03:25 AM
Removed complete use of 'changed' field since it never actually needed anywhere.

Anthony Borrow added a comment - 11/Apr/08 04:13 AM
Mike - Thanks for fixing this up. I guess removing the field is one way of handling it Peace - Anthony