Non-core contributed modules

Module: Questionnaire - Installation error with changed field default value during creation of questionnaire_survey table

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.8, 1.9, 2.0
  • Component/s: Module: Questionnaire
  • Labels:
    None
  • Database:
    PostgreSQL
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

Description

Mike,

I confirmed the error mentioned by Jonathan at: http://moodle.org/mod/forum/discuss.php?d=93024

To reproduce I downloaded the 19STABLE branch of questionnaire and popped it into a fresh 1.9 install. When I went to the notification page it started to set things up properly and then errored on the questionnaire_survey table creation.

I'm not sure exactly what is intended to happen on creating a new table. Looking at the upgrade, it appears as though this was initially a timestamp field that you are in the process of converting to an integer field to be more "Moodle-like". In any case, the current definition in install.xml causes an error. One quick work around is to simply remove the default value parameter so that line 45 reads:

<FIELD NAME="changed" TYPE="datetime" NOTNULL="false" SEQUENCE="false" ENUM="false" PREVIOUS="thank_body"/>

Since this prevents a successful install, I'm marking this as a blocker. Let me know if you have any questions.

Peace - Anthony

Issue Links

Activity

Hide
Anthony Borrow added a comment -

While they may be duplicates, the issues are closely related. One focuses on a fresh install the other on an upgrade. Peace - Anthony

Show
Anthony Borrow added a comment - While they may be duplicates, the issues are closely related. One focuses on a fresh install the other on an upgrade. Peace - Anthony
Hide
Mike Churchward added a comment -

Removed complete use of 'changed' field since it never actually needed anywhere.

Show
Mike Churchward added a comment - Removed complete use of 'changed' field since it never actually needed anywhere.
Hide
Anthony Borrow added a comment -

Mike - Thanks for fixing this up. I guess removing the field is one way of handling it Peace - Anthony

Show
Anthony Borrow added a comment - Mike - Thanks for fixing this up. I guess removing the field is one way of handling it Peace - Anthony

People

Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: