Non-core contributed modules

replace missing field non-standard workarounds in hotpot_restore_record() with new $DB->get_columns()

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.2.1
  • Fix Version/s: None
  • Component/s: Module: HotPot
  • Labels:
    None
  • Affected Branches:
    MOODLE_22_STABLE

Description

Hello,
I have noticed some unusual code in hotpot_restore_record(), please fix them after the new dml and ddl stuff gets committed into HEAD,
the reason is we are no longer relying on adodb, fortunately there will be some new functions you could use (see $DB->get_columns())

Petr

Issue Links

This issue will help resolve:
MDL-14679 META: DB layer 2.0 Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Gordon Bateson added a comment -

Hi Petr,
am I right in thinking that at the moment this is not an issue and there is nothing to be fixed?

Please give me a shout when the new dml and ddl stuff gets committed into HEAD.

thanks
Gordon

Show
Gordon Bateson added a comment - Hi Petr, am I right in thinking that at the moment this is not an issue and there is nothing to be fixed? Please give me a shout when the new dml and ddl stuff gets committed into HEAD. thanks Gordon
Hide
Permalink
Petr Škoda (skodak) added a comment -

thanks,
we are planning the datalib changes commit for later this week.

Show
Petr Škoda (skodak) added a comment - thanks, we are planning the datalib changes commit for later this week.
Hide
Permalink
Petr Škoda (skodak) added a comment -

the patch landed in cvs

Show
Petr Škoda (skodak) added a comment - the patch landed in cvs
Hide
Permalink
Petr Škoda (skodak) added a comment -

should be now fixed in cvs

Show
Petr Škoda (skodak) added a comment - should be now fixed in cvs
Hide
Permalink
Gordon Bateson added a comment - - edited

The code works fine as it is, but if you want to standardize it you can make the following amendments:

  • remove lines 301 and 302
  • insert following line after line 300
    $table_columns[$table] = $DB->get_columns($table);
Show
Gordon Bateson added a comment - - edited The code works fine as it is, but if you want to standardize it you can make the following amendments:
  • remove lines 301 and 302
  • insert following line after line 300 $table_columns[$table] = $DB->get_columns($table);
Hide
Permalink
Gordon Bateson added a comment -

By the way, this issue should not be in CONTRIB because it refers to HotPot module in Moodle 1.9 which is a Moodle Core module.

Show
Gordon Bateson added a comment - By the way, this issue should not be in CONTRIB because it refers to HotPot module in Moodle 1.9 which is a Moodle Core module.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.