Non-core contributed modules

Eanbling Ajax removes block edit icons

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.1
  • Component/s: Block: Birthday
  • Labels:
    None
  • Environment:
    Apache 2.2, MySQL 5, PHP 5, Moodle 1.9
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

When AJAX is enabled at the site level and the editing user has Ajax usage enabled in his profile, all editing icons of the Birthday block are missing, except the roles one. All blocks positioned after the Birthday block also lose their editing icons.

The only way to edit the block after that is to disable ajax in the user profile / site admin menu.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

Anil - I was not able to reproduce this. I have seen strange AJAX behavior before which I had assumed was related to it reaching some count limit or something but I never investigated it thoroughly. What happens if you move the birthday block somewhere earlier in the page? If might suspect that when it reaches a certain number of blocks that the AJAX stuff stops working which would indicate to me that it is not so much an issue with the birthday block. Since I cannot reproduce it (I have AJAX enabled for the site and the admin user) can you play with this some more and report back what you find? In the meantime, I am going to resolve this as Cannot Reproduce; however, if we can figure out what it is then I will modify it. FYI, as a result, I did notice a small logical error causing an undefined property notice that I did correct so I appreciated the chance to go back in and look at the code. Peace - Anthony

Show
Anthony Borrow added a comment - Anil - I was not able to reproduce this. I have seen strange AJAX behavior before which I had assumed was related to it reaching some count limit or something but I never investigated it thoroughly. What happens if you move the birthday block somewhere earlier in the page? If might suspect that when it reaches a certain number of blocks that the AJAX stuff stops working which would indicate to me that it is not so much an issue with the birthday block. Since I cannot reproduce it (I have AJAX enabled for the site and the admin user) can you play with this some more and report back what you find? In the meantime, I am going to resolve this as Cannot Reproduce; however, if we can figure out what it is then I will modify it. FYI, as a result, I did notice a small logical error causing an undefined property notice that I did correct so I appreciated the chance to go back in and look at the code. Peace - Anthony
Hide
Permalink
Anil Sharma added a comment -

Did some more checking on this. I've now installed this block on 3 sites of moodle 1.9 and all are giving the same problem.

With Ajax on, If the Birthday block is inserted at the bottom of the page, all other blocks have editing icons except the birthday block . If the block is in between other blocks on the page, once ajax is on, all blocks from the birthday block onwards do not get their editing icons.

Everything else on the page gets editing icons. I've changed the theme , checked with firefox and IE , problem is same.

Show
Anil Sharma added a comment - Did some more checking on this. I've now installed this block on 3 sites of moodle 1.9 and all are giving the same problem. With Ajax on, If the Birthday block is inserted at the bottom of the page, all other blocks have editing icons except the birthday block . If the block is in between other blocks on the page, once ajax is on, all blocks from the birthday block onwards do not get their editing icons. Everything else on the page gets editing icons. I've changed the theme , checked with firefox and IE , problem is same.
Hide
Permalink
Anthony Borrow added a comment -

Anil - Thanks for reporting back so quickly. That does sound like it might be an issue with the birthday block. Could you attach a screenshot so that I can see what it looks like (I'm most interested in the one that prevents other editing buttons from appearing so if you could put it second or third to last that would help me to see it. Peace - Anthony

Show
Anthony Borrow added a comment - Anil - Thanks for reporting back so quickly. That does sound like it might be an issue with the birthday block. Could you attach a screenshot so that I can see what it looks like (I'm most interested in the one that prevents other editing buttons from appearing so if you could put it second or third to last that would help me to see it. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Anil - OK, I am able to replicate this just not on the front page but within a course I see this behavior and the AJAX behavior seems very strange and erratic to me. I will have to look at the html source code underneath and see what is different. If you catch anything there comparing the birthday block to the others please comment here. Peace - Anthony

Show
Anthony Borrow added a comment - Anil - OK, I am able to replicate this just not on the front page but within a course I see this behavior and the AJAX behavior seems very strange and erratic to me. I will have to look at the html source code underneath and see what is different. If you catch anything there comparing the birthday block to the others please comment here. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

The issue had to do with the html_attributes function in the birthday block that was not needed. I removed it and added a styles.php file. Initially I was confused by how to keep the formatting to be the same as the online users block but I think this should address the issue. If not, please let me know. Peace - Anthony

Show
Anthony Borrow added a comment - The issue had to do with the html_attributes function in the birthday block that was not needed. I removed it and added a styles.php file. Initially I was confused by how to keep the formatting to be the same as the online users block but I think this should address the issue. If not, please let me know. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

fixed in CVS (HEAD)

Show
Anthony Borrow added a comment - fixed in CVS (HEAD)
Hide
Permalink
Anthony Borrow added a comment -

Closing all of my resolved issues. Peace - Anthony

Show
Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.