Non-core contributed modules

Grade export does not work after upgrade

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8.3, 1.8.4, 1.8.5
  • Fix Version/s: None
  • Component/s: Patch: Gradebook Plus
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE

Description

After upgrading from 1.8.2 to 1.8.3 the gradebook does not properly export grades in any format - only the column headings are exported. This is true only for existing courses; if a new course is created, grade export works correctly.

The problem persists even after upgrading to 1.8.5 and installing the latest version of GBPv2

  1. CONTRIB-404.diff
    14/May/08 7:26 AM
    1 kB
    Anthony Borrow
  2. CONTRIB-404-core.diff
    14/May/08 7:39 AM
    0.9 kB
    Anthony Borrow
  3. PHY118-01S08_Grades.txt
    30/Apr/08 10:37 PM
    0.4 kB
    Caroline Moore

Activity

Hide
Anthony Borrow added a comment -

Caroline - Rather than being related to scales, it appears to me that the issue with the course you shared with me is the group mode. The problem is around line 1405. I am preparing to check in a fix that will start with all students and then replace it when the smaller group is wanted. So instead of having:

/// Check to see if groups are being used in this course

if (groupmode($course) !=0) {
if ($currentgroup = get_current_group($course->id)) { // get the current group
$students = get_group_students($currentgroup, "u.lastname ASC"); // group members of the group
}}
else {// if not groupmode then the group is the entire course so get all course students $students = grade_get_course_students($course->id); }

I am looking at replacing it with:

/// Check to see if groups are being used in this course

$students = grade_get_course_students($course->id); //see CONTRIB-404 - get all students first and then reduce if there is a group
if (groupmode($course) !=0) {
if ($currentgroup = get_current_group($course->id)) { // get the current group $students = get_group_students($currentgroup, "u.lastname ASC"); // group members of the group }
}

Show
Anthony Borrow added a comment - Caroline - Rather than being related to scales, it appears to me that the issue with the course you shared with me is the group mode. The problem is around line 1405. I am preparing to check in a fix that will start with all students and then replace it when the smaller group is wanted. So instead of having: /// Check to see if groups are being used in this course if (groupmode($course) !=0) { if ($currentgroup = get_current_group($course->id)) { // get the current group $students = get_group_students($currentgroup, "u.lastname ASC"); // group members of the group }} else {// if not groupmode then the group is the entire course so get all course students $students = grade_get_course_students($course->id); } I am looking at replacing it with: /// Check to see if groups are being used in this course $students = grade_get_course_students($course->id); //see CONTRIB-404 - get all students first and then reduce if there is a group if (groupmode($course) !=0) { if ($currentgroup = get_current_group($course->id)) { // get the current group $students = get_group_students($currentgroup, "u.lastname ASC"); // group members of the group } }
Hide
Anthony Borrow added a comment -

Here is the patch that I applied to GBPv2. I would also like to apply this to 18STABLE so that we can export grades when groups are set for a course and the teacher is viewing all the participants.

Show
Anthony Borrow added a comment - Here is the patch that I applied to GBPv2. I would also like to apply this to 18STABLE so that we can export grades when groups are set for a course and the teacher is viewing all the participants.
Hide
Anthony Borrow added a comment -

Here is a patch that I would suggest for core (18STABLE).

Show
Anthony Borrow added a comment - Here is a patch that I would suggest for core (18STABLE).
Hide
Anthony Borrow added a comment -

Caroline - Were you able to verify that the commits actually fixed this issue for you. If not, no worries as I have assigned Wen as the official QA for this issue. I'm marking as resolved and if there are issues that come up just let me know and we can take another look. Peace - Anthony

Show
Anthony Borrow added a comment - Caroline - Were you able to verify that the commits actually fixed this issue for you. If not, no worries as I have assigned Wen as the official QA for this issue. I'm marking as resolved and if there are issues that come up just let me know and we can take another look. Peace - Anthony
Hide
Anthony Borrow added a comment -

Closing all of my resolved issues. Peace - Anthony

Show
Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: