Details
-
Type:
Bug
-
Status:
Resolved
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 1.6.4, 1.7.1, 1.8
-
Component/s: Module: WebQuest
-
Labels:None
-
Affected Branches:MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE
-
Fixed Branches:MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE
Description
Some things seem to be incorrect in the .sql files:
- collate utf8_bin is specified here and there.
- lots of TEXT columns with NOT NULL default ''. If they are optional, must be, simply, TEXT.
- some missing keys
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Hide
Eloy Lafuente (stronk7)
added a comment -
I've assigned this to myself. I'm working on it right now. Tasks performed:
- Updated the mysql.sql under 1.6 and 1.7 to fix some problems (collations are now out from definitions, text not nulls are now nulls (without default clause) and some index have been added.
- Delete the mysql.sql file under 1.8 and HEAD. Those versions will use install.xml instead.
TODO:
- Modify install.xml to reflect all the changes performed to mysql.sql. With that, DB should be ok to continue working (I'll do that for 1.7, 1.8 and HEAD).
Ciao 
Show
Eloy Lafuente (stronk7)
added a comment - I've assigned this to myself. I'm working on it right now. Tasks performed:
- Updated the mysql.sql under 1.6 and 1.7 to fix some problems (collations are now out from definitions, text not nulls are now nulls (without default clause) and some index have been added.
- Delete the mysql.sql file under 1.8 and HEAD. Those versions will use install.xml instead.
- Modify install.xml to reflect all the changes performed to mysql.sql. With that, DB should be ok to continue working (I'll do that for 1.7, 1.8 and HEAD).
Changing to critical. Should be fixed ASAP or we'll get tons of upgrade problems later!