Non-core contributed modules

embed an office document inside HTML editor's content by selecting some text and linking it

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.2
  • Fix Version/s: None
  • Component/s: Filter: Docview
  • Labels:
    None
  • Environment:
    apache 2 , php 5, mysql 5 , linux os

Description

inspired by firefox addon : "open it online" that lets you view any office document inside an online web2 service like : google docs, zoho or thinkfree projects... i made a filter that lets you do the same for "linked" office documents inside the HTML editor.

unzip it into moodle's filter folder and enable it in the admin/modules/filters view.

to use it: link and selected text to an office document on the internet.

feedback me please !

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

Nadav - Sounds interesting. I'll put it on my to do list of things to check out. It will probably be later next week before I get to it but I wanted to thank you for sharing your code (and time and talent) with the Moodle community. After I look at it, I will certainly be happy to give you feedback. Peace - Anthony

Show
Anthony Borrow added a comment - Nadav - Sounds interesting. I'll put it on my to do list of things to check out. It will probably be later next week before I get to it but I wanted to thank you for sharing your code (and time and talent) with the Moodle community. After I look at it, I will certainly be happy to give you feedback. Peace - Anthony
Hide
Permalink
Nadav Kavalerchik added a comment -

hi anthony

thank you for your kind words

please check some other filter i made and see if i should add it here too
http://moodle.org/mod/data/view.php?d=13&rid=1624

or should i add this filter to the "modules and plugins" list ?

Show
Nadav Kavalerchik added a comment - hi anthony thank you for your kind words please check some other filter i made and see if i should add it here too http://moodle.org/mod/data/view.php?d=13&rid=1624 or should i add this filter to the "modules and plugins" list ?
Hide
Permalink
Anthony Borrow added a comment -

Nadav - Thank you for sharing this code with the community. I am sorry I have not had a chance to review it sooner. I am getting ready to go to Nepal in a couple of days and trying to quickly catch up on a series of backlogged issues including this one. The first thing I noticed is that the language files and get_strings were slightly off. The current way of handling things as described at http://docs.moodle.org/en/Development:Places_to_search_for_lang_strings involves using the following syntax:

get_string('mystring','filter_docview')

then the language file will be located in /filter/docview/lang/en_utf8/filter_docview.php

I believe I changed everything and renamed both files. Let me know if you have any questions. I'm continue to review the code and will try it out before committing to the CVS server but it looks like nice work. Peace - Anthony

Show
Anthony Borrow added a comment - Nadav - Thank you for sharing this code with the community. I am sorry I have not had a chance to review it sooner. I am getting ready to go to Nepal in a couple of days and trying to quickly catch up on a series of backlogged issues including this one. The first thing I noticed is that the language files and get_strings were slightly off. The current way of handling things as described at http://docs.moodle.org/en/Development:Places_to_search_for_lang_strings involves using the following syntax: get_string('mystring','filter_docview') then the language file will be located in /filter/docview/lang/en_utf8/filter_docview.php I believe I changed everything and renamed both files. Let me know if you have any questions. I'm continue to review the code and will try it out before committing to the CVS server but it looks like nice work. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

In response to your question about http://moodle.org/mod/data/view.php?d=13&rid=1624 feel free to create another issue in the tracker. Generally speaking I refer folks to http://docs.moodle.org/en/Development:Guidelines_for_contributed_code for instructions on how to share code. I treat each project separately and try to follow the same procedure. So each filter should have its own entry in the Modules and Plugins database. Keeping each project separate helps me to maintain some resemblance or at least the illusion of sanity. Thanks again for your patience. Peace - Anthony

Show
Anthony Borrow added a comment - In response to your question about http://moodle.org/mod/data/view.php?d=13&rid=1624 feel free to create another issue in the tracker. Generally speaking I refer folks to http://docs.moodle.org/en/Development:Guidelines_for_contributed_code for instructions on how to share code. I treat each project separately and try to follow the same procedure. So each filter should have its own entry in the Modules and Plugins database. Keeping each project separate helps me to maintain some resemblance or at least the illusion of sanity. Thanks again for your patience. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

moving to Filter: Docview component

Show
Anthony Borrow added a comment - moving to Filter: Docview component
Hide
Permalink
Anthony Borrow added a comment - - edited

Nadav - I've tested the filter and like the functionality. Again, great work. I did notice, and did not explore why, that when I changed the setting from using Zoho to Google docs that I began getting a 404 error. Once I switched back to Zoho and went back in and edited the label it began working again. In any case, I've uploaded the code, created a Filter: Docview component in the tracker so that others can create bug reports, suggestions, feature requests, etc. I bumped your privileges in the tracker so that you can manage the issues related to the Docview filter. Next, I need you to apply for CVS write access (via http://moodle.org/cvs) and request access to contrib/plugins/filter/docview. I would suggest creating a README.txt file describing INSTALLATION and USAGE of the filter. In addition, as mentioned follow the Guidelines for contributed code for creating the Modules and Plugins entry with the correct download link so that you can use Moodle's download server (download.moodle.org) so that when you make changes to the code the zip file will automatically be generated to include those changes every 24 hours. Also, I would encourage you to create documentation pages in Moodle docs (docs.moodle.org). Let me know if you have any questions. Again, if I am delayed in responding it may be because I am in Nepal for 3 weeks without Internet access. Peace - Anthony

Show
Anthony Borrow added a comment - - edited Nadav - I've tested the filter and like the functionality. Again, great work. I did notice, and did not explore why, that when I changed the setting from using Zoho to Google docs that I began getting a 404 error. Once I switched back to Zoho and went back in and edited the label it began working again. In any case, I've uploaded the code, created a Filter: Docview component in the tracker so that others can create bug reports, suggestions, feature requests, etc. I bumped your privileges in the tracker so that you can manage the issues related to the Docview filter. Next, I need you to apply for CVS write access (via http://moodle.org/cvs) and request access to contrib/plugins/filter/docview. I would suggest creating a README.txt file describing INSTALLATION and USAGE of the filter. In addition, as mentioned follow the Guidelines for contributed code for creating the Modules and Plugins entry with the correct download link so that you can use Moodle's download server (download.moodle.org) so that when you make changes to the code the zip file will automatically be generated to include those changes every 24 hours. Also, I would encourage you to create documentation pages in Moodle docs (docs.moodle.org). Let me know if you have any questions. Again, if I am delayed in responding it may be because I am in Nepal for 3 weeks without Internet access. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Closing all of my resolved issues. Peace - Anthony

Show
Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.