|
Stephen,
I know it looks like I am just dead set to break something but the ideas keep coming. My general sentiment is that the less code we have, the less we have to maintain, the less possible security holes, etc. The language strings for languages other than en, de, and es can be obtained either from MRBS or the 18STABLE branch. As such, they are not used and no longer needed but still accessible if someone wants to provide an additional language pack for the block. If so, they should make sure to also include a translation of the help/site_faq.html file. If they do not, it will load the English version following the Moodle tradition of filling in an empty language string with the English equivalent. Let me know your thoughts even if its just +1 or -100 Peace - Anthony I think we can also safely remove phpinfo2.php since Moodle has a phpinfo.php under Site Administration - Server - PHP info.
Patch file for irrelevant file removal and some minor languages fixes
OK, I've committed the removal of the files. Let me know if there are any that should be un-removed or others can we can get rid of. I'm assigning Stephen for QA, if it looks good, you can go ahead and close this issue. Thanks again for your help in reviewing this and in keeping me sane. Peace - Anthony
I would ideally like to get to a point where we can remove language.php. I believe all that it is doing at this point is setting the locale but I need to take a closer look at where it is used and which variable are using it. Peace - Anthony
I also removed the mrbs_setup folder under /blocks/mrbs/db/ as was not needed especially post install.xml
Looks OK to me, but I will not be able to test it until the end of this week.
One comment however. You may want to review the contents of the site_faq.html file and update it to reflect some of the changes you made (The authentication section should probably be revised) -Steve Stephen - I revised the FAQ page and made it more specific to the Moodle block including a link to Moodle docs. Would you like for me to include a URL for folks to be able to Moodle message you (since you are mentioned on the page)? Peace - Anthony
a diff file showing the removal of the mail related files no longer used after resolving
Stephen - I have deleted all the Mail related files and directories. I tried to search to make sure that there was nothing that was being used but it is always possible to miss something. Let me know if you discover any problems. Peace - Anthony
I've gone through and tested the changes and they all seem to work.
Closing the issue. -Steve |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Task
Closed
Minor
MRBS: Remove irrelevant files
 |
|
CONTRIB-628is subtask ofCONTRIB-230