Non-core contributed modules

MRBS: Remove irrelevant files

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: None
  • Component/s: Block: Mrbs
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE

Description

Remove irrelevant files including:

edit_users.php - since all users should be managed via Moodle
auth_*.php files except for auth_moodle.php
session_* files except session_php
lang.*.php files - all language strings should be in lang/xx_utf8/block_mrbs.php
move site_faq.html files into /blocks/mrbs/lang/xx_utf8/site_faq.html

Attachments

  1. File
    CONTRIB-628.diff
    03/Aug/08 4:23 AM
    352 kB
    Anthony Borrow
  2. File
    CONTRIB-630.diff
    05/Aug/08 2:07 PM
    143 kB
    Anthony Borrow

Issue Links

This issue will help resolve:
CONTRIB-230 MRBS: Update MRBS block from MRBS 1.2.3 to 1.2.5 Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

CONTRIB-628 is subtask of CONTRIB-230

Show
Anthony Borrow added a comment - CONTRIB-628 is subtask of CONTRIB-230
Hide
Permalink
Anthony Borrow added a comment -

Stephen,

I know it looks like I am just dead set to break something but the ideas keep coming. My general sentiment is that the less code we have, the less we have to maintain, the less possible security holes, etc.

The language strings for languages other than en, de, and es can be obtained either from MRBS or the 18STABLE branch. As such, they are not used and no longer needed but still accessible if someone wants to provide an additional language pack for the block. If so, they should make sure to also include a translation of the help/site_faq.html file. If they do not, it will load the English version following the Moodle tradition of filling in an empty language string with the English equivalent. Let me know your thoughts even if its just +1 or -100

Peace - Anthony

Show
Anthony Borrow added a comment - Stephen, I know it looks like I am just dead set to break something but the ideas keep coming. My general sentiment is that the less code we have, the less we have to maintain, the less possible security holes, etc. The language strings for languages other than en, de, and es can be obtained either from MRBS or the 18STABLE branch. As such, they are not used and no longer needed but still accessible if someone wants to provide an additional language pack for the block. If so, they should make sure to also include a translation of the help/site_faq.html file. If they do not, it will load the English version following the Moodle tradition of filling in an empty language string with the English equivalent. Let me know your thoughts even if its just +1 or -100 Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I think we can also safely remove phpinfo2.php since Moodle has a phpinfo.php under Site Administration - Server - PHP info.

Show
Anthony Borrow added a comment - I think we can also safely remove phpinfo2.php since Moodle has a phpinfo.php under Site Administration - Server - PHP info.
Hide
Permalink
Anthony Borrow added a comment -

Patch file for irrelevant file removal and some minor languages fixes

Show
Anthony Borrow added a comment - Patch file for irrelevant file removal and some minor languages fixes
Hide
Permalink
Anthony Borrow added a comment -

OK, I've committed the removal of the files. Let me know if there are any that should be un-removed or others can we can get rid of. I'm assigning Stephen for QA, if it looks good, you can go ahead and close this issue. Thanks again for your help in reviewing this and in keeping me sane. Peace - Anthony

Show
Anthony Borrow added a comment - OK, I've committed the removal of the files. Let me know if there are any that should be un-removed or others can we can get rid of. I'm assigning Stephen for QA, if it looks good, you can go ahead and close this issue. Thanks again for your help in reviewing this and in keeping me sane. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I would ideally like to get to a point where we can remove language.php. I believe all that it is doing at this point is setting the locale but I need to take a closer look at where it is used and which variable are using it. Peace - Anthony

Show
Anthony Borrow added a comment - I would ideally like to get to a point where we can remove language.php. I believe all that it is doing at this point is setting the locale but I need to take a closer look at where it is used and which variable are using it. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I also removed the mrbs_setup folder under /blocks/mrbs/db/ as was not needed especially post install.xml

Show
Anthony Borrow added a comment - I also removed the mrbs_setup folder under /blocks/mrbs/db/ as was not needed especially post install.xml
Hide
Permalink
Stephen Bourget added a comment -

Looks OK to me, but I will not be able to test it until the end of this week.

One comment however. You may want to review the contents of the site_faq.html file and update it to reflect some of the changes you made (The authentication section should probably be revised)

-Steve

Show
Stephen Bourget added a comment - Looks OK to me, but I will not be able to test it until the end of this week. One comment however. You may want to review the contents of the site_faq.html file and update it to reflect some of the changes you made (The authentication section should probably be revised) -Steve
Hide
Permalink
Anthony Borrow added a comment -

Stephen - I revised the FAQ page and made it more specific to the Moodle block including a link to Moodle docs. Would you like for me to include a URL for folks to be able to Moodle message you (since you are mentioned on the page)? Peace - Anthony

Show
Anthony Borrow added a comment - Stephen - I revised the FAQ page and made it more specific to the Moodle block including a link to Moodle docs. Would you like for me to include a URL for folks to be able to Moodle message you (since you are mentioned on the page)? Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

a diff file showing the removal of the mail related files no longer used after resolving CONTRIB-630

Show
Anthony Borrow added a comment - a diff file showing the removal of the mail related files no longer used after resolving CONTRIB-630
Hide
Permalink
Anthony Borrow added a comment -

Stephen - I have deleted all the Mail related files and directories. I tried to search to make sure that there was nothing that was being used but it is always possible to miss something. Let me know if you discover any problems. Peace - Anthony

Show
Anthony Borrow added a comment - Stephen - I have deleted all the Mail related files and directories. I tried to search to make sure that there was nothing that was being used but it is always possible to miss something. Let me know if you discover any problems. Peace - Anthony
Hide
Permalink
Stephen Bourget added a comment -

I've gone through and tested the changes and they all seem to work.

Closing the issue.

-Steve

Show
Stephen Bourget added a comment - I've gone through and tested the changes and they all seem to work. Closing the issue. -Steve

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.