[#CONTRIB-630] MRBS: Change mail calls to Moodle native calls such as email_to_user

Issue Details (XML | Word | Printable)

Key:	CONTRIB-630
Type:	Task
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Anthony Borrow
Reporter:	Anthony Borrow
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Non-core contributed modules

MRBS: Change mail calls to Moodle native calls such as email_to_user

Created: 03/Aug/08 04:07 AM Updated: 05/Aug/08 11:23 PM

Return to search

Component/s:

Block: Mrbs

Affects Version/s:

2.0

Fix Version/s:

None

File Attachments:

mrbs_email.diff (81 kB)

Issue Links:

Dependency

This issue will help resolve:

~~CONTRIB-230~~ MRBS: Update MRBS block from MRBS 1.2.3 to 1.2.5

Participants:	Anthony Borrow
Security Level:	None
Resolved date:	05/Aug/08
Affected Branches:	MOODLE_20_STABLE

Description

« Hide

Since this is a block within Moodle, it should send out emails in a Moodle consistent way. This will also allow us to get rid of the blocsk/mrbs/web/Mail and /blocks/mrbs/web/Net folder and hopefully the functions_mail.php and Mail.php files.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Anthony Borrow added a comment - 03/Aug/08 04:07 AM

~~CONTRIB-630~~ is a subtask of ~~CONTRIB-230~~

[ Permalink | « Hide ]

Anthony Borrow added a comment - 03/Aug/08 04:35 AM

1) function_mail.php using $mail_vocab - I'll come back and fix this up later to remove it
2) in /blocks/mrbs/lang/xx_utf8/block_mrbs.php there are strings like mail_body_changed_entry which previously had a prepended $mail variable which I removed for the sake of simplicity; however, these will need to be cleaned up and may break some of the mail functionality.

[ Permalink | « Hide ]

Anthony Borrow added a comment - 05/Aug/08 12:52 PM

I have moved the functions previously in functions_mail.php to functions.php as I saw no good reason to keep them separated. This will allow functions_mail.php to be deleted.

[ Permalink | « Hide ]

Anthony Borrow added a comment - 05/Aug/08 01:02 PM

diff file used for changes from sendmail to email_to_user

[ Permalink | « Hide ]

Anthony Borrow added a comment - 05/Aug/08 02:06 PM

I'm marking this as resolved since all the emails being sent are now using the Moodle email_to_user function.

[ Permalink | « Hide ]

Anthony Borrow added a comment - 05/Aug/08 11:23 PM

Just wanted to comment that it could use some thorough testing. I just verified that it was reasonably functional but there may be little glitches, missing language strings, etc. so just let me know of any glitches that you come across. Peace - Anthony

All content on this web site is made available under the GNU General Public License, unless otherwise stated.