Non-core contributed modules

MRBS: Change mail calls to Moodle native calls such as email_to_user

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: None
  • Component/s: Block: Mrbs
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE

Description

Since this is a block within Moodle, it should send out emails in a Moodle consistent way. This will also allow us to get rid of the blocsk/mrbs/web/Mail and /blocks/mrbs/web/Net folder and hopefully the functions_mail.php and Mail.php files.

Issue Links

This issue will help resolve:
CONTRIB-230 MRBS: Update MRBS block from MRBS 1.2.3 to 1.2.5 Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

CONTRIB-630 is a subtask of CONTRIB-230

Show
Anthony Borrow added a comment - CONTRIB-630 is a subtask of CONTRIB-230
Hide
Permalink
Anthony Borrow added a comment -

1) function_mail.php using $mail_vocab - I'll come back and fix this up later to remove it
2) in /blocks/mrbs/lang/xx_utf8/block_mrbs.php there are strings like mail_body_changed_entry which previously had a prepended $mail variable which I removed for the sake of simplicity; however, these will need to be cleaned up and may break some of the mail functionality.

Show
Anthony Borrow added a comment - 1) function_mail.php using $mail_vocab - I'll come back and fix this up later to remove it 2) in /blocks/mrbs/lang/xx_utf8/block_mrbs.php there are strings like mail_body_changed_entry which previously had a prepended $mail variable which I removed for the sake of simplicity; however, these will need to be cleaned up and may break some of the mail functionality.
Hide
Permalink
Anthony Borrow added a comment -

I have moved the functions previously in functions_mail.php to functions.php as I saw no good reason to keep them separated. This will allow functions_mail.php to be deleted.

Show
Anthony Borrow added a comment - I have moved the functions previously in functions_mail.php to functions.php as I saw no good reason to keep them separated. This will allow functions_mail.php to be deleted.
Hide
Permalink
Anthony Borrow added a comment -

diff file used for changes from sendmail to email_to_user

Show
Anthony Borrow added a comment - diff file used for changes from sendmail to email_to_user
Hide
Permalink
Anthony Borrow added a comment -

I'm marking this as resolved since all the emails being sent are now using the Moodle email_to_user function.

Show
Anthony Borrow added a comment - I'm marking this as resolved since all the emails being sent are now using the Moodle email_to_user function.
Hide
Permalink
Anthony Borrow added a comment -

Just wanted to comment that it could use some thorough testing. I just verified that it was reasonably functional but there may be little glitches, missing language strings, etc. so just let me know of any glitches that you come across. Peace - Anthony

Show
Anthony Borrow added a comment - Just wanted to comment that it could use some thorough testing. I just verified that it was reasonably functional but there may be little glitches, missing language strings, etc. so just let me know of any glitches that you come across. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Closing all of my resolved issues. Peace - Anthony

Show
Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.