Non-core contributed modules

MRBS block repeated bookings

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.2
  • Fix Version/s: None
  • Component/s: Block: Mrbs
  • Labels:
    None
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_19_STABLE

Description

Impossible to make repeated bookings on the latest version of the MRBS block (block_mrbs.php,v 1.4 2008/08/07 01:03:34).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

Here is a patch file I will commit. I also noticed a regression on the time stuff. It appears that the calendar gets messed up if I user the userdate function so I have switched it back to strftime function. Let me know if this patches things up and/or creates other problems. Peace - Anthony

Show
Anthony Borrow added a comment - Here is a patch file I will commit. I also noticed a regression on the time stuff. It appears that the calendar gets messed up if I user the userdate function so I have switched it back to strftime function. Let me know if this patches things up and/or creates other problems. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I'd like to do more testing with the times and dates and make sure everything is displaying correctly. I noticed the calendar days were off a bit so a reverted the change from userdate back to strftime for some of the stuff in minical.php. I guess I could make sure to use an offset when generating the mktime stuff but this seemed easier for the time being. If I need to take a closer look I will. I also forgot to allow for some of the vars needed to schedule repeated events when I was working on the sql injection patch so I think all of that should now work. Let me know if you come across any problems. Peace - Anthony

Show
Anthony Borrow added a comment - I'd like to do more testing with the times and dates and make sure everything is displaying correctly. I noticed the calendar days were off a bit so a reverted the change from userdate back to strftime for some of the stuff in minical.php. I guess I could make sure to use an offset when generating the mktime stuff but this seemed easier for the time being. If I need to take a closer look I will. I also forgot to allow for some of the vars needed to schedule repeated events when I was working on the sql injection patch so I think all of that should now work. Let me know if you come across any problems. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Closing all of my resolved issues. Peace - Anthony

Show
Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.