Issue Details (XML | Word | Printable)

Key: CONTRIB-653
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Anthony Borrow
Reporter: Jean-Pierre Pawlak
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Non-core contributed modules

MRBS block repeated bookings

Created: 13/Aug/08 04:08 PM   Updated: 15/Aug/08 05:18 PM
Return to search
Component/s: Block: Mrbs
Affects Version/s: 1.9.2
Fix Version/s: None

File Attachments: 1. File CONTRIB-653.diff (5 kB)


Database: MySQL
Participants: Anthony Borrow and Jean-Pierre Pawlak
Security Level: None
QA Assignee: Stephen Bourget
Resolved date: 15/Aug/08
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
Impossible to make repeated bookings on the latest version of the MRBS block (block_mrbs.php,v 1.4 2008/08/07 01:03:34).

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Anthony Borrow added a comment - 15/Aug/08 05:12 PM
Here is a patch file I will commit. I also noticed a regression on the time stuff. It appears that the calendar gets messed up if I user the userdate function so I have switched it back to strftime function. Let me know if this patches things up and/or creates other problems. Peace - Anthony

Anthony Borrow added a comment - 15/Aug/08 05:18 PM
I'd like to do more testing with the times and dates and make sure everything is displaying correctly. I noticed the calendar days were off a bit so a reverted the change from userdate back to strftime for some of the stuff in minical.php. I guess I could make sure to use an offset when generating the mktime stuff but this seemed easier for the time being. If I need to take a closer look I will. I also forgot to allow for some of the vars needed to schedule repeated events when I was working on the sql injection patch so I think all of that should now work. Let me know if you come across any problems. Peace - Anthony