[#CONTRIB-653] MRBS block repeated bookings

Issue Details (XML | Word | Printable)

Key:	CONTRIB-653
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Anthony Borrow
Reporter:	Jean-Pierre Pawlak
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Non-core contributed modules

MRBS block repeated bookings

Created: 13/Aug/08 04:08 PM Updated: 15/Aug/08 05:18 PM

Return to search

Component/s:

Block: Mrbs

Affects Version/s:

1.9.2

Fix Version/s:

None

File Attachments:

CONTRIB-653.diff (5 kB)

Database:	MySQL
Participants:	Anthony Borrow and Jean-Pierre Pawlak
Security Level:	None
QA Assignee:	Stephen Bourget
Resolved date:	15/Aug/08
Affected Branches:	MOODLE_19_STABLE

Description

« Hide

Impossible to make repeated bookings on the latest version of the MRBS block (block_mrbs.php,v 1.4 2008/08/07 01:03:34).

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda made changes - 13/Aug/08 04:23 PM

Field	Original Value	New Value
Project	Moodle [ 10011 ]	Non-core contributed modules [ 10033 ]
Affects Version/s		1.9.2 [ 10281 ]
Key	MDL-16027	~~CONTRIB-653~~
Component/s		Block: Mrbs [ 10216 ]
Component/s	Blocks [ 10076 ]
Affects Version/s	1.9.2 [ 10280 ]

[ Permalink | « Hide ]

Anthony Borrow added a comment - 15/Aug/08 05:12 PM

Here is a patch file I will commit. I also noticed a regression on the time stuff. It appears that the calendar gets messed up if I user the userdate function so I have switched it back to strftime function. Let me know if this patches things up and/or creates other problems. Peace - Anthony

Anthony Borrow made changes - 15/Aug/08 05:12 PM

Attachment

CONTRIB-653.diff [ 14843 ]

arborrow committed 3 files to 'Contrib CVS' - 15/Aug/08 05:14 PM

~~CONTRIB-653~~ - fixing regression introduced from sql injection patch that prevented needed vars from being passed for repeat events; also fixing regression in calendar introduced by userdate

MODIFY	plugins/blocks/mrbs/web/mrbs_sql.php	Rev. 1.7	(+5 -4 lines)
MODIFY	plugins/blocks/mrbs/web/edit_entry_handler.php	Rev. 1.7	(+16 -6 lines)
MODIFY	plugins/blocks/mrbs/web/mincals.php	Rev. 1.4	(+3 -3 lines)

Anthony Borrow made changes - 15/Aug/08 05:14 PM

Assignee

Nobody [ nobody ]

Anthony Borrow [ aborrow ]

[ Permalink | « Hide ]

Anthony Borrow added a comment - 15/Aug/08 05:18 PM

I'd like to do more testing with the times and dates and make sure everything is displaying correctly. I noticed the calendar days were off a bit so a reverted the change from userdate back to strftime for some of the stuff in minical.php. I guess I could make sure to use an offset when generating the mktime stuff but this seemed easier for the time being. If I need to take a closer look I will. I also forgot to allow for some of the vars needed to schedule repeated events when I was working on the sql injection patch so I think all of that should now work. Let me know if you come across any problems. Peace - Anthony

Anthony Borrow made changes - 15/Aug/08 05:18 PM

Status	Open [ 1 ]	Resolved [ 5 ]
QA Assignee		sbourget
Resolution		Fixed [ 1 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.