Issue Details (XML | Word | Printable)

Key: CONTRIB-665
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Anthony Borrow
Reporter: Stephen Bourget
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Non-core contributed modules

The login form displayed through MRBS does not work.

Created: 18/Aug/08 05:23 AM   Updated: 18/Aug/08 12:46 PM
Return to search
Component/s: Block: Mrbs
Affects Version/s: 1.9.1
Fix Version/s: None

File Attachments: 1. File CONTRIB-665.diff (1 kB)
2. Text File login_patch.txt (1 kB)

Environment: Any

Database: MySQL
URL: http://localhost/~sbourget/moodle19/blocks/mrbs/web/edit_entry.php?area=1&room=1&period=2&year=2008&month=8&day=9
Participants: Anthony Borrow and Stephen Bourget
Security Level: None
Resolved date: 18/Aug/08
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
As reported in http://moodle.org/mod/forum/discuss.php?d=38604#p457138

When addressing a MRBS calendar page directly by the URL, and clicking on the "add bookings" sign, A login form is displayed. This login form does not allow the user to login via moodle.

This behavior can be changed by replacing the entire function printLoginForm($TargetURL) on Line 85 of session_php.php

with this code:

function printLoginForm($TargetURL)
{
    global $PHP_SELF;
   $SESSION->wantsurl = $TargetURL;
   require_login();
}

I've attached a patch.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
arborrow committed 1 file to 'Contrib CVS' - 18/Aug/08 06:49 AM
CONTRIB-665 - use Moodle require login to handle login in session_php file, credit to Stephen Bourget for the patch
MODIFY plugins/blocks/mrbs/web/session_php.php   Rev. 1.6    (+3 -33 lines)
Anthony Borrow added a comment - 18/Aug/08 07:08 AM
Thanks Steve, you make my job really easy! I applied your patch. Peace - Anthony

Anthony Borrow made changes - 18/Aug/08 07:08 AM
Field Original Value New Value
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Anthony Borrow made changes - 18/Aug/08 12:46 PM
Attachment CONTRIB-665.diff [ 14864 ]