|
This patch does the following:
1. It makes a separate file question/type/sojunit/config.php to store the paths, so it is easier to update the rest of the questiontype code without overwriting the paths you have carefully set up in the past. 2. It makes a small change in save_question_options, to fix a notice I was getting when editing existing questions. (I think this may only make a difference on Postgres, but worth having.) 3. Changes the handling of blank responses in grade_responses, to fix the problem with submitting a multi-page quiz before you have been to every page. 4. It comments out the remove_dir($del_temp_folder); that for some reason was causing Submit all and finish to break for all but one question. Obviously this needs to be changed further because the temp files need to be cleaned up somehow. The zip-folder "sojunit 2008_10_10.zip" is the last version of the JUnit-question type for now.
Anthony, is there a way to get this question type into the Moodle Modules and Plugins page? Süreç - Sorry, I got behind on emails and other things. I would be happy to add the code. I'm currently at the GSOC Mentor's summit and see several files. I'm guessing that the sojunit 2008_10_10.zip is the latest and the one that should be uploaded but I don't have time to read the whole thread at the moment and will come back later. Peace - Anthony
moving to QuestionType: Sojunit component
Marking this as resolved. I've uploaded the code to CVS and bumped Süreç Özcan's privileges in the tracker to manage any issues related to the QuestionType: Sojunit component. Just apply for CVS write access at http://moodle.org/cvs
Hi Anthony,
yes, 2008_10_10.zip is the correct one to upload. I have just applied for CVS write access. By doing this, will the question type be listed automatically in the "Moodle Modules and Plugins" page? Thanks for your work! Süreç Süreç - I have approved your CVS access to:
contrib/plugins/question/type/sojunit Just because the code is in CVS does not mean that it is automatically added. In fact there are several steps that I recommend to folks about how to share code. Please take a look at http://docs.moodle.org/en/Development:Guidelines_for_contributed_code Peace - Anthony Hi Anthony,
thanks for your advice above! Finally I have found time to work through the "guidelines for contributed code". While creating a new entry for "Modules and Plugins" it asks me to type in the link for the downloading link (in this case: Download for Moodle 1.9). Which link do I have to type in there? How do I create this link? Can I create a new entry at the moment leaving the download link blank and filling it later? I would appreciate your help, Süreç Hi Anthony,
I have created an entry in Plugins and Modules here: http://moodle.org/mod/data/view.php?rid=2104&page=187 I have created documentation and I think I have managed to link to the zip-file. sojunit.zip is my final version for this question type. Can you put this zip-file into cvs or will I have to go through cvs-configuration for eclipse? Thanks in advance, Süreç - I am glad to hear that you have had an opportunity to read through the Guidelines for Contributed Code. Your question reminds me that I need to explain better how to determine the location of the automatically created zip file for a patch or plugin. The URL you are looking for is:
http://download.moodle.org/download.php/plugins/question/type/sojunit.zip Any changes that you wish to make should be made by changing the files on the CVS server.Then every 24 hours the zip file on Moodle's download server will be updated to incorporate those changes. You may want to try making a small change to the README.txt file just to make sure your CVS access is working correctly. I have approved the M&P entry and updated the download link to include the download.php which simply allows Moodle to collect statistics about the download. The link you had worked fine but was the direct link. Let me know if you have any other questions and thanks for your work on sharing this question type with the Moodle community. Peace - Anthony Hi Anthony,
thanks for your help! So far I have checked out the whole contrib-package from eclipse. I replaced my new junit-folder and wanted to try to commit a changed help-file. Following error was thrown: Do I have to configure ssh in order to commit anything? If yes I wanted to follow the instructions on http://help.eclipse.org/help32/index.jsp?topic=/org.eclipse.platform.doc.user/tasks/tasks-cvs-ssh2.htm Do you know what I could be missing? Greetings, Anthony - Another try today:
I think I have understood a little. When I have changed my developer information it told me to wait for a prove from a developer to take account. I think I have to wait for a commit on my developer information and should try out again. Will I receive an email? If you think there is another reason for not being able to commit, please let me know! Greetings, Süreç OK - I have approved the update and everything looked OK. In terms of your checkout, are you using the cvs.moodle.org server to checkout the code? I just want to make sure you did not get it anonymously from one of the mirrors. You should recieve an email that the update has been approved. So if you could give the commit another shot and let me know what message or error message you receive. Peace - Anthony
Hi Anthony,
yeah - I think it has worked now! I think the last reason it didn't work was being anonymous. At least I can see what I have committed at http://cvs.moodle.org/contrib/plugins/question/type/sojunit/ First I have tried out a readme file and a picture. They seemed to be working so I have replaced the whole sojunit folder with my latest version. Thank you very much for your help! Süreç I noticed your commits and they are working fine. Keep in mind that usually in the commit comment we put a tracker issue number. It may seem like a pain to have to create an issue in the tracker for a fix but unless it really is trivial it is a good way to document things. Most commit comments begin with the tracker number and then that commit gets associated automatically with the issue. Also keep in mind, that with CVS you cannot really delete a file so if you create a file know that there will be a record of it permanently. You can remove it but the old history will still be there. I mention that just so that you are careful about saving files that may or may not be needed. It is one of the disadvantages/features of CVS. Let me know if you need anything else or have any questions. Peace - Anthony
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There have been a number of threads about this question type:
http://moodle.org/mod/forum/discuss.php?d=97086

http://moodle.org/mod/forum/discuss.php?d=102690
where you can see my opinions. In summary, I like it and I think it should be in contrib. However, I have lots of other things to do, so it would be great if you could work with Süreç to make that happen.