Non-core contributed modules

book_chapters->importsrc definition in install.xml looks incorrect...

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.7.2, 1.8.2, 1.9
  • Fix Version/s: 1.7.3, 1.8.3, 1.9
  • Component/s: Module: Book
  • Labels:
    None
  • Environment:
    Any
  • Affected Branches:
    MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE

Description

It seems that the book_chapters->importsrc definition in the install.xml file (all branches since 1.7... I guess) are incorrect. It's defined like integer:

<FIELD NAME="importsrc" TYPE="int" LENGTH="10" NOTNULL="true" UNSIGNED="true" DEFAULT="0" SEQUENCE="false" ENUM="false" PREVIOUS="timemodified"/>

and should be char(255), not signed nor unsigned nor having default value.

I discovered that by causality, when running MDL-11038 in my servers (the new-wrong install.xml definition wasn't coinciding with the phisical DB implementation, created ages ago by old-correct scripts).

Ciao

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Assigning to Petr (I thought he was the default assignee).

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Petr (I thought he was the default assignee).
Hide
Petr Škoda (skodak) added a comment -

Thanks, going to fix that today

Show
Petr Škoda (skodak) added a comment - Thanks, going to fix that today
Hide
Petr Škoda (skodak) added a comment -

fixed long ago

Show
Petr Škoda (skodak) added a comment - fixed long ago

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: