OU Wiki review
=====================
Coding style:
1/ highly non-standard whitespace (grrrrrrrr)
2/ sometimes repeated use of optional_param() apparently without a reason
3/ strange global $CFG, $THEME in global scope
4/ htmlspecialchars() instead of s() and p() (not an issue)
5/ non-standard basicpage.php (similar to Book, invented independently)
6/ not portable sort (might be better to use db sorting) - uasort($groups,create_function('$a,$b','return strcasecmp($a->name,$b->name);'));
7/ ouwiki.php should be imho named locallib.php
8/ lib should not include ouwiki.php - it should be the opposite way - small lib.php and large locallib.php which is loaded only when needed
9/ why not store templates in database?
10/ missing support for tags in wiki activity name
11/ some more DB related code might be moved to locallib.php
Access control:
1/ security problems reported in tracker - several CSRF and one XSS
2/ guest user accound can be allow to edit/comment - we always hardcode extra prevention, real guest accound can never be allowed to post anything other users may see
3/ it might be better to use standard moodle forms
4/ I like that finally somebody did the encoding and specialchars properly - pagename may contain any characters :-D
Database structure:
1/ I like the page history implementation
2/ locking is nice feature
3/ I would expect templates to be stored in database
Missing features:
1/ grading support
2/ support for more text formats - should be implemented directly in core imho
3/ upgrade from Moodle wiki
4/ support for attached files (images at least) - should be easy in 2.0
5/ local wiki search (including history)
New features (possibly suitable for core):
1/ processing of h1,h2, etc. headings in user submitted texts
2/ CSS graphs
3/ some validation in modedit forms (used for groups setup)
4/ simplification of groups setup - yay! this seems much easier to understand
5/ ouwiki reports - interesting UI
OU specific stuff:
1/ transactions
2/ global searching
3/ custom user icon info (jabber)
4/ some exceptions
Task
Closed
Minor
OU Wiki review
=====================
Coding style:
1/ highly non-standard whitespace (grrrrrrrr)
2/ sometimes repeated use of optional_param() apparently without a reason
3/ strange global $CFG, $THEME in global scope
4/ htmlspecialchars() instead of s() and p() (not an issue)
5/ non-standard basicpage.php (similar to Book, invented independently)
6/ not portable sort (might be better to use db sorting) - uasort($groups,create_function('$a,$b','return strcasecmp($a->name,$b->name);'));
7/ ouwiki.php should be imho named locallib.php
8/ lib should not include ouwiki.php - it should be the opposite way - small lib.php and large locallib.php which is loaded only when needed
9/ why not store templates in database?
10/ missing support for tags in wiki activity name
11/ some more DB related code might be moved to locallib.php
Access control:
1/ security problems reported in tracker - several CSRF and one XSS
2/ guest user accound can be allow to edit/comment - we always hardcode extra prevention, real guest accound can never be allowed to post anything other users may see
3/ it might be better to use standard moodle forms
4/ I like that finally somebody did the encoding and specialchars properly - pagename may contain any characters :-D
Database structure:
1/ I like the page history implementation
2/ locking is nice feature
3/ I would expect templates to be stored in database
Missing features:
1/ grading support
2/ support for more text formats - should be implemented directly in core imho
3/ upgrade from Moodle wiki
4/ support for attached files (images at least) - should be easy in 2.0
5/ local wiki search (including history)
New features (possibly suitable for core):
1/ processing of h1,h2, etc. headings in user submitted texts
2/ CSS graphs
3/ some validation in modedit forms (used for groups setup)
4/ simplification of groups setup - yay! this seems much easier to understand
5/ ouwiki reports - interesting UI
OU specific stuff:
1/ transactions
2/ global searching
3/ custom user icon info (jabber)
4/ some exceptions