Non-core contributed modules

Error messages, undefined properties and unexpected behaviour in ILP modules and blocks

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: 1.9.2
  • Fix Version/s: 1.9, 1.9.1, 1.9.2, 1.9.3, 1.9.4, 1.9.5, 1.9.6, 1.9.7, 1.9.8, 1.9.9
  • Component/s: Package: ILP
  • Labels:
    None
  • Environment:
    Windows 2000 service pack 4, Apache 2.2.8, Moodle 1.9+ build 20081007, Postgresql 8.3.4, php 5.2.5 last update of ILP from CVS 9th Oct 2008
  • Database:
    PostgreSQL
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Target and Report overview screens are displaying error messages, totals for targets and reports are not calculating correctly, targets do not appear to be finding their way through to the PLP screen, and the learner test account screen is displaying a number of undefined properties.

I have put together a wink demonstration which I will attach that provides full details of the settings and what is displaying on the various screens.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
James Ballard added a comment -

Thanks Johnathan,

I have updated some of the files, in particular the SQL code. Can you test this again and see if your issues relating to totalling are resolved.

I have also updated the two blocks, which may resolve the views you are seeing.

James

Show
James Ballard added a comment - Thanks Johnathan, I have updated some of the files, in particular the SQL code. Can you test this again and see if your issues relating to totalling are resolved. I have also updated the two blocks, which may resolve the views you are seeing. James
Hide
Permalink
Johnathan Kemp added a comment -

Thank you James for such a quick turn-around.

I have uploaded from CVS and run a few tests with the following results.

1) The following Navigation comments only show when Developer messages are turned on.

print_header() was sent a string as 3rd (jk-temp -> PLP -> Targets) parameter. This is deprecated in favour of an array built by build_navigation(). Please upgrade your code.

  • line 2421 of lib\weblib.php: call to debugging()
  • line 93 of mod\ilptarget\view_students.php: call to print_header()
  • line 111 of mod\ilptarget\view.php: call to include()

Navigation needs to be updated to use build_navigation()

  • line 3623 of lib\weblib.php: call to debugging()
  • line 38 of theme\shareandlearn\header.html: call to print_navigation()
  • line 2630 of lib\weblib.php: call to include()
  • line 93 of mod\ilptarget\view_students.php: call to print_header()
  • line 111 of mod\ilptarget\view.php: call to include()

Navigation needs to be updated to use build_navigation()

  • line 3623 of lib\weblib.php: call to debugging()
  • line 14 of theme\shareandlearn\footer.html: call to print_navigation()
  • line 2974 of lib\weblib.php: call to include()
  • line 682 of mod\ilptarget\view_students.php: call to print_footer()
  • line 111 of mod\ilptarget\view.php: call to include()

2) Error when viewing ilpconcern/view.php (the report screen accessed from the report activity on the course page)

Notice: Undefined variable: report3total in C:\Apache2\htdocs\moodle\mod\ilpconcern\view_students.php on line 511

This error displays above the First Name alphabet selector. Other errors reported in my original posting have now gone.

3) Still no targets showing on the PLP screen or Target drill down.

4) I now have new sections on the PLP for Progress Reviews, Concerns and Comments (between Targets and Personal Reports) however despite there being a Progress review against the student the progress review drill down shows no entries.

5) All undefined property messages are no longer showing on the personal reports screen. However section links on the screen show, in the text that appears at the bottom of the browser when you hover over them, that there are variables undefined.

ilp_student_info/view.php (links for Student Info, Personal Reports, Subject Reports all show undefined variable.)

6) I can confirm that the totals now appear to be calculating correctly.

Kind regards

Johnathan

Show
Johnathan Kemp added a comment - Thank you James for such a quick turn-around. I have uploaded from CVS and run a few tests with the following results. 1) The following Navigation comments only show when Developer messages are turned on. print_header() was sent a string as 3rd (jk-temp -> PLP -> Targets) parameter. This is deprecated in favour of an array built by build_navigation(). Please upgrade your code.
  • line 2421 of lib\weblib.php: call to debugging()
  • line 93 of mod\ilptarget\view_students.php: call to print_header()
  • line 111 of mod\ilptarget\view.php: call to include()
Navigation needs to be updated to use build_navigation()
  • line 3623 of lib\weblib.php: call to debugging()
  • line 38 of theme\shareandlearn\header.html: call to print_navigation()
  • line 2630 of lib\weblib.php: call to include()
  • line 93 of mod\ilptarget\view_students.php: call to print_header()
  • line 111 of mod\ilptarget\view.php: call to include()
Navigation needs to be updated to use build_navigation()
  • line 3623 of lib\weblib.php: call to debugging()
  • line 14 of theme\shareandlearn\footer.html: call to print_navigation()
  • line 2974 of lib\weblib.php: call to include()
  • line 682 of mod\ilptarget\view_students.php: call to print_footer()
  • line 111 of mod\ilptarget\view.php: call to include()
2) Error when viewing ilpconcern/view.php (the report screen accessed from the report activity on the course page) Notice: Undefined variable: report3total in C:\Apache2\htdocs\moodle\mod\ilpconcern\view_students.php on line 511 This error displays above the First Name alphabet selector. Other errors reported in my original posting have now gone. 3) Still no targets showing on the PLP screen or Target drill down. 4) I now have new sections on the PLP for Progress Reviews, Concerns and Comments (between Targets and Personal Reports) however despite there being a Progress review against the student the progress review drill down shows no entries. 5) All undefined property messages are no longer showing on the personal reports screen. However section links on the screen show, in the text that appears at the bottom of the browser when you hover over them, that there are variables undefined. ilp_student_info/view.php (links for Student Info, Personal Reports, Subject Reports all show undefined variable.) 6) I can confirm that the totals now appear to be calculating correctly. Kind regards Johnathan
Hide
Permalink
James Ballard added a comment -

I believe 2, 5, and 6 are resolved.

I have created separate sub-tasks for the others to report in more detail there.

3&4 are the same issue but in different modules relating to posts not showing sub-task. Can you try these again as well as I have made a few tweaks.

1 is separate and related to headers and is considered less crucial - it will not affect a live site from working with debugging off but still needs resolving.

Show
James Ballard added a comment - I believe 2, 5, and 6 are resolved. I have created separate sub-tasks for the others to report in more detail there. 3&4 are the same issue but in different modules relating to posts not showing sub-task. Can you try these again as well as I have made a few tweaks. 1 is separate and related to headers and is considered less crucial - it will not affect a live site from working with debugging off but still needs resolving.
Hide
Permalink
Johnathan Kemp added a comment -

Hello James,

Please read the detail below as you may feel that this clears up the issues about 3 and 4

2) I can confirm 2 is resolved.

3 & 4) Since my last posting I have used a teacher account to add a target and a concern to the students plp. I have also used the student account to add a target to their plp.

In ILPtarget/view.php accessed using the teacher account, the targets added by the student and the teacher to the PLP are included in the total calculation, but are not listed when you click on the "1/6 complete" link.

Similarly in the ILPconcern/view.php accessed using the teacher account, the concern added to the students PLP is included in the total for concerns, however again when you click on the link "1 Concerns" the concern is not shown.

When the teacher account is used to open the students PLP ilp/view.php only the Targets and Concerns added to the PLP are shown, none of the Targets or Reports added via a course activity are shown.

However if I change the settings in Target and Report (ilpTarget_course_specific and ilpConcern_course_specific) both to NO then activity entered targets and reports appear in the PLP and PLP entered targets and reports appear in the activity lists. So this last issue may be down to a failure on my part to understand exactly how you were intending this module to operate. Whether you want the Activity based totals to include items from the PLP when the course_specific flags are set to Yes is something you may wish to consider, as it can be misleading to see a value of Concerns 1 only to find nothing listed when you drill down.

5) The links for Personal Reports and Subject Reports on the ilp_student_info/view.php page no longer display any link information, so the reference to undefined variables is no longer displayed.

On the matter of Personal Reports I have yet to discover how anything is added to this section.

6) Is resolved - totals for targets and reports are now calculating. Note the point made above about them still including PLP entered items when course specific flags are set to Yes.

Kind regards

Johnathan

Show
Johnathan Kemp added a comment - Hello James, Please read the detail below as you may feel that this clears up the issues about 3 and 4 2) I can confirm 2 is resolved. 3 & 4) Since my last posting I have used a teacher account to add a target and a concern to the students plp. I have also used the student account to add a target to their plp. In ILPtarget/view.php accessed using the teacher account, the targets added by the student and the teacher to the PLP are included in the total calculation, but are not listed when you click on the "1/6 complete" link. Similarly in the ILPconcern/view.php accessed using the teacher account, the concern added to the students PLP is included in the total for concerns, however again when you click on the link "1 Concerns" the concern is not shown. When the teacher account is used to open the students PLP ilp/view.php only the Targets and Concerns added to the PLP are shown, none of the Targets or Reports added via a course activity are shown. However if I change the settings in Target and Report (ilpTarget_course_specific and ilpConcern_course_specific) both to NO then activity entered targets and reports appear in the PLP and PLP entered targets and reports appear in the activity lists. So this last issue may be down to a failure on my part to understand exactly how you were intending this module to operate. Whether you want the Activity based totals to include items from the PLP when the course_specific flags are set to Yes is something you may wish to consider, as it can be misleading to see a value of Concerns 1 only to find nothing listed when you drill down. 5) The links for Personal Reports and Subject Reports on the ilp_student_info/view.php page no longer display any link information, so the reference to undefined variables is no longer displayed. On the matter of Personal Reports I have yet to discover how anything is added to this section. 6) Is resolved - totals for targets and reports are now calculating. Note the point made above about them still including PLP entered items when course specific flags are set to Yes. Kind regards Johnathan
Hide
Permalink
James Ballard added a comment -

Thanks Jonathan,

Everything is clearer now. If you limit it to be course specific then only targets and reports from that course should be included, but the calculations for summary totals are ignoring this. This can be easily resolved although I am away for a few days now so will pick up on my return.

Please see the discussion in the ILP forums for the user context. Try going into a student's user profile and use the roles tab at the far-right. Add yourself in the teacher role within this user context. Now add the PLP block to the home page of your site and use it. You should see a list of students as well as courses. This will not work from within a course as that is the course context.

Show
James Ballard added a comment - Thanks Jonathan, Everything is clearer now. If you limit it to be course specific then only targets and reports from that course should be included, but the calculations for summary totals are ignoring this. This can be easily resolved although I am away for a few days now so will pick up on my return. Please see the discussion in the ILP forums for the user context. Try going into a student's user profile and use the roles tab at the far-right. Add yourself in the teacher role within this user context. Now add the PLP block to the home page of your site and use it. You should see a list of students as well as courses. This will not work from within a course as that is the course context.
Hide
Permalink
Johnathan Kemp added a comment -

Hello James,

I will look in to this further.

I did what you suggested. With my admin account I opened the learner user account and assigned the teacher account the role of teacher to the learner account. I then added the plp block to the home page. When I logged on using my teacher account and looked at the home page the PLP block was listed.

When I clicked on the "PLPs" link, the PLP screen ilp/list.php opened and the message

Notice: Undefined variable: access_isteacher in C:\Apache2\htdocs\moodle\blocks\ilp\list.php on line 125

was displayed, followed by the Mentee list, which listed the learner account as a mentee, and Courses list.

On clicking on the link for the learner account I can see that the facility to add a personal report is now available.

This is all coming together - thanks again for all your help.

Kind regards

Johnathan

Show
Johnathan Kemp added a comment - Hello James, I will look in to this further. I did what you suggested. With my admin account I opened the learner user account and assigned the teacher account the role of teacher to the learner account. I then added the plp block to the home page. When I logged on using my teacher account and looked at the home page the PLP block was listed. When I clicked on the "PLPs" link, the PLP screen ilp/list.php opened and the message Notice: Undefined variable: access_isteacher in C:\Apache2\htdocs\moodle\blocks\ilp\list.php on line 125 was displayed, followed by the Mentee list, which listed the learner account as a mentee, and Courses list. On clicking on the link for the learner account I can see that the facility to add a personal report is now available. This is all coming together - thanks again for all your help. Kind regards Johnathan
Hide
Permalink
James Ballard added a comment -

I believe this is resolved - latest version does not produce error reports and a number of displays have been rewritten

Show
James Ballard added a comment - I believe this is resolved - latest version does not produce error reports and a number of displays have been rewritten

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.