Issue Details (XML | Word | Printable)

Key: CONTRIB-775
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Nicolas Connault
Reporter: Nicolas Connault
Votes: 0
Watchers: 6
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Non-core contributed modules

Gradebook: New "Edit categories and items" interface

Created: 15/Oct/08 05:07 PM   Updated: 23/Feb/09 03:28 PM
Return to search
Component/s: Gradebook Patches/Plugins/Upgrades
Affects Version/s: 1.9.3, 2.0
Fix Version/s: 1.9.4

Issue Links:
Dependency
 

Participants: Anthony Borrow, James Rudd, Lael..., Martin Dougiamas and Nicolas Connault
Security Level: None
Resolved date: 05/Nov/08
Affected Branches: MOODLE_19_STABLE, MOODLE_20_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
See MDL-15680

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nicolas Connault committed 18 files to 'Contrib CVS' - 15/Oct/08 05:08 PM
CONTRIB-775
ADD plugins/grade/edit/tree/README   Rev. 1.1    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/lp.gif   Rev. 1.1    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/lmh.gif   Rev. 1.1    (+0 -0 lines)
ADD plugins/grade/edit/tree/TODO   Rev. 1.1    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/tp.gif   Rev. 1.1    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/tn.gif   Rev. 1.1    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/loading.gif   Rev. 1.1    (+0 -0 lines)
ADD plugins/grade/edit/tree/lib.php   Rev. 1.1    (+0 -0 lines)
ADD plugins/grade/edit/tree/index.php   Rev. 1.1    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/lph.gif   Rev. 1.1    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/ln.gif   Rev. 1.1    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/vline.gif   Rev. 1.1    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/tph.gif   Rev. 1.1    (+0 -0 lines)
ADD plugins/grade/edit/tree/tree.css   Rev. 1.1    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/tmh.gif   Rev. 1.1    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/lm.gif   Rev. 1.1    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/tm.gif   Rev. 1.1    (+0 -0 lines)
ADD plugins/grade/edit/tree/ajax.php   Rev. 1.1    (+0 -0 lines)
Nicolas Connault committed 18 files to 'Contrib CVS' on branch 'MOODLE_19_STABLE' - 15/Oct/08 05:09 PM
CONTRIB-775
MODIFY plugins/grade/edit/tree/index.php   Rev. 1.1.2.2    (+293 -0 lines)
MODIFY plugins/grade/edit/tree/img/tp.gif   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/lm.gif   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/tn.gif   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/tmh.gif   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/lmh.gif   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/tm.gif   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/TODO   Rev. 1.1.2.2    (+10 -0 lines)
MODIFY plugins/grade/edit/tree/img/vline.gif   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/README   Rev. 1.1.2.2    (+6 -0 lines)
MODIFY plugins/grade/edit/tree/img/ln.gif   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/lib.php   Rev. 1.1.2.2    (+315 -0 lines)
MODIFY plugins/grade/edit/tree/img/lp.gif   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/tree.css   Rev. 1.1.2.2    (+56 -0 lines)
MODIFY plugins/grade/edit/tree/ajax.php   Rev. 1.1.2.2    (+71 -0 lines)
MODIFY plugins/grade/edit/tree/img/lph.gif   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/loading.gif   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY plugins/grade/edit/tree/img/tph.gif   Rev. 1.1.2.2    (+0 -0 lines)
Nicolas Connault committed 1 file to 'Contrib CVS' on branch 'MOODLE_19_STABLE' - 15/Oct/08 05:28 PM
CONTRIB-775 Added missing comma in get_records call
MODIFY plugins/grade/edit/tree/index.php   Rev. 1.1.2.3    (+2 -2 lines)
[ Permalink | « Hide ]
Anthony Borrow added a comment - 15/Oct/08 10:44 PM
Nicolas - The README file indicates that this is a replacement for something in core which makes me think it is really a patch and not a plugin (something which is a modular addition that does not modify core code). It also looks like the code for this is in CVS for Moodle 2.0. Does that sound correct? Peace - Anthony

Nicolas Connault committed 4 files to 'Contrib CVS' on branch 'MOODLE_19_STABLE' - 15/Oct/08 11:03 PM
CONTRIB-775 Completed the following:
* Use format_float on the floats to remove trailing zeros (or see how grader report does it)
* Refactor recursive tree-building functions
* Move "Show/Hide advanced columns" button to top right
* Save Show/Hide columns preference in session
* Change text of submit button to "Save changes" and center it under the table
* Do not print the form when advanced columns are hidden: no form fields
MODIFY plugins/grade/edit/tree/index.php   Rev. 1.1.2.4    (+61 -27 lines)
MODIFY plugins/grade/edit/tree/lib.php   Rev. 1.1.2.3    (+35 -58 lines)
MODIFY plugins/grade/edit/tree/tree.css   Rev. 1.1.2.3    (+9 -1 lines)
MODIFY plugins/grade/edit/tree/TODO   Rev. 1.1.2.3    (+9 -6 lines)
[ Permalink | « Hide ]
Nicolas Connault added a comment - 15/Oct/08 11:07 PM
OK Anthony I will move this to patches. The code for HEAD is in the HEAD branch of contrib, while the code for 1.9 is in the MOODLE_19_STABLE branch.

Nicolas Connault committed 17 files to 'Contrib CVS' - 15/Oct/08 11:21 PM
CONTRIB-775 Moving from plugins to patches
DEL plugins/grade/edit/tree/img/tmh.gif   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/img/lp.gif   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/img/loading.gif   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/img/tph.gif   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/lib.php   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/img/lmh.gif   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/TODO   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/img/tm.gif   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/img/lph.gif   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/img/ln.gif   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/tree.css   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/README   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/index.php   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/img/tn.gif   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/img/lm.gif   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/img/tp.gif   Rev. 1.2    (+0 -0 lines)
DEL plugins/grade/edit/tree/img/vline.gif   Rev. 1.2    (+0 -0 lines)
Nicolas Connault committed 8 files to 'Contrib CVS' on branch 'MOODLE_19_STABLE' - 15/Oct/08 11:22 PM
CONTRIB-775 Moving from plugins to patches
MODIFY patches/grade/edit/tree/img/Attic/lph.gif   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/loading.gif   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/lm.gif   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/tph.gif   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/tmh.gif   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/tm.gif   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/lp.gif   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/ln.gif   Rev. 1.1.2.1    (+0 -0 lines)
Nicolas Connault committed 1 file to 'Contrib CVS' - 15/Oct/08 11:22 PM
CONTRIB-775 Moving from plugins to patches
DEL plugins/grade/edit/tree/ajax.php   Rev. 1.2    (+0 -0 lines)
Nicolas Connault committed 10 files to 'Contrib CVS' on branch 'MOODLE_19_STABLE' - 15/Oct/08 11:22 PM
CONTRIB-775 Moving from plugins to patches
MODIFY patches/grade/edit/tree/Attic/tree.css   Rev. 1.1.2.1    (+64 -0 lines)
MODIFY patches/grade/edit/tree/Attic/ajax.php   Rev. 1.1.2.1    (+71 -0 lines)
MODIFY patches/grade/edit/tree/Attic/README   Rev. 1.1.2.1    (+6 -0 lines)
MODIFY patches/grade/edit/tree/Attic/TODO   Rev. 1.1.2.1    (+13 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/tp.gif   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/tn.gif   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/lmh.gif   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY patches/grade/edit/tree/Attic/index.php   Rev. 1.1.2.1    (+327 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/vline.gif   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY patches/grade/edit/tree/Attic/lib.php   Rev. 1.1.2.1    (+292 -0 lines)
[ Permalink | « Hide ]
Nicolas Connault added a comment - 15/Oct/08 11:22 PM
Moved to patches

Nicolas Connault committed 18 files to 'Contrib CVS' - 15/Oct/08 11:32 PM
CONTRIB-775 Moved from plugins to patches
MODIFY patches/grade/edit/tree/img/Attic/lmh.gif   Rev. 1.2    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/loading.gif   Rev. 1.2    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/tmh.gif   Rev. 1.2    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/ln.gif   Rev. 1.2    (+0 -0 lines)
MODIFY patches/grade/edit/tree/Attic/lib.php   Rev. 1.2    (+292 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/tn.gif   Rev. 1.2    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/vline.gif   Rev. 1.2    (+0 -0 lines)
MODIFY patches/grade/edit/tree/Attic/index.php   Rev. 1.2    (+327 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/tph.gif   Rev. 1.2    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/lm.gif   Rev. 1.2    (+0 -0 lines)
MODIFY patches/grade/edit/tree/Attic/README   Rev. 1.2    (+6 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/lp.gif   Rev. 1.2    (+0 -0 lines)
MODIFY patches/grade/edit/tree/Attic/tree.css   Rev. 1.2    (+65 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/lph.gif   Rev. 1.2    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/tp.gif   Rev. 1.2    (+0 -0 lines)
MODIFY patches/grade/edit/tree/img/Attic/tm.gif   Rev. 1.2    (+0 -0 lines)
MODIFY patches/grade/edit/tree/Attic/TODO   Rev. 1.2    (+13 -0 lines)
MODIFY patches/grade/edit/tree/Attic/ajax.php   Rev. 1.2    (+71 -0 lines)
Nicolas Connault committed 4 files to 'Contrib CVS' on branch 'MOODLE_19_STABLE' - 17/Oct/08 05:20 PM
CONTRIB-775 Implemented bulk moving of grade items to categories
MODIFY patches/grade/edit/tree/Attic/lib.php   Rev. 1.1.2.2    (+70 -16 lines)
MODIFY patches/grade/edit/tree/Attic/functions.js   Rev. 1.1.2.1    (+28 -0 lines)
MODIFY patches/grade/edit/tree/Attic/tree.css   Rev. 1.1.2.2    (+9 -0 lines)
MODIFY patches/grade/edit/tree/Attic/index.php   Rev. 1.1.2.2    (+38 -28 lines)
Nicolas Connault committed 3 files to 'Contrib CVS' - 17/Oct/08 05:27 PM
CONTRIB-775 Implemented bulk moving of grade items to categories. Merged from MOODLE_19_STABLE
MODIFY patches/grade/edit/tree/Attic/functions.js   Rev. 1.2    (+28 -0 lines)
MODIFY patches/grade/edit/tree/Attic/lib.php   Rev. 1.3    (+70 -16 lines)
MODIFY patches/grade/edit/tree/Attic/index.php   Rev. 1.3    (+37 -28 lines)
Nicolas Connault made changes - 17/Oct/08 05:30 PM
Field Original Value New Value
Summary Gradebook: Assign weights to all categories and items on one screen Gradebook: New "Edit categories and items" interface
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 04/Nov/08 05:26 PM
Sorry Anthony and Nicolas, but this really is a full plugin. The fact that it overwrites the standard one is not the issue. It was in plugins so that the download site can package it and make it easy for people to try it out.

http://download.moodle.org/plugins19/

The patches directory is flat:

http://download.moodle.org/patches/

More info here: http://cvs.moodle.org/contrib/README.txt?revision=1.9&view=markup


moodler committed 19 files to 'Contrib CVS' - 05/Nov/08 10:11 AM
CONTRIB-775 Moving new grade/edit/tree plugin to correct location in plugins
ADD plugins/grade/edit/tree/ajax.php   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/lib.php   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/tree.css   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/img/tp.gif   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/img/tm.gif   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/img/ln.gif   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/img/tn.gif   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/img/tmh.gif   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/img/vline.gif   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/TODO   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/img/lp.gif   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/img/loading.gif   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/img/lmh.gif   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/img/lm.gif   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/index.php   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/img/lph.gif   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/functions.js   Rev. 1.1    (+0 -0 lines)
ADD plugins/grade/edit/tree/img/tph.gif   Rev. 1.3    (+0 -0 lines)
ADD plugins/grade/edit/tree/README   Rev. 1.3    (+0 -0 lines)
moodler committed 3 files to 'Contrib CVS' on branch 'MOODLE_19_STABLE' - 05/Nov/08 10:16 AM
CONTRIB-775 Moved 1.9 version of grade/edit/tree back to plugins as well
MODIFY plugins/grade/edit/tree/lib.php   Rev. 1.1.2.4    (+70 -16 lines)
MODIFY plugins/grade/edit/tree/index.php   Rev. 1.1.2.5    (+38 -28 lines)
MODIFY plugins/grade/edit/tree/tree.css   Rev. 1.1.2.4    (+9 -0 lines)
moodler committed 1 file to 'Contrib CVS' on branch 'MOODLE_19_STABLE' - 05/Nov/08 10:17 AM
CONTRIB-775 new file for 1.9
MODIFY plugins/grade/edit/tree/functions.js   Rev. 1.1.2.2    (+28 -0 lines)
moodler committed 19 files to 'Contrib CVS' on branch 'MOODLE_19_STABLE' - 05/Nov/08 10:18 AM
CONTRIB-775 Removing grade/edit/tree plugin from patches directory
DEL patches/grade/edit/tree/Attic/README   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/lp.gif   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/ln.gif   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/tmh.gif   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/tp.gif   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/tree.css   Rev. 1.1.2.3    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/ajax.php   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/lm.gif   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/tph.gif   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/loading.gif   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/index.php   Rev. 1.1.2.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/vline.gif   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/tm.gif   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/functions.js   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/lib.php   Rev. 1.1.2.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/tn.gif   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/TODO   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/lmh.gif   Rev. 1.1.2.2    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/lph.gif   Rev. 1.1.2.2    (+0 -0 lines)
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 05/Nov/08 10:20 AM
I moved it myself just now: http://cvs.moodle.org/contrib/plugins/grade/edit/tree/

The plugins should be built soon.

http://download.moodle.org/plugins19/grade/edit/tree.zip (MOODLE_19_STABLE)
http://download.moodle.org/plugins/grade/edit/tree.zip (HEAD)


Martin Dougiamas made changes - 05/Nov/08 10:20 AM
Fix Version/s 1.9.4 [ 10312 ]
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Assignee Nicolas Connault [ nicolasconnault ] Martin Dougiamas [ dougiamas ]
moodler committed 19 files to 'Contrib CVS' - 05/Nov/08 10:30 AM
CONTRIB-775 removing patches dir
DEL patches/grade/edit/tree/img/Attic/lmh.gif   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/tmh.gif   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/loading.gif   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/tp.gif   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/lph.gif   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/vline.gif   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/tm.gif   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/tree.css   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/lm.gif   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/ajax.php   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/functions.js   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/ln.gif   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/TODO   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/tph.gif   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/README   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/lp.gif   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/img/Attic/tn.gif   Rev. 1.3    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/index.php   Rev. 1.4    (+0 -0 lines)
DEL patches/grade/edit/tree/Attic/lib.php   Rev. 1.4    (+0 -0 lines)
[ Permalink | « Hide ]
James Rudd added a comment - 19/Nov/08 08:55 AM - edited
I applied the latest http://download.moodle.org/plugins19/grade/edit/tree.zip files to my Moodle 1.9.3 installation and experienced a few small cosmetic problems:

At top of page:
Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /srv/htdocs/grade/edit/tree/index.php on line 291

And it was missing text for a few headings:
[[showadvancedcolumns]]
[[hideadvancedcolumns]]
[[weightorextracredit]]
[[moveselectedto]]

I am running Apache 2.2.3, PHP 5.2.5 and MySQL 5.0.26


[ Permalink | « Hide ]
Martin Dougiamas added a comment - 19/Nov/08 10:01 AM
Nicolas can you look into these? (the first one is because of PHP4)

Martin Dougiamas made changes - 19/Nov/08 10:01 AM
Assignee Martin Dougiamas [ dougiamas ] Nicolas Connault [ nicolasconnault ]
[ Permalink | « Hide ]
Nicolas Connault added a comment - 21/Nov/08 12:05 AM - edited
Never mind...

[ Permalink | « Hide ]
Anthony Borrow added a comment - 21/Nov/08 12:23 AM
Nicolas - Sounds like you were dealing with the same branch from patches being copied over into HEAD and 19STABLE in plugins. Glad you were able to sort things out. Peace - Anthony

Nicolas Connault committed 1 file to 'Contrib CVS' - 21/Nov/08 12:38 AM
CONTRIB-775 Now showing category totals grade items
MODIFY plugins/grade/edit/tree/index.php   Rev. 1.4    (+8 -8 lines)
Nicolas Connault committed 2 files to 'Contrib CVS' on branch 'MOODLE_19_STABLE' - 08/Jan/09 06:12 PM
CONTRIB-775 Removed pass by reference (3 occurrences)
MODIFY plugins/grade/edit/tree/index.php   Rev. 1.1.2.6    (+13 -6 lines)
MODIFY plugins/grade/edit/tree/lib.php   Rev. 1.1.2.5    (+29 -17 lines)
Nicolas Connault committed 2 files to 'Contrib CVS' - 08/Jan/09 06:13 PM
CONTRIB-775 Fixed indenting of move targets and fixed moving of categories and items. Merging from MOODLE_19_STABLE
MODIFY plugins/grade/edit/tree/index.php   Rev. 1.6    (+2 -2 lines)
MODIFY plugins/grade/edit/tree/lib.php   Rev. 1.5    (+1 -1 lines)
Nicolas Connault committed 2 files to 'Contrib CVS' on branch 'MOODLE_19_STABLE' - 08/Jan/09 07:40 PM
CONTRIB-775 Improved the bulk moving drop-down, reduced redirection delay to 0 and prevented error messages from printing when a category is stripped of all its grade items and the regrading script tries to compute its total
MODIFY plugins/grade/edit/tree/index.php   Rev. 1.1.2.7    (+14 -4 lines)
MODIFY plugins/grade/edit/tree/lib.php   Rev. 1.1.2.6    (+7 -1 lines)
Nicolas Connault committed 2 files to 'Contrib CVS' - 08/Jan/09 07:45 PM
CONTRIB-775 Improved the bulk moving drop-down, reduced redirection delay to 0 and prevented error messages from printing when a category is stripped of all its grade items and the regrading script tries to compute its total. Merging from MOODLE_19_STABLE
MODIFY plugins/grade/edit/tree/lib.php   Rev. 1.6    (+8 -2 lines)
MODIFY plugins/grade/edit/tree/index.php   Rev. 1.7    (+16 -5 lines)
Nicolas Connault committed 3 files to 'Contrib CVS' on branch 'MOODLE_19_STABLE' - 16/Jan/09 11:30 PM
CONTRIB-775 Completely refactored for better coding flexibility. Implemented color scheme and removed dependence on images
MODIFY plugins/grade/edit/tree/tree.css   Rev. 1.1.2.5    (+67 -7 lines)
MODIFY plugins/grade/edit/tree/lib.php   Rev. 1.1.2.7    (+799 -241 lines)
MODIFY plugins/grade/edit/tree/index.php   Rev. 1.1.2.8    (+7 -6 lines)
Nicolas Connault committed 3 files to 'Contrib CVS' - 16/Jan/09 11:30 PM
CONTRIB-775 Completely refactored for better coding flexibility. Implemented color scheme and removed dependence on images. Merged from MOODLE_19_STABLE
MODIFY plugins/grade/edit/tree/index.php   Rev. 1.8    (+9 -9 lines)
MODIFY plugins/grade/edit/tree/lib.php   Rev. 1.7    (+800 -242 lines)
MODIFY plugins/grade/edit/tree/tree.css   Rev. 1.5    (+86 -26 lines)
Nicolas Connault made changes - 16/Jan/09 11:31 PM
Link This issue will help resolve MDL-15680 [ MDL-15680 ]
[ Permalink | « Hide ]
Nicolas Connault added a comment - 16/Jan/09 11:34 PM
Large refactoring, now using an OO pattern for easily adding highly configurable columns to the report. Also added a coloured filler table cell scheme for easily identifying grade categories.

[ Permalink | « Hide ]
Lael... added a comment - 23/Feb/09 02:39 PM
After applying the grade tree plugin, I've found that the only place to change the category grade item is by going to the grader report and then turning editing on, then clicking the edit icon for the grade item at the top of the column for each category.

Would it be possible to include the edit icon for the grade item in the Edit Categories and Items report?

The way it is at the moment makes it more difficult to edit the way the grade is displayed, as well as the name displayed for each category item. I think when setting up the categories, it is often done from the 'Edit Categories and Items' screen - as well as being faster as there is less data to load than on the the grader report.

Thanks - this and the user report patch are excellent!


[ Permalink | « Hide ]
Nicolas Connault added a comment - 23/Feb/09 03:28 PM
Lael, the grade tree plugin is out of date now. There are many improvements in the making for 1.9.5, including this new interface. Another improvement involves moving all category related settings into the grade category edit page. There will be no more category item edit page. This actually makes it easier to find these settings.


Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators