Issue Details (XML | Word | Printable)

Key: CONTRIB-775
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Nicolas Connault
Reporter: Nicolas Connault
Votes: 0
Watchers: 6
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Non-core contributed modules

Gradebook: New "Edit categories and items" interface

Created: 15/Oct/08 05:07 PM   Updated: 23/Feb/09 03:28 PM
Component/s: Gradebook Patches/Plugins/Upgrades
Affects Version/s: 1.9.3, 2.0
Fix Version/s: 1.9.4

Issue Links:
Dependency
 

Participants: Anthony Borrow, James Rudd, Lael..., Martin Dougiamas and Nicolas Connault
Security Level: None
Resolved date: 05/Nov/08
Affected Branches: MOODLE_19_STABLE, MOODLE_20_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
See MDL-15680

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Anthony Borrow added a comment - 15/Oct/08 10:44 PM
Nicolas - The README file indicates that this is a replacement for something in core which makes me think it is really a patch and not a plugin (something which is a modular addition that does not modify core code). It also looks like the code for this is in CVS for Moodle 2.0. Does that sound correct? Peace - Anthony

Nicolas Connault added a comment - 15/Oct/08 11:07 PM
OK Anthony I will move this to patches. The code for HEAD is in the HEAD branch of contrib, while the code for 1.9 is in the MOODLE_19_STABLE branch.

Nicolas Connault added a comment - 15/Oct/08 11:22 PM
Moved to patches

Martin Dougiamas added a comment - 04/Nov/08 05:26 PM
Sorry Anthony and Nicolas, but this really is a full plugin. The fact that it overwrites the standard one is not the issue. It was in plugins so that the download site can package it and make it easy for people to try it out.

http://download.moodle.org/plugins19/

The patches directory is flat:

http://download.moodle.org/patches/

More info here: http://cvs.moodle.org/contrib/README.txt?revision=1.9&view=markup


Martin Dougiamas added a comment - 05/Nov/08 10:20 AM

James Rudd added a comment - 19/Nov/08 08:55 AM - edited
I applied the latest http://download.moodle.org/plugins19/grade/edit/tree.zip files to my Moodle 1.9.3 installation and experienced a few small cosmetic problems:

At top of page:
Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /srv/htdocs/grade/edit/tree/index.php on line 291

And it was missing text for a few headings:
[[showadvancedcolumns]]
[[hideadvancedcolumns]]
[[weightorextracredit]]
[[moveselectedto]]

I am running Apache 2.2.3, PHP 5.2.5 and MySQL 5.0.26


Martin Dougiamas added a comment - 19/Nov/08 10:01 AM
Nicolas can you look into these? (the first one is because of PHP4)

Nicolas Connault added a comment - 21/Nov/08 12:05 AM - edited
Never mind...

Anthony Borrow added a comment - 21/Nov/08 12:23 AM
Nicolas - Sounds like you were dealing with the same branch from patches being copied over into HEAD and 19STABLE in plugins. Glad you were able to sort things out. Peace - Anthony

Nicolas Connault added a comment - 16/Jan/09 11:34 PM
Large refactoring, now using an OO pattern for easily adding highly configurable columns to the report. Also added a coloured filler table cell scheme for easily identifying grade categories.

Lael... added a comment - 23/Feb/09 02:39 PM
After applying the grade tree plugin, I've found that the only place to change the category grade item is by going to the grader report and then turning editing on, then clicking the edit icon for the grade item at the top of the column for each category.

Would it be possible to include the edit icon for the grade item in the Edit Categories and Items report?

The way it is at the moment makes it more difficult to edit the way the grade is displayed, as well as the name displayed for each category item. I think when setting up the categories, it is often done from the 'Edit Categories and Items' screen - as well as being faster as there is less data to load than on the the grader report.

Thanks - this and the user report patch are excellent!


Nicolas Connault added a comment - 23/Feb/09 03:28 PM
Lael, the grade tree plugin is out of date now. There are many improvements in the making for 1.9.5, including this new interface. Another improvement involves moving all category related settings into the grade category edit page. There will be no more category item edit page. This actually makes it easier to find these settings.