Non-core contributed modules

Block: File Sharing

Details

  • Type: New Feature New Feature
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.7, 1.7.1, 1.7.2, 1.7.3, 1.7.4, 1.8, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.8.5, 1.8.6, 1.8.7, 1.9, 1.9.1, 1.9.2, 1.9.3
  • Fix Version/s: None
  • Component/s: Add a project here
  • Labels:
    None
  • Environment:
    ALL
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE

Description

file sharing block

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

Amr - I see that this is an enhanced block and from the readme.txt file it looks like it is something you've worked on improving. Does this have any relationship to the My Files block? I'm just trying to understand the relationship of this code to other projects. Thanks - Anthony

Show
Anthony Borrow added a comment - Amr - I see that this is an enhanced block and from the readme.txt file it looks like it is something you've worked on improving. Does this have any relationship to the My Files block? I'm just trying to understand the relationship of this code to other projects. Thanks - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I am remembering a while back having some correspondence with someone who had done some work getting file_manager or my files working for Moodle 1.8 or 1.9. As I recall they were doing the work in Hong Kong. In any case, it would be good to know what makes this code distinctive from that other code. Would it be better to merge this with that code? Thanks for your help in helping me to understand the history of this project. Peace - Anthony

Show
Anthony Borrow added a comment - I am remembering a while back having some correspondence with someone who had done some work getting file_manager or my files working for Moodle 1.8 or 1.9. As I recall they were doing the work in Hong Kong. In any case, it would be good to know what makes this code distinctive from that other code. Would it be better to merge this with that code? Thanks for your help in helping me to understand the history of this project. Peace - Anthony
Hide
Permalink
Amr Hourani added a comment - - edited

yes anthony, it is based on my files block, as for this new code, am not sure if it is same to hong kong guys or not, I dont think I even saw their block,
this blocklately got some enhancement from someone living in motreal, such as adding language package and so.

it doesnt matter if you merge or make it distinctive.. your call.

Show
Amr Hourani added a comment - - edited yes anthony, it is based on my files block, as for this new code, am not sure if it is same to hong kong guys or not, I dont think I even saw their block, this blocklately got some enhancement from someone living in motreal, such as adding language package and so. it doesnt matter if you merge or make it distinctive.. your call.
Hide
Permalink
Anthony Borrow added a comment -

Amr - I believe Michael Penney and crew were instrumental in designing and contributing the code but I do not believe that they are currently involved in maintaining it. I'm going to try and generate a diff file at least for the 1.9 version between what you have submitted and what is in the file_manager branch and what you have submitted. David Tong worked on getting the block working for 1.8 and may do some minor work on that branch. I think if you took over the 1.9 branch and HEAD branches that would be ideal. I've sent Moodle messages to both Michael Penney and David Tong to get any input they might have. I think we would do better not forking the block and merging it with what is there and working collaboratively on it. Peace - Anthony

Show
Anthony Borrow added a comment - Amr - I believe Michael Penney and crew were instrumental in designing and contributing the code but I do not believe that they are currently involved in maintaining it. I'm going to try and generate a diff file at least for the 1.9 version between what you have submitted and what is in the file_manager branch and what you have submitted. David Tong worked on getting the block working for 1.8 and may do some minor work on that branch. I think if you took over the 1.9 branch and HEAD branches that would be ideal. I've sent Moodle messages to both Michael Penney and David Tong to get any input they might have. I think we would do better not forking the block and merging it with what is there and working collaboratively on it. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Amr - Sorry for the delay on this. I have added the file_manager block to your list of areas on CVS where you have write access. I'm also going to list you as the primary maintainer since David and Michael are both involved with other projects. I would suggest that the code you have for Moodle 1.9 update what is in the MOODLE_19_STABLE branch and HEAD. That will leave David's work for Moodle 1.8 available for folks as part of the MOODLE_18_STABLE branch and the earlier branch for the work done by Michael at Moodlerooms.com. Let me know if you have any questions. I hope you are doing well and keeping busy. Peace - Anthony

Show
Anthony Borrow added a comment - Amr - Sorry for the delay on this. I have added the file_manager block to your list of areas on CVS where you have write access. I'm also going to list you as the primary maintainer since David and Michael are both involved with other projects. I would suggest that the code you have for Moodle 1.9 update what is in the MOODLE_19_STABLE branch and HEAD. That will leave David's work for Moodle 1.8 available for folks as part of the MOODLE_18_STABLE branch and the earlier branch for the work done by Michael at Moodlerooms.com. Let me know if you have any questions. I hope you are doing well and keeping busy. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Amr - I am going to assign this to you so that you can close it once you have a chance to update the code in the MOODLE_19_STABLE and HEAD branches. Thanks for your patience as I fell behind with classes and your help in maintaining this block. Let me know if I can be of help in any way. Peace - Anthony

Show
Anthony Borrow added a comment - Amr - I am going to assign this to you so that you can close it once you have a chance to update the code in the MOODLE_19_STABLE and HEAD branches. Thanks for your patience as I fell behind with classes and your help in maintaining this block. Let me know if I can be of help in any way. Peace - Anthony
Hide
Permalink
Dan Marsden added a comment -

Hi Amr,

I've just pushed your patch into contrib cvs into 19_STABLE and HEAD - I've got a few other patches to go in as well! - thanks heaps!

Dan

Show
Dan Marsden added a comment - Hi Amr, I've just pushed your patch into contrib cvs into 19_STABLE and HEAD - I've got a few other patches to go in as well! - thanks heaps! Dan
Hide
Permalink
Wen Hao Chuang added a comment -

any update on this ticket? Does this block works on 1.9.9? Thanks!

Show
Wen Hao Chuang added a comment - any update on this ticket? Does this block works on 1.9.9? Thanks!
Hide
Permalink
Dan Marsden added a comment -

Hi Wen,

I think it "works" on 1.9Stable, just not as well as it could - from memory it's still tied to "roles" rather than capabilities - I think it's hardcoded to the admin/teacher/student roles (dates back to the old is_teacher is_admin is_student code)

it should install ok.

Show
Dan Marsden added a comment - Hi Wen, I think it "works" on 1.9Stable, just not as well as it could - from memory it's still tied to "roles" rather than capabilities - I think it's hardcoded to the admin/teacher/student roles (dates back to the old is_teacher is_admin is_student code) it should install ok.
Hide
Permalink
Dan Marsden added a comment -

oh - here's the latest code:
http://cvs.moodle.org/contrib/plugins/blocks/file_manager/

Show
Dan Marsden added a comment - oh - here's the latest code: http://cvs.moodle.org/contrib/plugins/blocks/file_manager/

People

Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.