Non-core contributed modules

Block: Analog Clock

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.6, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.6.6, 1.7, 1.7.1, 1.7.2, 1.7.3, 1.7.4, 1.8, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.8.5, 1.8.6, 1.8.7, 1.9, 1.9.1, 1.9.2, 1.9.3
  • Fix Version/s: None
  • Component/s: Add a project here
  • Labels:
    None
  • Environment:
    All
  • Affected Branches:
    MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE

Description

Analog clock block

Attachments

  1. File
    analog_clock.rar
    06/Nov/08 8:38 PM
    3 kB
    Amr Hourani
  2. File
    analog_clock.rar
    06/Nov/08 8:04 AM
    3 kB
    Amr Hourani
  3. File
    aou_clock.rar
    06/Nov/08 7:13 AM
    3 kB
    Amr Hourani
  4. File
    aou_clock(2).rar
    26/Oct/08 12:21 AM
    3 kB
    Amr Hourani

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

I received a couple PHP notices that can be resolved by adding:

$this->content->icons[] = '';
$this->content->footer[] = '';

to get_content function. I'll go ahead and do that and upload to CVS later as I have to go to class now. Otherwise, it looks good.

Peace - Anthony

Show
Anthony Borrow added a comment - I received a couple PHP notices that can be resolved by adding: $this->content->icons[] = ''; $this->content->footer[] = ''; to get_content function. I'll go ahead and do that and upload to CVS later as I have to go to class now. Otherwise, it looks good. Peace - Anthony
Hide
Permalink
Amr Hourani added a comment -

Hi Anthony, thanks for informing me..

actually it should be:
$this->content->icons = '';
$this->content->footer = '';
not arrays to avoid any offset might happen in indexes.

attached the latest code..

thanks!

Show
Amr Hourani added a comment - Hi Anthony, thanks for informing me.. actually it should be: $this->content->icons = ''; $this->content->footer = ''; not arrays to avoid any offset might happen in indexes. attached the latest code.. thanks!
Hide
Permalink
Anthony Borrow added a comment -

Amr - Yep, you're absolutely right - I was rushing. Thanks for updating the code. Another quick question before I rush off again to another meeting, the block is currently named aou_clock, any objection to renaming the block to analog_clock? Then I could upload it to contrib/plugins/blocks/analog_clock. I know it is a trivial matter but CVS does not allow renaming files or directories so I try to get these types of things how we want them at the beginning. Thanks for your patience. Peace - Anthony

Show
Anthony Borrow added a comment - Amr - Yep, you're absolutely right - I was rushing. Thanks for updating the code. Another quick question before I rush off again to another meeting, the block is currently named aou_clock, any objection to renaming the block to analog_clock? Then I could upload it to contrib/plugins/blocks/analog_clock. I know it is a trivial matter but CVS does not allow renaming files or directories so I try to get these types of things how we want them at the beginning. Thanks for your patience. Peace - Anthony
Hide
Permalink
Amr Hourani added a comment -

no problem at all.
changed and attached
cheers!
Amr

Show
Amr Hourani added a comment - no problem at all. changed and attached cheers! Amr
Hide
Permalink
Anthony Borrow added a comment -

Amr - I've uploaded the block to CVS and given you write access to contrib/plugins/blocks/analog_clock. I also created a component called Block: Analog clock for any issues. Let me know if you need anything else. Let me know if you want to update the M&P page links or if you would like for me to do it. Thanks for sharing a great block. One thing that might be helpful, although I don't know how easy it would be to implement would be to allow the user to choose the size of the clock (even if it is just to offer a few options). I'll let you figure out if you think that is practical or worth doing. Peace - Anthony

Show
Anthony Borrow added a comment - Amr - I've uploaded the block to CVS and given you write access to contrib/plugins/blocks/analog_clock. I also created a component called Block: Analog clock for any issues. Let me know if you need anything else. Let me know if you want to update the M&P page links or if you would like for me to do it. Thanks for sharing a great block. One thing that might be helpful, although I don't know how easy it would be to implement would be to allow the user to choose the size of the clock (even if it is just to offer a few options). I'll let you figure out if you think that is practical or worth doing. Peace - Anthony
Hide
Permalink
Amr Hourani added a comment -

settings added..
language file added
attached..

thanks!

Show
Amr Hourani added a comment - settings added.. language file added attached.. thanks!
Hide
Permalink
Anthony Borrow added a comment -

Amr - Thanks for adding the block settings for width and height. I have committed those to CVS. In the lang file I changed 'Clock Width to 'Clock width' just to be consistent with casing in other parts of Moodle which tends toward using initial cap of first word only. You should be able to make any changes you wish directly to CVS. You may want to test changing something trivial (whitespacing or changing a comment, etc.) just to make sure that the access is working. Let me know if you have any questions or need anything. Peace - Anthony

Show
Anthony Borrow added a comment - Amr - Thanks for adding the block settings for width and height. I have committed those to CVS. In the lang file I changed 'Clock Width to 'Clock width' just to be consistent with casing in other parts of Moodle which tends toward using initial cap of first word only. You should be able to make any changes you wish directly to CVS. You may want to test changing something trivial (whitespacing or changing a comment, etc.) just to make sure that the access is working. Let me know if you have any questions or need anything. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Closing all of my resolved issues. Peace - Anthony

Show
Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.