|
[
Permalink
| « Hide
]
Amr Hourani added a comment - 27/Oct/08 11:09 PM
screenshot
Amr - Thanks for this and the other code you have added to the tracker. I've not had a chance to look at them yet but they are on my to do list. One thing I want to test with this is whether it refreshes the whole page of just the messages block. In particular, I'm thinking if someone is working on a forum post we would not want them to lose what they have been typing. Peace - Anthony
Hi anthony,
actually it doesnt refresh the whole page, it just graps the latest messages using ajax. hope to include it in moodle core thank you Excellent idea. I'll make sure to flag it as a messaging improvement for 2.0 and see what we can do to get it evaluate for consideration into core. Peace - Anthony
Great..
I will make sure to enhance it and add features to it. and also am ready for auditing and code checking for any modification required.. thank you anthony! Update: added session confirmation for a better security..
Martin - I've added you as a watcher to this issue. Before adding this to something like contrib/patches/check_messages, I thought I would check and see how it might fit in with some of the GSOC work that you and Luis did this summer to enhance messaging. I like what Amr has done and the concept of refreshing the messages block periodically without doing a full page refresh (although I would recommend giving the site admin an option to set how often this occurs). I'm not sure if this might be a patch that you would want to work into HEAD for Moodle 2.0 or not so if you get a chance to look at it and comment here it would be helpful. Peace - Anthony
Update: adding settings page for defining time periods of refresh.
also adding english strings in message.php lang file, en_utf8 Amr - Thanks for adding the setting, this is a nice patch which we may want to consider for Moodle 2.0. Nice work! Peace - Anthony
Here is a messages block cleaning up language strings, created /lang/en_utf8 and some other minor changes
is this going to be added to moodle CVS?
I've not looked at the code yet sorry but two thoughts are:
Generally the way we do this now in Moodle is to leave the messages popup on screen ... it has a similar refresh cycle. The difference is that it only happens when users open this window ... if it happened by default for all users looking at course pages, my moodle pages etc, then it could mean a significant hit on the server load. So yes, it should be admin controlled and probably default to off. I'm not sure what I think about changing the title bar on a course page .... it makes total sense to do that on the messaging popup, though ... I'll try and look at the code soon. Thanks Amr! Hi Martin,
for the title bar thing, it just changed once you get messages, and in the next acquire within the same session, if there are no messages it will re caption it to the course name. From point of view, it is not that major thing to be included but i wanted to share in moodle development in someway, and unfor. all what we can access as conrtib developer is just plugins so I cant play with anything but plugins. I would love to work on something like messaging system, but I think I decided to do that too late because there are already developers who are working now on messaging. anyway, its your call now Amr - It sounds like Moodle core opted to go with a separate popup page to deal with the refresh issue. I can definitely appreciate the performance load issue and suspect that your idea represents another option for handling the messages block. My impression is that the code for your messages block will wind up on CONTRIB as a patch for site administrators who want to take advantage of your approach. We can let Martin confirm that when he has a chance to look at the code. I knew that there was work done on the messaging system so I figured I would check with Martin to see where (or if) this might fit in with some of that work before adding it as a patch. Thanks for your patience as we look at how best to share this code with the rest of the Moodle community. Peace - Anthony
Amr - Sorry, this just fell off my radar. Unless I hear from Martin, let's work on getting this added to CONTRIB as a patch. Peace - Anthony
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
New Feature
Open
Minor
Enhanced Messages Block
 |
|
