Non-core contributed modules

Module for student progress reviews

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.1
  • Fix Version/s: None
  • Component/s: Module: Termreview
  • Labels:
    None
  • Environment:
    Developed on my 1.9.1+ running on ubuntu 6.06 Apache/2.0.55 php 5.1.2 mysql 5.0.22. It might not work with other databases as there are a fair few uses of get_record(s)_sql
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_19_STABLE

Description

A module to enable progress reviews to be dfone through moodle.

First an administrator (or anyone with mod/termreview:manage) adds the activity to the frontpage, they then click the distrubute button to put a copy on all non-meta courses.
Teachers complete the form for each of their students in each class.
Tutors (any course with a / in the shortname is taken to be a tutor group- probably should make this configurable) get a different form, with all the subject teachers' grades/comments above the space to fill in the outcome of a student interview.
On a preset date cron closes the reviews which locks them and copys the attendance/work completion from that date into the review.
Teachers/tutors can 'delete' the activity off their course pages but this will only remove the links- only someone with mod/termreview:manage can perminantly delete (or restore) these activities.

There is a file called usertab.php included which is to be displayed on an extra 'tutor' profile tab.

Attachments

Issue Links

This issue has a non-specific relationship to:
CONTRIB-814 Profile tabs to show all a students grades/attendance Minor Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mike Worth added a comment -

This is the tutor tab on the user profiles that usertab.php goes on

Show
Mike Worth added a comment - This is the tutor tab on the user profiles that usertab.php goes on
Hide
Permalink
Anthony Borrow added a comment -

Mike - Thanks for submitting this and sharing the code with the community. I'll take a look at it later but wanted you to at least know that I have received and reviewed this issue. Peace - Anthony

Show
Anthony Borrow added a comment - Mike - Thanks for submitting this and sharing the code with the community. I'll take a look at it later but wanted you to at least know that I have received and reviewed this issue. Peace - Anthony
Hide
Permalink
Mike Worth added a comment - - edited

Version 1.0

I have mainly just neatened things up- added comments, amalgamated a few functions that didn't need to be functions in their own right, removed some global declarations that were unneeded, made the parameters to functions more sensible and obvious, added copyright/licencing bits, included a copy of GPL

It should still work as before.

Don't try to upgrade from previous version- I have been playing without keeping track of the upgrade file so just remove and re-install. I'll hopefully start with upgrade files from now on (no promises though)

Show
Mike Worth added a comment - - edited Version 1.0 I have mainly just neatened things up- added comments, amalgamated a few functions that didn't need to be functions in their own right, removed some global declarations that were unneeded, made the parameters to functions more sensible and obvious, added copyright/licencing bits, included a copy of GPL It should still work as before. Don't try to upgrade from previous version- I have been playing without keeping track of the upgrade file so just remove and re-install. I'll hopefully start with upgrade files from now on (no promises though)
Hide
Permalink
Mike Worth added a comment -

V1.1

Main difference is the distrubute page allows selection of some courses rather than all or nothing. It should be fairly obvious how to work it- I based it on the role assignment interface.

You can just copy the directory over the top of the old one, when you go to notifications it will state that the update has been successful (although no changes in the database are needed or made)

Show
Mike Worth added a comment - V1.1 Main difference is the distrubute page allows selection of some courses rather than all or nothing. It should be fairly obvious how to work it- I based it on the role assignment interface. You can just copy the directory over the top of the old one, when you go to notifications it will state that the update has been successful (although no changes in the database are needed or made)
Hide
Permalink
Mike Worth added a comment - - edited

Sorry- I assumed I could leave off the upgrade file, it didn't like it so I've now included one that doesn't do anything

Could an admin please delete the older v1.1 please

Show
Mike Worth added a comment - - edited Sorry- I assumed I could leave off the upgrade file, it didn't like it so I've now included one that doesn't do anything Could an admin please delete the older v1.1 please
Hide
Permalink
Mike Worth added a comment -

V1.2

Main new feature is the abilty to default the minimum target grade field on the teacher form with a calculated value, based on a students average GCSE score and statistical data for previous students taking the relevant course. This does, in a few places, work things out using certian data encoded into our course idnumbers. If your course idnumbers don't work it should not intefere with anything other than the mtg calculation.

Show
Mike Worth added a comment - V1.2 Main new feature is the abilty to default the minimum target grade field on the teacher form with a calculated value, based on a students average GCSE score and statistical data for previous students taking the relevant course. This does, in a few places, work things out using certian data encoded into our course idnumbers. If your course idnumbers don't work it should not intefere with anything other than the mtg calculation.
Hide
Permalink
Mike Worth added a comment -

V1.2.1

No new features- just cleaned up a bit, mainly sorting undefined variables etc.

Show
Mike Worth added a comment - V1.2.1 No new features- just cleaned up a bit, mainly sorting undefined variables etc.
Hide
Permalink
Mike Worth added a comment -

V 1.2.2

Fixed a bug that effectively caused a lockout of all users if 1.2.1 was used to upgrade from a previous 1.2.x version.

DO NOT USE ANY PREVIOUS 1.2.x VERSION

Show
Mike Worth added a comment - V 1.2.2 Fixed a bug that effectively caused a lockout of all users if 1.2.1 was used to upgrade from a previous 1.2.x version. DO NOT USE ANY PREVIOUS 1.2.x VERSION
Hide
Permalink
Mike Worth added a comment -

V1.3

Played about with usertab.php and added a lot on links
Now any old reviews are printed below the one currently being completed for comparison
Referrals are now fully configurable and will email lists of referred students to the appropriate perople when the mail review is closed

Show
Mike Worth added a comment - V1.3 Played about with usertab.php and added a lot on links Now any old reviews are printed below the one currently being completed for comparison Referrals are now fully configurable and will email lists of referred students to the appropriate perople when the mail review is closed
Hide
Permalink
Mike Worth added a comment -

V 1.3.1

Just changed the emailing of referral lists to use the proper moodle function and stopped the usage of referrals on child reviews that are not selected for the parent review

Show
Mike Worth added a comment - V 1.3.1 Just changed the emailing of referral lists to use the proper moodle function and stopped the usage of referrals on child reviews that are not selected for the parent review
Hide
Permalink
Mike Worth added a comment -

V 1.3.2

Reviews that are closed without having been used are now deleted (there is no point keeping them there to view nothing)

Show
Mike Worth added a comment - V 1.3.2 Reviews that are closed without having been used are now deleted (there is no point keeping them there to view nothing)
Hide
Permalink
Mike Worth added a comment -

V 1.3.3

Rodone the manager interface, replaced all the buttons with tabs and cleaned up titles etc.
Added a 'child courses' tab availible to managers

Show
Mike Worth added a comment - V 1.3.3 Rodone the manager interface, replaced all the buttons with tabs and cleaned up titles etc. Added a 'child courses' tab availible to managers
Hide
Permalink
Jesus Martin added a comment - - edited

Hi.
Running on a 1.9.3+ site.
Termreview 1.3.3

When I try to insert an activity with this module, I get this message:

This data is current- the data on the final report will be accurate on: 13/12
Warning: require_once(/var/www/moodle/mod/attforblock/allattlib.php) [function.require-once]: failed to open stream: No such file or directory in /var/www/moodle/mod/termreview/locallib.php on line 93

Fatal error: require_once() [function.require]: Failed opening required '/var/www/moodle/mod/attforblock/allattlib.php' (include_path='/var/www/moodle/lib/pear:.:/usr/share/php:/usr/share/pear') in /var/www/moodle/mod/termreview/locallib.php on line 93

Thanks. J. Martin

Show
Jesus Martin added a comment - - edited Hi. Running on a 1.9.3+ site. Termreview 1.3.3 When I try to insert an activity with this module, I get this message: This data is current- the data on the final report will be accurate on: 13/12 Warning: require_once(/var/www/moodle/mod/attforblock/allattlib.php) [function.require-once]: failed to open stream: No such file or directory in /var/www/moodle/mod/termreview/locallib.php on line 93 Fatal error: require_once() [function.require]: Failed opening required '/var/www/moodle/mod/attforblock/allattlib.php' (include_path='/var/www/moodle/lib/pear:.:/usr/share/php:/usr/share/pear') in /var/www/moodle/mod/termreview/locallib.php on line 93 Thanks. J. Martin
Hide
Permalink
Mike Worth added a comment -

It is having that problem because it is relying on the attendance module. You can try commenting that line out and seeing if that works. I'm off wwork til the middle of the week- I'll have a look at making a better fix then

Mike

Show
Mike Worth added a comment - It is having that problem because it is relying on the attendance module. You can try commenting that line out and seeing if that works. I'm off wwork til the middle of the week- I'll have a look at making a better fix then Mike
Hide
Permalink
Mike Worth added a comment -

V 1.4

Is now a confiuguration option so that the module can be used without the attendance module being installed(under modules->activities->term review)

Show
Mike Worth added a comment - V 1.4 Is now a confiuguration option so that the module can be used without the attendance module being installed(under modules->activities->term review)
Hide
Permalink
Mike Worth added a comment -

V 1.4.1

Added a manager tab to view all referrals and amalgamated performance grade scale and tarrget grade scale so that it is possible to get statistics for students currently working above/below their target grade

Show
Mike Worth added a comment - V 1.4.1 Added a manager tab to view all referrals and amalgamated performance grade scale and tarrget grade scale so that it is possible to get statistics for students currently working above/below their target grade
Hide
Permalink
Mike Worth added a comment -

V 1.4.2

View referrals page will now show the referrals to the person to whom the lists are emailed as well as managers

Show
Mike Worth added a comment - V 1.4.2 View referrals page will now show the referrals to the person to whom the lists are emailed as well as managers
Hide
Permalink
Anthony Borrow added a comment -

Mike - Glad to see you have been able to continue making progress with this module. I received the following PHP notice:

Notice: Trying to get property of non-object in /home/arborrow/Moodle/code/19stable/mod/termreview/mod_form.php on line 53

I suspect the problem is with $cm->instance. I would think there has to be a better way of getting the $cm data rather than making it a global. I'll keep playing with the code but would recommend that you test it with the debugging mode set to show All PHP errors (not developer mode) but at least showing all the PHP notices and warnings is helpful.

Peace - Anthony

Show
Anthony Borrow added a comment - Mike - Glad to see you have been able to continue making progress with this module. I received the following PHP notice: Notice: Trying to get property of non-object in /home/arborrow/Moodle/code/19stable/mod/termreview/mod_form.php on line 53 I suspect the problem is with $cm->instance. I would think there has to be a better way of getting the $cm data rather than making it a global. I'll keep playing with the code but would recommend that you test it with the debugging mode set to show All PHP errors (not developer mode) but at least showing all the PHP notices and warnings is helpful. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

Similarly later on around line 72 or so the second call to get_record produces a notice. I simply did a check for isset($cm) before attempting.

I do not have the attendance module installed and thus received:

Warning: require_once(/home/arborrow/Moodle/code/19stable/mod/attforblock/allattlib.php) [function.require-once]: failed to open stream: No such file or directory in /home/arborrow/Moodle/code/19stable/mod/termreview/locallib.php on line 94

I think it would be good to check for its existence before the require_once.

Peace - Anthony

Show
Anthony Borrow added a comment - Similarly later on around line 72 or so the second call to get_record produces a notice. I simply did a check for isset($cm) before attempting. I do not have the attendance module installed and thus received: Warning: require_once(/home/arborrow/Moodle/code/19stable/mod/attforblock/allattlib.php) [function.require-once]: failed to open stream: No such file or directory in /home/arborrow/Moodle/code/19stable/mod/termreview/locallib.php on line 94 I think it would be good to check for its existence before the require_once. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I've got a meeting now and want to make sure that I have my Eclipse settings reconfigured properly before committing. I don't see anything that prevents us from adding the code to CONTRIB. In general it looks like good work you just need to make sure that you check variables to prevent some minor PHP notices. Peace - Anthony

Show
Anthony Borrow added a comment - I've got a meeting now and want to make sure that I have my Eclipse settings reconfigured properly before committing. I don't see anything that prevents us from adding the code to CONTRIB. In general it looks like good work you just need to make sure that you check variables to prevent some minor PHP notices. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment - - edited

Mike - I have added the code for the termreview module to CONTRIB so it is now in CVS. I have bumped your privileges in the tracker so that you can manage issues related to this module. I created a component under the CONTRIB project in the tracker and made you the component lead so that any bugs created for it will automatically be assigned to you. The only thing we need to do now is get you to request CVS access by going to http://moodle.org/cvs/ and request write access for contrib/plugins/mod/termreview. Once that is done you will be able to maintain the code there. Then we can change the latest download link on the M&P page to http://download.moodle.org/download.php/plugins/mod/termreview.zip. If you could, take a look at the recommendations for the documentation page provided at http://docs.moodle.org/en/Development:Guidelines_for_contributed_code. Little things like linking it to the list of contributed code could be improved. Let me know if you have any questions updating files in CVS or if there is anything else I can do to be of help. I'm going to mark this issue as resolved but feel free to comment upon it. Peace - Anthony

Show
Anthony Borrow added a comment - - edited Mike - I have added the code for the termreview module to CONTRIB so it is now in CVS. I have bumped your privileges in the tracker so that you can manage issues related to this module. I created a component under the CONTRIB project in the tracker and made you the component lead so that any bugs created for it will automatically be assigned to you. The only thing we need to do now is get you to request CVS access by going to http://moodle.org/cvs/ and request write access for contrib/plugins/mod/termreview. Once that is done you will be able to maintain the code there. Then we can change the latest download link on the M&P page to http://download.moodle.org/download.php/plugins/mod/termreview.zip. If you could, take a look at the recommendations for the documentation page provided at http://docs.moodle.org/en/Development:Guidelines_for_contributed_code. Little things like linking it to the list of contributed code could be improved. Let me know if you have any questions updating files in CVS or if there is anything else I can do to be of help. I'm going to mark this issue as resolved but feel free to comment upon it. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

moving to Module: Termreview component

Show
Anthony Borrow added a comment - moving to Module: Termreview component
Hide
Permalink
Anthony Borrow added a comment -

added to CONTRIB

Show
Anthony Borrow added a comment - added to CONTRIB
Hide
Permalink
Anthony Borrow added a comment -

another PHP notice I found after disabling the option for attendance:

Notice: Undefined property: stdClass::$grade_scale in /home/arborrow/Moodle/code/19stable/mod/termreview/termreview_form.php on line 39

Show
Anthony Borrow added a comment - another PHP notice I found after disabling the option for attendance: Notice: Undefined property: stdClass::$grade_scale in /home/arborrow/Moodle/code/19stable/mod/termreview/termreview_form.php on line 39
Hide
Permalink
Anthony Borrow added a comment -

Notice: Undefined index: in /home/arborrow/Moodle/code/19stable/mod/termreview/termreview_form.php on line 39

Show
Anthony Borrow added a comment - Notice: Undefined index: in /home/arborrow/Moodle/code/19stable/mod/termreview/termreview_form.php on line 39
Hide
Permalink
Anthony Borrow added a comment -

Notice: Undefined property: stdClass::$grade_scale in /home/arborrow/Moodle/code/19stable/mod/termreview/termreview_form.php on line 40

Show
Anthony Borrow added a comment - Notice: Undefined property: stdClass::$grade_scale in /home/arborrow/Moodle/code/19stable/mod/termreview/termreview_form.php on line 40
Hide
Permalink
Anthony Borrow added a comment -

Notice: Undefined index: in /home/arborrow/Moodle/code/19stable/mod/termreview/termreview_form.php on line 40

Show
Anthony Borrow added a comment - Notice: Undefined index: in /home/arborrow/Moodle/code/19stable/mod/termreview/termreview_form.php on line 40
Hide
Permalink
Mike Worth added a comment -

Am attaching a verion here after fixing error raised at http://moodle.org/mod/forum/discuss.php?d=109711#p509643

Can't get access to cvs atm as am still waiting for access through the firewall

Show
Mike Worth added a comment - Am attaching a verion here after fixing error raised at http://moodle.org/mod/forum/discuss.php?d=109711#p509643 Can't get access to cvs atm as am still waiting for access through the firewall
Hide
Permalink
Mike Worth added a comment -

Me being stupid- last one was broken by typos

Show
Mike Worth added a comment - Me being stupid- last one was broken by typos
Hide
Permalink
Mike Worth added a comment -

There will be some future updates in cvs but this issue can be closed

Show
Mike Worth added a comment - There will be some future updates in cvs but this issue can be closed

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.