Details
-
Type:
New Feature
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.9.3
-
Fix Version/s: None
-
Component/s: Block: Sharing cart
-
Labels:None
-
Affected Branches:MOODLE_19_STABLE
Description
Problem: It is difficult to duplicate or clone an individual activity or resource. See issue: Teachers also like to roam courses in a site and pick up activities for later use. They like to keep a library for storing frequently used activities, resources or blocks in course creation.
Solution: The sharing cart block allows teachers to use a one-click icon to put an activity (without user data) into a block. This block follows a teacher as he/she roams a site or switches between courses. The block can be used to insert an activity/resource with one click into any course a teacher has access to.
Issues and Status: This block is working on a producation site. Currently it is working with topic, weekly and project course formats.
Discussion: http://moodle.org/mod/forum/discuss.php?d=87044
Attachments
-
$i18n.getText("admin.common.words.hide")
- sharing_cart_2009022001.zip
- 04/Mar/09 1:33 PM
- 38 kB
- Akio Ohnishi
-
- sharing_cart/blocks/.../backup.php 3 kB
- sharing_cart/.../block_sharing_cart.php 28 kB
- sharing_cart/blocks/.../db/install.xml 2 kB
- sharing_cart/blocks/.../db/upgrade.php 0.3 kB
- sharing_cart/blocks/.../delete.php 1 kB
- sharing_cart/.../block_sharing_cart.php 2 kB
- sharing_cart/blocks/.../sharing_cart.html 2 kB
- sharing_cart/.../block_sharing_cart.php 2 kB
- sharing_cart/blocks/.../sharing_cart.html 3 kB
- sharing_cart/blocks/sharing_cart/lib.php 0.5 kB
- sharing_cart/blocks/.../move.php 2 kB
- sharing_cart/blocks/.../movedir.php 2 kB
- sharing_cart/blocks/.../restore.php 2 kB
- sharing_cart/.../MoodleQuickForm_script.php 0.6 kB
- sharing_cart/.../SharingCart_qtype_cloze.php 1 kB
- sharing_cart/.../SharingCart_qtype_match.php 0.8 kB
- sharing_cart/.../SharingCart_qtype_randomsamatch.php 0.5 kB
- sharing_cart/.../SharingCart_Backup.php 19 kB
- sharing_cart/.../SharingCart_BackupRestoreBase.php 3 kB
- sharing_cart/.../SharingCart_CourseException.php 0.2 kB
- sharing_cart/.../SharingCart_CourseScript.php 2 kB
- sharing_cart/.../SharingCart_Exception.php 0.1 kB
- sharing_cart/.../SharingCart_FileSystem.php 4 kB
- sharing_cart/.../SharingCart_ModuleException.php 0.2 kB
- sharing_cart/.../SharingCart_Restore.php 17 kB
- sharing_cart/.../SharingCart_SectionException.php 0.2 kB
- sharing_cart/.../SharingCart_XmlException.php 0.2 kB
- sharing_cart/blocks/.../sharing_cart_lib.php 1 kB
$i18n.getText("admin.common.words.show")- sharing_cart_2009022001.zip
- 04/Mar/09 1:33 PM
- 38 kB
- Akio Ohnishi
-
$i18n.getText("admin.common.words.hide")
- sharingcart-2008123101.zip
- 02/Jan/09 12:00 PM
- 26 kB
- Akio Ohnishi
-
- blocks/sharing_cart/backup.php 10 kB
- blocks/.../block_sharing_cart.php 28 kB
- blocks/sharing_cart/db/install.xml 2 kB
- blocks/sharing_cart/db/upgrade.php 0.6 kB
- blocks/sharing_cart/delete.php 1 kB
- blocks/.../block_sharing_cart.php 2 kB
- blocks/sharing_cart/.../sharing_cart.html 2 kB
- blocks/.../block_sharing_cart.php 2 kB
- blocks/sharing_cart/.../sharing_cart.html 3 kB
- blocks/sharing_cart/.../course/script.php 2 kB
- blocks/sharing_cart/lib/filesystem.php 1 kB
- blocks/sharing_cart/lib/form/script.php 0.6 kB
- blocks/sharing_cart/lib/sync.php 0.3 kB
- blocks/sharing_cart/lib.php 0.5 kB
- blocks/sharing_cart/move.php 2 kB
- blocks/sharing_cart/movedir.php 2 kB
- blocks/sharing_cart/restore.php 13 kB
- blocks/sharing_cart/sharing_cart_lib.php 1 kB
$i18n.getText("admin.common.words.show")- sharingcart-2008123101.zip
- 02/Jan/09 12:00 PM
- 26 kB
- Akio Ohnishi
Issue Links
| This issue will help resolve: | ||||
| MDL-11288 | Ability to copy (or clone) an activity |
|
|
|
| This issue has a non-specific relationship to: | ||||
| CONTRIB-906 | Project Course Format with bulk upload and section backup/restore |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Don and Akio - Similar to CONTRIB-906, if I might ask that you upload the latest code here, I will take a look at it. Peace - Anthony
???:
-???????????????????????????????????
-?????????????????????????????????????????????????????????????????????
Changed:
-Modified link rewrite processes on same section or course.
-Shared with backup/restore libraries on the Project Course Format.
If Project Course Format exists then syncronize from their libraries.
Not a big deal, but just something to consider since this is dependent upon the project course format - might we want to consider renaming the block project_sharing_cart? Other than that I've taken a quick look and everything else looks OK. A README.txt file would be nice. I realize renaming it would require renaming a bunch of files so if you simply prefer to keep it as is that is perfectly fine. I just thought I would raise the question. I'm happy to commit it to CVS either way. Peace - Anthony
Thanks, Anthony, for checking the code and offering valuable advice. We will apply for CVS write access and although Akio will do all the "CVS writing", initially I am fine with having me be the assigned, responsible person. I think also it is good for Akio to post bilingually, as it will serve as a useful reference history for him and some others. We will also read more about the system to see how it works (eg: is a version number automatically assigned to each update?). As for the sharing cart, our number one priority, due to user requests on moodle.org forums, is to make it compatible with all Moodle course formats, particularly the topic and weekly formats. So it should not be necessary to rename the sharing cart. Akio thinks it should be possible to do that sometime in January/February. Cheers, Don
Don - Thanks, I remember reading about the goal of getting it compatible with others formats so I agree we can leave the of the block as it is. If I understand the question about version numbers correctly, upon updating a file in CVS it receives its own unique version number. In terms of branches, as we move to different versions of Moodle we can branch the code as needed so that you can have a version specifically for Moodle 1.9 (MOODLE_19_STABLE branch) and a version specifically for Moodle 2.0 (currently HEAD). For now, there is just one branch (HEAD). Let me know if there is anything I can do. Keep in mind I will be taking off for Nepal in a couple of days and will not be online during that time. I will return in February. Peace - Anthony
FYI - I mistakenly commented in the CVS commit that it was for CONTRIB-906 (project course format) when in fact it should have been for CONTRIB-907 (sharing cart block). As a result the version control will be on the wrong issue. My apologies for any inconvenience. Peace - Anthony
I have created the Block: Sharing cart component in tracker and assigned Don as the lead. The code has been added to CVS. Please request CVS write access via http://moodle.org/cvs for contrib/plugins/blocks/sharing_cart. Peace - Anthony
New versions of Sharing Cart released.
- SC now compatible with Weekly format, Topic format, Project format
For your information, I made English documentation for the Sharing
Cart.
http://docs.moodle.org/en/Sharing_Cart
- SC now compatible with Weekly format, Topic format, Project format
I downloaded this module and installed on Moodle 1.9.2 (have yet to upgrade).
I went to the Moodle docs and tested out the instructions. I left a page comment, but thought it might be best to post it here:
Suggestion for instructions under Operation Point 3: Making Folders Inside the Sharing Cart
When a content item is in the sharing cart, the "move into folder" icon looks like a -> arrow (traditional Moodle - it is a right "move" arrow). I've tested this using the "standard" Moodle theme (on Moodle version 1.9.2 - have to update to 1.9.4+). So, in the instructions, it is not click on "edit icon", it should be click on the "move" icon - that is, unless the icon is changed at the code level.
P.S. - This is an awesome module! Thank you for developing!
- Mary, 03/04/09
- Mary, 03/04/09
I have found that when a sharing cart block is added to a page using Topics format that
other blocks are affected.
The following block features are affected:
1. Missing Delete icon
2. Missing show/hide icon
3. Other blocks are not movable
Mary and Barry - Thanks for your reports on the issues you are finding with the sharing cart block. Might I ask both of you to create a separate issue in the CONTRIB project, Block: Sharing cart component? The issue you mention are separate from that of getting the code in CVS (which we have done) and there is now a component for managing those issues which will automatically be assigned to the folks who have volunteered to maintain the code (namely, Don and Akio). Let me know if you have problems or questions about creating a new issue but generally speaking we try to file one issue per bug, feature request, etc. as it helps keep the developers and maintainers of code focused on the specific issue at hand. Thanks again for your feedback and help with testing the sharing cart block. Peace - Anthony
Thanks Anthony, I've created CONTRIB-1086 to cover this issue
Thanks Barry that helps to keep things somewhat organized and manageable. Peace - Anthony
Mary - Looking more closely at your comment it seems related merely to the documentation for the page. Feel free to login to the docs.moodle.org site and make the suggested changes. It is a wiki that anyone can change. That said, I do think that the page can be clarified as FTP or direct access is allowed. As much as possible, I would encourage sticking to the language used at:
http://docs.moodle.org/en/Installing_contributed_modules_or_plugins
which keeps it simpler than 1-2-3 by saying:
To install a contributed block:
1. Download the zip file and unzip it to your moodle/block directory.
2. Visit your admin page http://your_moodle_address/admin/index.php to complete the installation.
Peace - Anthony
Thank you Barry and Anthony!
- One note: My comment wasn't about installation, but about using the block. My concern is: The documentation refers to the "editing" icon, but it is not the editing icon displayed but the "move" icon. That's why I posted here because the path referring to the icon is one that could be fixed in the code to point to the correct Moodle icon for "edit". [I also posted because I wanted to verify that what I "see" is similar to what others "see".]
- One note: My comment wasn't about installation, but about using the block. My concern is: The documentation refers to the "editing" icon, but it is not the editing icon displayed but the "move" icon. That's why I posted here because the path referring to the icon is one that could be fixed in the code to point to the correct Moodle icon for "edit". [I also posted because I wanted to verify that what I "see" is similar to what others "see".]
Just thinking...if it IS easier to just change the wording in the documentation to "move" icon instead of "editing" icon I will happily go to the documentation and make that change. Which is best, do you think?
OK, I went in and see what you mean. I think the move icon is more intuitive as in a sense that is what you are doing - moving the shared item into a folder. You are not really editing it so I think the documentation should be changed. Feel free to change the documentation and then if Don does not agree or like the change he can comment and revert it back.Peace - Anthony
If you are using the Sharing Cart, please download a new version from Moodle CVS added today-20090414.
http://download.moodle.org/download.php/plugins/blocks/sharing_cart.zip
Our Version2 Educational Web Development colleagues fixed a bug with restoring/deleting old items that was caused by
some missing DB update operation codes in previous version of the Sharing Cart--a similar error message that Mark Pearson reported earlier.
Also I have updated the Sharing Cart documentation concerning how to share questions in the Question Bank. I recommend creating new roles for teachers and using System question categories. Correct me if you have some other experience concerning this. Please let me know as soon as possible.
http://docs.moodle.org/en/Sharing_Cart
"Roles (new documentation)
Generally, the Sharing Cart will duplicate any activity in any course that a teacher has access to. However, quiz questions have another set of permissions independent of site roles. Therefore, we recommend if you wish to share questions, make the following changes:
1. Add a new role--Question Creator: Make this role in Site Admin >> Users >> Permissions >> Define roles, and assign all teachers to this role (in addition to other roles they already have). This role should be given at least the following rights (set permissions to "Allow") under "Course": Manage Activities, Manage Files,Add new questions, Edit all questions, Edit question categories, Move all questions, Use all questions, View all questions.
2. Set questions to System Question Category: If you set questions to course or activity level categories, you may not be able to share them.
3. Possibly add another role--Question User: If students are unable to view questions, make this role and assign all students to this role. Set to "Allow" the following permissions: Use all questions, View all questions."
As far as I know, it does not support Postgres. I assume you use Postgres, so I will ask our programmer if that is difficult to include in our 2.0 version of the Sharing Cart. I doubt it would be included in the 1.9 version.
In theory I would expect the block to be reasonably database independent. At least the install is using the standard install.xml file so it should work. There may be some sql issues. I would say give it a shot and report any issues you discover. Peace - Anthony
Hi Anthony. What does 'closing' mean? Is the Sharing Cart block now included in core Moodle? If not, I think the purpose of this issue is to propose its inclusion. Although 1.9 is getting old, it will continue to be used for many sites for years. Thanks, Don
Don - Closing means that the task has been completed and will not be getting any more attention. As I understand this issue, it was not for the sharing cart block to be added to core but rather that the code be added to a repository, a tracker component created, etc. as we normally do for contrib code. As the 2.0 version of the sharing cart becomes available, the modules and plugins database entry can be updated. In addition, a subtask can be created to CONTRIB-1988 so that folks who are interested in the upgrade to 2.0 work can track it through that meta-issue. If the block is one that should be considered for inclusion in Moodle core then we would need to create an MDL issue for that. One of the reasons I did close the issues was that if there was any outstanding work that I was supposed to do on an issue that folks could let me know so thanks for checking. As best I can tell that does not seem to be the case here but I easily could have overlooked something. Peace - Anthony
p.s. - Folks are certainly welcome to continue to use the code as long as they want. That is really what the Modules and Plugins database is for (helping folks find code).
Thanks for taking time to explain. I guess I am more confused now. I don't know what the repository is that you refer to. My purpose for starting the Sharing Block and setting up this 'issue' is to get the block into core, standard code. I often promote it, by saying, "if you like the Sharing Cart to become part of Moodle core, vote for it in CONTRIB-907". Same with the Project Course Format. Unfortunately, so far they are not included in core code even though the download statistics show they are popular tools. One good news is that Moodle 2.1 will have activity cloning, which is one part of the Sharing Cart. So I guess what is frustrating for me, I don't understand the tracker and how to use it. If I have this trouble, imagine how ordinary Moodle users might be confused as they try to use this. Don
Don - Sorry for the delayed response as I was busy with the MoodleMoot in Sydney. I'm at the airport now. In any case, you are not alone in not understanding the tracker. That issue came up during a Q&A session with the HQ team. I'm happy to answer any questions. I would be happy to move this issue to MDL and modify the title so that the votes carry over so that sharing cart can be included in core. I personally think that CONTRIB is aimed at helping to avoid feature creep and meant to inspire good ideas that keep core moving forward. Alternatively, you could create an MDL issue and we could link it to this to show the interest and handle it as a separate issue. My preference would be to start a new issue but I'm willing to do whatever seems best to you. Let me know how I can be of help and best support your efforts. Peace - Anthony
Hello Don and Everyone,
I am Akio Ohnishi of Version2 Software in Sapporo, Japan. I will be
programming, updating and contributing this code into CVS in the
future. Please let us know of any bugs or requests you have.
Regards, Akio