Non-core contributed modules

Email notices sent to users who have not set their preferences

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.7, 1.8, 1.9
  • Component/s: Block: Email_list
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE

Description

The cron function is sending email notices to users who have not set or changed their email_list settings. The default value for trackbymail is no. This is causing lots of confusion for our users - they are getting notices of new email, but when they go to look at their setting, they see it is set to 'no'.

Here's the relevant bit of code. Either case 1.1 should be "Don't send mail"., or the default trackbymail setting should be changed to 'yes'.

// Preferences! Can send mail?
// Case:
// 1.- Site allow send trackbymail
// 1.1.- User doesn't define this settings -> Send mail
// 1.2.- User allow trackbymail -> Send mail
// 1.3.- User denied trackbymail -> Don't send mail

// User can definied this preferences?
if ( $preferences = get_record('email_preference', 'userid', $user->id) ) {
if ( $preferences->trackbymail == 0 ) { continue; }
}

Activity

Hide
Toni Mas added a comment -

Changed trackbymail default value. Now it's 1.

Show
Toni Mas added a comment - Changed trackbymail default value. Now it's 1.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: