Moodle

Forum Tracking - Logic and Links are wrong

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.9.1
  • Component/s: Forum
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

When using forum tracking - the links for yes/no didn't always appear right. For example : if the forum was set to no tracking the "No" in the forum listing under tracking was a link - and it should be a black "No" The only time it should be a link is when it's optional. The same thing goes when tracking is set to yes on a forum.

Here's my fix for it.

Maybe this could get into the code base

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Lori Bakken added a comment -

Why does this keep getting pushed into the next release?

Show
Lori Bakken added a comment - Why does this keep getting pushed into the next release?
Hide
Permalink
Petr Škoda (skodak) added a comment -

Hello,
I am not a maintainer of forum module, I just decided to fix as much as possible in forum before 1.9.1 gets releases - unfortunately I do not have time to backport everything into 1.8 branch, sorry. I already had a patch before I found this report, that is why I converted it into a subtask and took it over.

Petr

Show
Petr Škoda (skodak) added a comment - Hello, I am not a maintainer of forum module, I just decided to fix as much as possible in forum before 1.9.1 gets releases - unfortunately I do not have time to backport everything into 1.8 branch, sorry. I already had a patch before I found this report, that is why I converted it into a subtask and took it over. Petr
Hide
Permalink
Petr Škoda (skodak) added a comment -

About the repeated pushing to next release - previous pushes were generated automatically before releases, all open bugs with fix version selected must be moved forward or unset.

Show
Petr Škoda (skodak) added a comment - About the repeated pushing to next release - previous pushes were generated automatically before releases, all open bugs with fix version selected must be moved forward or unset.
Hide
Permalink
Petr Škoda (skodak) added a comment -

should be fixed now, thanks for the report!

Show
Petr Škoda (skodak) added a comment - should be fixed now, thanks for the report!
Hide
Permalink
Petr Škoda (skodak) added a comment -

note:commit in parent issue

Show
Petr Škoda (skodak) added a comment - note:commit in parent issue
Hide
Permalink
Jerome Mouneyrac added a comment -

Tested in 1.9 and 1.8. It works fine. Thanks.

Show
Jerome Mouneyrac added a comment - Tested in 1.9 and 1.8. It works fine. Thanks.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.