Issue Details (XML | Word | Printable)

Key: MDL-10047
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Tim Hunt
Reporter: Howard Miller
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Turning on blocks editing in a sub-category page, throws you back to the top level

Created: 07/Jun/07 10:34 PM   Updated: 11/Dec/08 06:21 PM
Return to search
Component/s: Course
Affects Version/s: 1.8
Fix Version/s: 1.9.4

Participants: Howard Miller and Tim Hunt
Security Level: None
Resolved date: 11/Dec/08
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Having navigated to a subcategory page, if one then clicks the "Blocks editing on" button, you are sent back to the "top level" Courses/Categories page.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Tim Hunt added a comment - 16/Sep/08 06:16 PM
Grabbing a bunch of related course category editing bugs that I plan to work on. Sorry for all the emails.

Tim Hunt made changes - 16/Sep/08 06:16 PM
Field Original Value New Value
Assignee Martin Dougiamas [ dougiamas ] Tim Hunt [ timhunt ]
Fix Version/s 1.9.3 [ 10290 ]
Martin Dougiamas made changes - 15/Oct/08 03:00 PM
Fix Version/s 1.9.3 [ 10290 ]
Fix Version/s 1.9.4 [ 10300 ]
tjhunt committed 11 files to 'Moodle CVS' - 11/Dec/08 06:21 PM
admin tree: MDL-10047 and MDL-13104 weird things happen when you turn editing on and off.

That was becuase not enough information was being passed in for the blocks editing controls to construct the right URL to reload the page.

It is also now possible for admin external pages to add some UI next to the turn blocks editing on/off button. For example, when you are editing the list of course catgories, the turn editing off button is now in the right place.
MODIFY admin/roles/Attic/allowoverride.php   Rev. 1.21    (+2 -2 lines)
MODIFY course/category.php   Rev. 1.139    (+3 -7 lines)
MODIFY admin/report/unittest/index.php   Rev. 1.5    (+3 -2 lines)
MODIFY admin/Attic/pagelib.php   Rev. 1.26    (+40 -7 lines)
MODIFY admin/roles/Attic/allowassign.php   Rev. 1.20    (+2 -2 lines)
MODIFY admin/roles/define.php   Rev. 1.4    (+2 -2 lines)
MODIFY lib/adminlib.php   Rev. 1.291    (+13 -3 lines)
MODIFY course/index.php   Rev. 1.106    (+2 -6 lines)
MODIFY admin/roles/assign.php   Rev. 1.96    (+3 -3 lines)
MODIFY admin/roles/override.php   Rev. 1.65    (+2 -2 lines)
MODIFY admin/roles/check.php   Rev. 1.3    (+3 -3 lines)
Tim Hunt made changes - 11/Dec/08 06:21 PM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
tjhunt committed 10 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 11/Dec/08 06:21 PM
admin tree: MDL-10047 and MDL-13104 weird things happen when you turn editing on and off.

That was becuase not enough information was being passed in for the blocks editing controls to construct the right URL to reload the page.

It is also now possible for admin external pages to add some UI next to the turn blocks editing on/off button. For example, when you are editing the list of course catgories, the turn editing off button is now in the right place.
MODIFY admin/roles/manage.php   Rev. 1.52.2.5    (+4 -4 lines)
MODIFY lib/adminlib.php   Rev. 1.153.2.56    (+13 -3 lines)
MODIFY admin/roles/assign.php   Rev. 1.63.2.15    (+5 -5 lines)
MODIFY admin/roles/Attic/allowoverride.php   Rev. 1.13.2.3    (+1 -2 lines)
MODIFY course/index.php   Rev. 1.89.2.9    (+2 -6 lines)
MODIFY admin/Attic/pagelib.php   Rev. 1.23.2.3    (+40 -7 lines)
MODIFY admin/roles/Attic/allowassign.php   Rev. 1.14.2.2    (+1 -2 lines)
MODIFY course/category.php   Rev. 1.119.2.12    (+3 -7 lines)
MODIFY admin/report/unittest/index.php   Rev. 1.4.2.3    (+3 -2 lines)
MODIFY admin/roles/override.php   Rev. 1.36.2.11    (+2 -2 lines)