Issue Details (XML | Word | Printable)

Key: MDL-10084
Type: Bug Bug
Status: Closed Closed
Resolution: Won't Fix
Priority: Major Major
Assignee: Petr Skoda
Reporter: Andrea Bicciolo
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Autologinguests not working when Login As Guest Button is hidden

Created: 12/Jun/07 12:31 AM   Updated: 19/Jun/07 03:08 AM
Return to search
Component/s: Authentication
Affects Version/s: 1.8.1
Fix Version/s: None

Participants: Andrea Bicciolo, Nicolas Martignoni and Petr Skoda
Security Level: None
QA Assignee: Nicolas Martignoni
Resolved date: 12/Jun/07
Affected Branches: MOODLE_18_STABLE


 Description  « Hide
To reproduce:
- create a course allowing guest access with no password
- in admin->Authentication, hide the Login as guest button
- now logoff, then click on the above course to enter it as guest.
- Moodle shows the login page.

If Login as guest button is is showed, autologingustes works correctly. Probably the correct behaviour should be:

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Andrea Bicciolo added a comment - 12/Jun/07 12:32 AM
Probably the correct behaviour should be:
1) if autologin is enabled and the course allows it, then autologin.
2) else, login page.

[ Permalink | « Hide ]
Petr Skoda added a comment - 12/Jun/07 04:33 AM
In fact it was a major security issue to allow logins when guest button is hidden.
The guest login was intentionally disabled when the button is hidden, there is no other way to disable guest logins.

Petr Skoda made changes - 12/Jun/07 04:33 AM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 1.8.1 [ 10213 ]
Resolution Won't Fix [ 2 ]
dwoolhead committed 1 file to 'Moodle CVS' - 15/Jun/07 12:08 AM
MDL-10084 Styling/branding
MODIFY theme/standard/styles_color.css   Rev. 1.135    (+0 -13 lines)
dwoolhead committed 1 file to 'Moodle CVS' - 19/Jun/07 12:49 AM
MDL-10084 Styling/branding
MODIFY theme/standard/styles_layout.css   Rev. 1.446    (+5 -5 lines)
dwoolhead committed 1 file to 'Moodle CVS' - 19/Jun/07 01:01 AM
MDL-10084 Styling/branding - deleted too much in previous commit
MODIFY theme/standard/styles_layout.css   Rev. 1.447    (+4 -0 lines)
dwoolhead committed 1 file to 'Moodle CVS' - 19/Jun/07 01:18 AM
MDL-10084 Styling/branding
MODIFY theme/standard/styles_layout.css   Rev. 1.448    (+1 -1 lines)
[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 19/Jun/07 03:08 AM
Closing per skodak comment.

Nicolas Martignoni made changes - 19/Jun/07 03:08 AM
Status Resolved [ 5 ] Closed [ 6 ]
QA Assignee mina
dwoolhead committed 1 file to 'Moodle CVS' - 19/Jun/07 08:02 PM
MDL-10084 Styling/branding
MODIFY theme/standard/styles_layout.css   Rev. 1.450    (+12 -0 lines)
dwoolhead committed 4 files to 'Moodle CVS' - 21/Jun/07 11:46 PM
MDL-10084 propogate course id through calendar pages to ensure consistent display for site front page, my moodle and courses
MODIFY calendar/view.php   Rev. 1.89    (+17 -14 lines)
MODIFY calendar/set.php   Rev. 1.20    (+11 -4 lines)
MODIFY calendar/lib.php   Rev. 1.188    (+16 -11 lines)
MODIFY calendar/event.php   Rev. 1.69    (+13 -13 lines)
dwoolhead committed 1 file to 'Moodle CVS' - 21/Jun/07 11:58 PM
MDL-10084 propogate course id through calendar pages to ensure consistent display for site front page, my moodle and courses
MODIFY calendar/export.php   Rev. 1.5    (+5 -5 lines)
dwoolhead committed 1 file to 'Moodle CVS' - 22/Jun/07 08:45 PM
MDL-10084 propogate course id through calendar pages to ensure consistent display for site front page, my moodle and courses
MODIFY blocks/calendar_month/block_calendar_month.php   Rev. 1.30    (+2 -2 lines)
dwoolhead committed 5 files to 'Moodle CVS' - 22/Jun/07 09:20 PM
MDL-10084 propogate course id through calendar pages to ensure consistent display for site front page, my moodle and courses
MODIFY calendar/set.php   Rev. 1.21    (+3 -1 lines)
MODIFY calendar/Attic/event_select.html   Rev. 1.8    (+1 -0 lines)
MODIFY calendar/Attic/event_delete.html   Rev. 1.7    (+3 -0 lines)
MODIFY calendar/Attic/event_new.html   Rev. 1.12    (+1 -0 lines)
MODIFY calendar/Attic/event_edit.html   Rev. 1.13    (+1 -0 lines)
dwoolhead committed 2 files to 'Moodle CVS' - 22/Jun/07 09:30 PM
MDL-10084 propogate course id through calendar pages to ensure consistent display for site front page, my moodle and courses
MODIFY calendar/lib.php   Rev. 1.189    (+9 -5 lines)
MODIFY calendar/view.php   Rev. 1.90    (+2 -1 lines)
dwoolhead committed 1 file to 'Moodle CVS' - 22/Jun/07 11:20 PM
MDL-10084 propogate course id through calendar pages to ensure consistent display for site front page, my moodle and courses
MODIFY calendar/view.php   Rev. 1.91    (+2 -2 lines)
dwoolhead committed 1 file to 'Moodle CVS' - 27/Jun/07 07:45 PM
MDL-10084 Styling/branding
MODIFY calendar/lib.php   Rev. 1.190    (+3 -3 lines)
dwoolhead committed 1 file to 'Moodle CVS' - 28/Jun/07 07:54 PM
MDL-10084 Styling/branding
MODIFY calendar/lib.php   Rev. 1.192    (+6 -6 lines)
dwoolhead committed 1 file to 'Moodle CVS' - 28/Jun/07 10:08 PM
MDL-10084 Styling/branding
MODIFY calendar/lib.php   Rev. 1.193    (+3 -3 lines)
toyomoyo committed 8 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 02/Oct/07 02:26 PM
MDL-10353, calendar not keeping course id in url, backporting MDL-10084
MODIFY calendar/event.php   Rev. 1.63.2.5    (+8 -8 lines)
MODIFY calendar/Attic/event_new.html   Rev. 1.11.2.1    (+1 -0 lines)
MODIFY calendar/view.php   Rev. 1.77.2.9    (+26 -16 lines)
MODIFY calendar/lib.php   Rev. 1.164.2.20    (+20 -7 lines)
MODIFY calendar/set.php   Rev. 1.17.6.3    (+11 -4 lines)
MODIFY calendar/Attic/event_select.html   Rev. 1.7.20.1    (+1 -0 lines)
MODIFY calendar/Attic/event_edit.html   Rev. 1.12.2.1    (+1 -0 lines)
MODIFY calendar/Attic/event_delete.html   Rev. 1.6.2.1    (+3 -0 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators