Moodle

Mnet : inconsistent list of services for test client

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8, 1.8.1
  • Fix Version/s: 1.8.4, 1.9, 2.0
  • Component/s: MNet
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

Description

With testclient.php, impossible to call the test function mnet_concatenate_strings.

Because it sounds there is a mix-up with sso service and mnet_concatenate_strings function. Isn't it?

Here is a fix:

Index: testclient.php
===================================================================
RCS file: /cvsroot/moodle/moodle/mnet/testclient.php,v
retrieving revision 1.1
diff -u -r1.1 testclient.php
— testclient.php 4 Jan 2007 02:33:52 -0000 1.1
+++ testclient.php 19 Jun 2007 09:55:24 -0000
@@ -44,7 +47,6 @@
$path_to_function[4] = 'system/methodHelp';
$path_to_function[5] = 'system/listServices';
$path_to_function[6] = 'system/listMethods';
-$path_to_function[7] = 'system/listMethods';

$paramArray[0] = array(array('some string, ', 'string'),
array('some other string, ', 'string'),
@@ -64,8 +66,6 @@

$paramArray[6] = array(array('sso', 'string'));

-$paramArray[7] = array(array('concatenate', 'string'));
-
echo 'Your local wwwroot appears to be <strong>'. $wwwroot ."</strong>.<br />\n";
echo "We will use this as the local <em>and</em> remote hosts.<br /><br />\n";
flush();
@@ -136,11 +136,12 @@
?>
<p>
Choose a function to call:<br />
+ <a href="testclient.php?func=0">mnet/rpclib/mnet_concatenate_strings</a><br />
+ <a href="testclient.php?func=1">mod/scorm/rpclib/scorm_add_floats</a><br />
<a href="testclient.php?func=2">system/listMethods</a><br />
<a href="testclient.php?func=3">system/methodSignature</a><br />
<a href="testclient.php?func=4">system/methodHelp</a><br />
<a href="testclient.php?func=5">listServices</a><br />
<a href="testclient.php?func=6">system/listMethods(SSO)</a><br />

  • <a href="testclient.php?func=7">system/listMethods(concatenate)</a><br />

Activity

Hide
Donal McMullan added a comment -

Hi Arnaud - the old testclient.php was really buggy - I hadn't kept it up to date with the API. The "concatenate_strings" function was one I created to help me develop and test the code. It was removed some time ago.

I thought testclient.php maybe wasn't very useful, so I rewrote it as a remote-service browser. There's not much of the old code in there anymore.

Now you can click on a host and drill down into the services and methods that it is publishing to your host. You can see the method profiles and descriptions (taken from the methods' docblocks).

I hope you consider this an improvement!

Show
Donal McMullan added a comment - Hi Arnaud - the old testclient.php was really buggy - I hadn't kept it up to date with the API. The "concatenate_strings" function was one I created to help me develop and test the code. It was removed some time ago. I thought testclient.php maybe wasn't very useful, so I rewrote it as a remote-service browser. There's not much of the old code in there anymore. Now you can click on a host and drill down into the services and methods that it is publishing to your host. You can see the method profiles and descriptions (taken from the methods' docblocks). I hope you consider this an improvement!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: