Generally speaking, I consider color selections to be theme issues rather than a usability issue. At the same time, I recognize that it is not always clear to the user where the turn editing on button is and that we actually have two options - the button and the link in the course administration block. I remember some talk about a highly accessible theme and perhaps we could have a highly usable theme that would cover color issues but I do not think that color alone will solve this issue. What might be helpful is to do a little research as to how editing mode is enabled in a variety of other systems (perhaps look at some other content management systems, LMSs, etc.) and see if there is a common theme that emerges. In general, it seems that having an editing on/off toggle button in the upper right portion of the screen works for Moodle once folks get used to it. I would want to make sure that we are consistent with that placement. For example, I think Gary Anderson told me that initially the editing button for the gradebook was on the left side. So I would want to make sure that we remain consistent and perhaps make a recommendation to developers for consistent placement of such buttons. Essentially it seems to follow the container model where by the editing options for that block (or container) are always in the upper right. Some questions I have that Laia might be able to research include:
Might we save some screen real estate by using an editing icon instead of the text 'Turn editing on'?
Would an icon confuse folks or be more consistent with how we use the editing icon in the gradebook?
When do we use an icon and when should we use a text labeled pushbutton?
What would be the logic for determining when to use an icon or a text labeled pushbutton?
Are there any UI standards that address these kinds of issues?
An example of where I think we are inconsistent currently is in the gradebook (see screenshot) at:
http://localhost/moodle/19stable/grade/edit/tree/category.php?courseid=3&id=3&gpr_type=report&gpr_plugin=grader&gpr_courseid=3 (just by way of example from a local test install). You will notice that the Hide Advanced appears twice on this screen within two different containers. Intuitively, this would indicate that you could hide advanced for each container; however, in fact they both function the same for the page so I think there should be one hide advanced pushbutton in the upper right of the page container.
I realize that many of my comments on the usability issues will involve a fair amount of research; however, I think if Laia were to collaborate with folks like Gary Anderson and AT Wyatt she might be able to make some solid recommendations that would benefit the Moodle community.
Peace - Anthony
Improvement
Open
Minor
A special style has been defined for this particular button. That style has been associated to the turn editing on /off, making it easier to find.