Moodle

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8, 1.8.1
• Fix Version/s: 1.8.4, 1.9, 2.0
• Component/s: MNet
• Labels:

  None

Function mnet_server_fault_xml of mnet/xmlrpc/server.php does not ever log the code and the text of the error.
Therefore it can be very hard to debug...

It's because mnet_server_prepare_response sometimes does nothing (if the request is not signed or not encrypted...).

Here is a very simple fix:

Index: server.php
===================================================================
RCS file: /cvsroot/moodle/moodle/mnet/xmlrpc/server.php,v
retrieving revision 1.10.2.1
diff -u -r1.10.2.1 server.php
— server.php 20 Feb 2007 02:05:31 -0000 1.10.2.1
+++ server.php 20 Jun 2007 12:00:45 -0000
@@ -277,7 +277,7 @@
</methodResponse>');

if (!empty($CFG->mnet_rpcdebug)) { - trigger_error("XMLRPC Error Response"); + trigger_error("XMLRPC Error Response $code $text"); trigger_error(print_r($return,1)); }

• Assignee:

  Donal McMullan

  Reporter:

  Arnaud saint-Georges

  Tester:

  Nobody

  Participants:

  Arnaud saint-Georges, Donal McMullan

• Created:

  20/Jun/07 8:03 PM

  Updated:

  17/Dec/10 1:15 PM

  Resolved:

  16/Oct/07 10:04 PM